[JIRA] (JENKINS-42234) Missing guard call to isMatch when processing update events

2017-02-22 Thread stephen.alan.conno...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stephen Connolly updated  JENKINS-42234  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42234  
 
 
  Missing guard call to isMatch when processing update events   
 

  
 
 
 
 

 
Change By: 
 Stephen Connolly  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-42234) Missing guard call to isMatch when processing update events

2017-02-22 Thread scm_issue_l...@java.net (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 SCM/JIRA link daemon commented on  JENKINS-42234  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Missing guard call to isMatch when processing update events   
 

  
 
 
 
 

 
 Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/MultiBranchProject.java http://jenkins-ci.org/commit/branch-api-plugin/4b0871555a30ef72fcabe940f78c96e97bb2fca8 Log: [FIXED JENKINS-42234] Add the isMatch guard  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-42234) Missing guard call to isMatch when processing update events

2017-02-21 Thread stephen.alan.conno...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stephen Connolly updated  JENKINS-42234  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42234  
 
 
  Missing guard call to isMatch when processing update events   
 

  
 
 
 
 

 
Change By: 
 Stephen Connolly  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-42234) Missing guard call to isMatch when processing update events

2017-02-21 Thread stephen.alan.conno...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stephen Connolly started work on  JENKINS-42234  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Stephen Connolly  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-42234) Missing guard call to isMatch when processing update events

2017-02-21 Thread stephen.alan.conno...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stephen Connolly created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42234  
 
 
  Missing guard call to isMatch when processing update events   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Stephen Connolly  
 
 
Components: 
 branch-api-plugin  
 
 
Created: 
 2017/Feb/21 9:16 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Stephen Connolly  
 

  
 
 
 
 

 
 https://github.com/jenkinsci/branch-api-plugin/blob/81e9fe59aef2329e0613c58fb4d66166c7406edd/src/main/java/jenkins/branch/MultiBranchProject.java#L1321-L1329 is missing a guard on SCMEvent.isMatch(SCMSource) so implementations that have overridden the default behaviour can end up with false triggers.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment