[JIRA] [job-dsl-plugin] (JENKINS-32941) Superfluous commands for Conditional steps with configure
Title: Message Title Daniel Spilker closed an issue as Fixed Jenkins / JENKINS-32941 Superfluous commands for Conditional steps with configure Change By: Daniel Spilker Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32941) Superfluous commands for Conditional steps with configure
Title: Message Title SCM/JIRA link daemon commented on JENKINS-32941 Re: Superfluous commands for Conditional steps with configure Code changed in jenkins User: Daniel Spilker Path: docs/Home.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/NodeEnhancement.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/DslScriptLoaderSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/NodeEnhancementSpec.groovy job-dsl-core/src/test/resources/JENKINS_32941.groovy job-dsl-core/src/test/resources/JENKINS_32941.xml http://jenkins-ci.org/commit/job-dsl-plugin/93e34508ec44c7583d7872e09a673fdc75471f27 Log: clone nodes before appending [FIXES JENKINS-32941] Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32941) Superfluous commands for Conditional steps with configure
Title: Message Title SCM/JIRA link daemon commented on JENKINS-32941 Re: Superfluous commands for Conditional steps with configure Code changed in jenkins User: Daniel Spilker Path: docs/Home.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/NodeEnhancement.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/DslScriptLoaderSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/NodeEnhancementSpec.groovy job-dsl-core/src/test/resources/JENKINS_32941.groovy job-dsl-core/src/test/resources/JENKINS_32941.xml http://jenkins-ci.org/commit/job-dsl-plugin/038b143c7387bfdce4b821b2aad0dd4d0bebb18a Log: Merge pull request #762 from daspilker/ JENKINS-32941 JENKINS-32941 clone nodes before appending Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/01a1f49d6db7...038b143c7387 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32941) Superfluous commands for Conditional steps with configure
Title: Message Title SCM/JIRA link daemon resolved as Fixed Jenkins / JENKINS-32941 Superfluous commands for Conditional steps with configure Change By: SCM/JIRA link daemon Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32941) Superfluous commands for Conditional steps with configure
Title: Message Title Daniel Spilker commented on JENKINS-32941 Re: Superfluous commands for Conditional steps with configure https://github.com/jenkinsci/job-dsl-plugin/pull/762 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32941) Superfluous commands for Conditional steps with configure
Title: Message Title Daniel Spilker commented on JENKINS-32941 Re: Superfluous commands for Conditional steps with configure This branch contains a test case: https://github.com/daspilker/job-dsl-plugin/commits/JENKINS-32491 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32941) Superfluous commands for Conditional steps with configure
Title: Message Title Daniel Spilker commented on JENKINS-32941 Re: Superfluous commands for Conditional steps with configure The problem is this: The context classes create and cache XML nodes. The configure block modifies those nodes when the final XML is constructed in javaposse.jobdsl.dsl.Item.getXml(). When getXml() is called multiple times, the changes done by the configure block accumulate. Currently the XML is constructed at least twice, once for logging the XML and once for updating the config in Jenkins. Solutions would be to avoid pre-creating nodes in contexts or to deep clone nodes before adding them, but that would be huge changes. Another solution can be to allow only one call to getXml() or to cache to generated XML in getXml() but that can break existing code. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-32941) Superfluous commands for Conditional steps with configure
Title: Message Title
Mattias Andersson created an issue
Jenkins / JENKINS-32941
Superfluous commands for Conditional steps with configure
Issue Type:
Bug
Assignee:
Daniel Spilker
Components:
job-dsl-plugin
Created:
15/Feb/16 9:21 AM
Priority:
Minor
Reporter:
Mattias Andersson
I would like to create a custom builder (using configure) in a Conditional Step.
job('example') {
steps {
conditionalSteps {
condition {
stringsMatch('${SOME_PARAMETER}', 'pants', false)
}
}
}
configure { project ->
project / builders / 'org.jenkinsci.plugins.conditionalbuildstep.ConditionalBuilder' / conditionalbuilders << 'hudson.tasks.Shell' {
command 'echo Hello'
}
}
}
The resulting config.xml becomes
"org.jenkins_ci.plugins.run_condition.core.StringsMatchCondition">
${SOME_PARAMETER}
pants
false
