[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38058 Re: Properly pass context in folder's page objects Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/test/acceptance/po/Folder.java http://jenkins-ci.org/commit/acceptance-test-harness/88be022841ce43fe79fe57f32a8169314384fd48 Log: Merge pull request #264 from mafraba/JENKINS-38058 JENKINS-38058 bring back lost constructor for 'Folder' Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/252150450053...88be022841ce Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title Manuel Franco resolved as Fixed Jenkins / JENKINS-38058 Properly pass context in folder's page objects Change By: Manuel Franco Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38058 Re: Properly pass context in folder's page objects Code changed in jenkins User: Manuel Franco Path: src/main/java/org/jenkinsci/test/acceptance/po/FolderItem.java src/main/java/org/jenkinsci/test/acceptance/po/Job.java src/main/java/org/jenkinsci/test/acceptance/po/JobsMixIn.java src/main/java/org/jenkinsci/test/acceptance/po/PageObject.java src/main/java/org/jenkinsci/test/acceptance/po/TopLevelItem.java http://jenkins-ci.org/commit/acceptance-test-harness/7454e7762a9fe63e6d2e7761b3cf6c090d869311 Log: JENKINS-38058 pass context when creating 'FolderItem' objects Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38058 Re: Properly pass context in folder's page objects Code changed in jenkins User: Manuel Franco Path: src/main/java/org/jenkinsci/test/acceptance/po/JobsMixIn.java http://jenkins-ci.org/commit/acceptance-test-harness/b26cce4360c36228d60393a2d3a4ce8d06497b66 Log: JENKINS-38058 explicit check for constructor existence Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38058 Re: Properly pass context in folder's page objects Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/test/acceptance/po/FolderItem.java src/main/java/org/jenkinsci/test/acceptance/po/Job.java src/main/java/org/jenkinsci/test/acceptance/po/JobsMixIn.java src/main/java/org/jenkinsci/test/acceptance/po/PageObject.java src/main/java/org/jenkinsci/test/acceptance/po/TopLevelItem.java http://jenkins-ci.org/commit/acceptance-test-harness/002b21349a9cad8e478e7d44f665517db12a370c Log: Merge pull request #186 from mafraba/JENKINS-38058 JENKINS-38058 pass context when creating 'FolderItem' objects Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/7d482f4e3315...002b21349a9c Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title Manuel Franco updated JENKINS-38058 Jenkins / JENKINS-38058 Properly pass context in folder's page objects Change By: Manuel Franco Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title Manuel Franco updated an issue Jenkins / JENKINS-38058 Properly pass context in folder's page objects Change By: Manuel Franco Environment: ATH 1. 38 39 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title Manuel Franco updated JENKINS-38058 Jenkins / JENKINS-38058 Properly pass context in folder's page objects Change By: Manuel Franco Status: In Review Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title Manuel Franco started work on JENKINS-38058 Change By: Manuel Franco Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title
Manuel Franco updated an issue
Jenkins / JENKINS-38058
Properly pass context in folder's page objects
Change By:
Manuel Franco
Let's describe the issue with a test. Assumming we already have an injector and a {{JenkinsController}}, the following test will fail:{code:java}Jenkins j1 = new Jenkins(injector, jenkinsController);FolderItem f = j1.jobs.create(FolderItem.class);Assert.assertSame(j1, f.jobs.getJenkins());{code}The problem reproduced is the same described in JENKINS- XXX 37615 , but specific to {{FolderItem}}s, since they are not properly receiving their context when created.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title
Manuel Franco updated an issue
Jenkins / JENKINS-38058
Properly pass context in folder's page objects
Change By:
Manuel Franco
Let's describe the issue with a test. Assumming we already have an injector and a {{ JenkinsController }} , the following test will fail:{code:java}Jenkins j1 = new Jenkins(injector, jenkinsController);FolderItem f = j1.jobs.create(FolderItem.class);Assert.assertSame(j1, f.jobs.getJenkins());{code}The problem reproduced is the same described in JENKINS-XXX, but specific to {{FolderItem}}s, since they are not properly receiving their context when created.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title
Manuel Franco updated an issue
Jenkins / JENKINS-38058
Properly pass context in folder's page objects
Change By:
Manuel Franco
Let's describe the issue with a test. Assumming we already have an injector and a JenkinsController, the following test will fail:{code:java}Jenkins j1 = new Jenkins(injector, jenkinsController); Assert.assertSame(j1, j1.jobs.getJenkins());Jenkins j1 = new Jenkins(injector, jc);Assert.assertSame(j1, j1.jobs.getJenkins()); FolderItem f = j1.jobs.create(FolderItem.class);Assert.assertSame(j1, f.jobs.getJenkins());{code}The problem reproduced is that the jenkins instance returned by the {{getJenkins()}} method same described in the {{JobsMixIn}} object (actually inherited from {{PageObject}}) is not the instance that was passed as a context in the construction of this last one JENKINS-XXX , but an instance that is looked up (and built if needed) using guice.This leads specific to potential inconsistencies for some operations (e.g. {{ jobs.create FolderItem }} ) that rely on querying its jenkins instance s , for example for the version number.Sometimes as an [external user|https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/EXTERNAL.md] of the ATH I may need to create several instances with different versions, and want each jobs mixin to know exactly to which jenkins since they belong to and behave consistently are not properly receiving their context when created .
Add Comment
This message was sent by
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title Manuel Franco created an issue Jenkins / JENKINS-38058 Properly pass context in folder's page objects Issue Type: Bug Assignee: Manuel Franco Components: acceptance-test-harness Created: 2016/Sep/08 9:50 AM Environment: ATH 1.38 Labels: test Priority: Minor Reporter: Manuel Franco Let's describe the issue with a test. Assumming we already have an injector and a JenkinsController, the following test will fail: Jenkins j1 = new Jenkins(injector, jenkinsController); Assert.assertSame(j1, j1.jobs.getJenkins()); The problem is that the jenkins instance returned by the getJenkins() method in the JobsMixIn object (actually inherited from PageObject) is not the instance that was passed as a context in the construction of this last one, but an instance that is looked up (and built if needed) using guice. This leads to potential inconsistencies for some operations (e.g. jobs.create) that rely on querying its jenkins instance, for example for the version number. Sometimes as an external user of the ATH I may need to create several instances with different versions, and want each jobs mixin to know exactly to which jenkins they belong to and behave consistently.
[JIRA] (JENKINS-38058) Properly pass context in folder's page objects
Title: Message Title
Manuel Franco updated an issue
Jenkins / JENKINS-38058
Properly pass context in folder's page objects
Change By:
Manuel Franco
Let's describe the issue with a test. Assumming we already have an injector and a JenkinsController, the following test will fail:{code:java}Jenkins j1 = new Jenkins(injector, jenkinsController);Assert.assertSame(j1, j1.jobs.getJenkins()); Jenkins j1 = new Jenkins(injector, jc);Assert.assertSame(j1, j1.jobs.getJenkins());FolderItem f = j1.jobs.create(FolderItem.class);Assert.assertSame(j1, f.jobs.getJenkins()); {code}The problem is that the jenkins instance returned by the {{getJenkins()}} method in the {{JobsMixIn}} object (actually inherited from {{PageObject}}) is not the instance that was passed as a context in the construction of this last one, but an instance that is looked up (and built if needed) using guice.This leads to potential inconsistencies for some operations (e.g. {{jobs.create}}) that rely on querying its jenkins instance, for example for the version number.Sometimes as an [external user|https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/EXTERNAL.md] of the ATH I may need to create several instances with different versions, and want each jobs mixin to know exactly to which jenkins they belong to and behave consistently.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
