[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title Brody Maclean assigned an issue to Michael Neale Jenkins / JENKINS-38496 Aborted state is inconsistent Change By: Brody Maclean Assignee: Brody Maclean Michael Neale Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title Brody Maclean commented on JENKINS-38496 Re: Aborted state is inconsistent Zeplin link https://zpl.io/H3odi Icon = Remove – https://design.google.com/icons/#ic_remove Mockup Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title Brody Maclean updated an issue Jenkins / JENKINS-38496 Aborted state is inconsistent Change By: Brody Maclean Attachment: Aborted.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title Brody Maclean started work on JENKINS-38496 Change By: Brody Maclean Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title Sam Van Oort edited a comment on JENKINS-38496 Re: Aborted state is inconsistent In answer to your questions: > Is "aborted" a failed state? should it be red?It's a special case of failure (like paused or waiting for input is a special case of "in progress") - an ErrorAction and also build result is attached to the step and its enclosing blocks. > What is a more appropriate icon?In classic Jenkins this merits a gray rather than red ball color. Personally, I'm all for it if you guys throw that out and do some sort of failure icon with additional decoration to show abort. > a bunch of questions about specific casesYes, steps can be aborted, and yes they should carry the same indicator. Their enclosing block will too.I'd point you guys at the classic Jenkins Result object: http://javadoc.jenkins-ci.org/hudson/model/Result.htmlAnd the Bismuth (pipeline graph analysis) component here - https://github.com/jenkinsci/pipeline-graph-analysis-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/pipelinegraphanalysis/GenericStatus.java Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title James Dumay commented on JENKINS-38496 Re: Aborted state is inconsistent Sam Van Oort nice - thanks for the context! Michael Neale will need to get Vivek Pandey to consider this when he implements the bismuth api Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title Michael Neale commented on JENKINS-38496 Re: Aborted state is inconsistent Thanks Sam. I like Abort being disctinct from failure, quite clearly (ie grey isn't terribly) IMO Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title Sam Van Oort edited a comment on JENKINS-38496 Re: Aborted state is inconsistent In answer to your questions: > Is "aborted" a failed state? should it be red?It's a special case of failure (like paused or waiting for input is a special case of "in progress") - an ErrorAction and also build result is attached to the step and its enclosing blocks. > What is a more appropriate icon?In classic Jenkins this merits a gray rather than red ball color. Personally, I'm all for it you guys throw that out and do sort of failure icon with additional decoration to show abort. > a bunch of questions about specific casesYes, steps can be aborted, and yes they should carry the same indicator. Their enclosing block will too. I'd point you guys at the classic Jenkins Result object: http://javadoc.jenkins-ci.org/hudson/model/Result.htmlAnd the Bismuth (pipeline graph analysis) component here - https://github.com/jenkinsci/pipeline-graph-analysis-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/pipelinegraphanalysis/GenericStatus.java Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title Sam Van Oort commented on JENKINS-38496 Re: Aborted state is inconsistent In answer to your questions: > Is "aborted" a failed state? should it be red? It's a special case of failure (like paused or waiting for input is a special case of "in progress") - an ErrorAction and also build result is attached to the step and its enclosing blocks. > What is a more appropriate icon? In classic Jenkins this merits a gray rather than red ball color. Personally, I'm all for it you guys throw that out and do sort of failure icon with additional decoration to show abort. > a bunch of questions about specific cases Yes, steps can be aborted, and yes they should carry the same indicator. I'd point you guys at the classic Jenkins Result object: http://javadoc.jenkins-ci.org/hudson/model/Result.html And the Bismuth (pipeline graph analysis) component here - https://github.com/jenkinsci/pipeline-graph-analysis-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/pipelinegraphanalysis/GenericStatus.java Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title James Dumay created an issue Jenkins / JENKINS-38496 Aborted state is inconsistent Issue Type: Task Assignee: Brody Maclean Attachments: Jenkins Blue Ocean 2016-09-21 13-58-47.png Components: blueocean-plugin Created: 2016/Sep/26 5:21 AM Priority: Minor Reporter: James Dumay Brody Maclean correctly identified that the aborted status is inconsistently used. In this task we should resolve: Is "aborted" a failed state? should it be red? What is a more appropriate icon? Can steps be aborted? (might need to tap Vivek Pandey or Sam Van Oort on the shoulder to answer this one). If so, should we be showing the same indicator in the pipeline graph and on the aborted step? Add Comment
[JIRA] (JENKINS-38496) Aborted state is inconsistent
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-38496 Aborted state is inconsistent Change By: James Dumay Sprint: next Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
