[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-15 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY updated  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-14 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
 https://github.com/jenkinsci/blueocean-plugin/pull/825  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-14 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY updated  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-14 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY started work on  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-14 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY stopped work on  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 In Progress Open  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-14 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
 And I'm not sure adding user/requester specific data onto the side of these domain object REST responses would be very restful as it it would make them uncacheable etc.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-14 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
 Hmmm ... need to talk to Vivek Pandey about this. We need some way of checking a user permission on a domain object. I don't see that there atm.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-13 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY started work on  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-04 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Sprint: 
 tethys, pannonian , iapetus  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-02 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY stopped work on  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 In Progress Open  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-02-01 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY started work on  JENKINS-40755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-01-23 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay assigned an issue to Tom FENNELLY  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Assignee: 
 Thorsten Scherler Tom FENNELLY  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-01-22 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay assigned an issue to Thorsten Scherler  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Assignee: 
 Michael Neale Thorsten Scherler  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-01-20 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Sprint: 
 tethys , pannonian  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-01-05 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay assigned an issue to Michael Neale  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Michael Neale I think its only fair that you get to fix this one   
 

  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Assignee: 
 Ivan Meredith Michael Neale  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-01-05 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 

  
 
 
 
 

 
 We need to check if the current user has the edit permission when choosing to display the cog icon on the result screen. *In Scope** Audit all the locations where we show the settings link to ensure that that they honour the edit permission* update any that do not honour the edit permission  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-01-05 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Sprint: 
 kraken release candidate  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-01-05 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Sprint: 
 release candidate tethys  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40755) Settings link appears when user does not have edit permissions

2017-01-02 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40755  
 
 
  Settings link appears when user does not have edit permissions   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Ivan Meredith  
 
 
Attachments: 
 1.png, 2.png  
 
 
Components: 
 blueocean-plugin  
 
 
Created: 
 2017/Jan/02 10:24 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 James Dumay  
 

  
 
 
 
 

 
 We need to check if the current user has the edit permission when choosing to display the cog icon on the result screen.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment