[JIRA] (JENKINS-41029) Promotions aren't copies when job generated with DSL

2017-01-31 Thread elad.shmita...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Elad Shmitanka commented on  JENKINS-41029  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Promotions aren't copies when job generated with DSL   
 

  
 
 
 
 

 
 Seems that the issue is with the construction of the  

 
JobPropertyImpl 

 in the jobDsl contect, the class is initiated and a call is made to  

 
setOwner 

 which, in turn, runs  

 
loadChildren 

 . Problem is, in this context, the root dir, is now the NEW job, not the old one, so, the class isn't initiated properly and thus, later, the List of  

 
processes 

  is left empty. I think, that also, part of the problem, is that in no entry point between the jobDsl plugin code, to the promotion one, I have see any reference that passes the name of the template job, which makes it impossibly to load it from the right context. Solution would be either: 
 
pass 

 
dslItem 

  on  

 
javaposse/jobdsl/plugin/JenkinsJobManagement.class:492 

  (or anywhere else before so, like, in the initialisation if the  

 
JobPropertyImpl 

 
Change the Promotion plugin to NOT use subfolders and have all the context in the original XML of the job

[JIRA] (JENKINS-41029) Promotions aren't copies when job generated with DSL

2017-01-31 Thread o.v.nenas...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Oleg Nenashev updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41029  
 
 
  Promotions aren't copies when job generated with DSL   
 

  
 
 
 
 

 
Change By: 
 Oleg Nenashev  
 
 
Labels: 
 job-dsl  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-41029) Promotions aren't copies when job generated with DSL

2017-01-12 Thread elad.shmita...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Elad Shmitanka created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41029  
 
 
  Promotions aren't copies when job generated with DSL   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Daniel Spilker  
 
 
Components: 
 job-dsl-plugin, promoted-builds-plugin  
 
 
Created: 
 2017/Jan/12 12:26 PM  
 
 
Environment: 
 Jenkins 2.40  Promoted Build Plugin version: 2.28  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Elad Shmitanka  
 

  
 
 
 
 

 
 Sample DSL: 

 

freeStyleJob('test1') {
  properties {
promotions {
  promotion {
name('promotion 1')
icon('Silver white star')
conditions {
  manual('admin')
}
actions {
  shell "echo test"
}
  }
}
  }
}

freeStyleJob('test2') {
  using('test1')
}
 

 test1 is built fine XML for test2: 

 

"1.0" encoding="UTF-8"?>


false

"promoted-builds@2.28">

promotion 1



"hudson.scm.NullSCM"/>
true
false
false
false

false




 

 however, no promotions: 

 

# ls