[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Alex Earl resolved as Fixed Jenkins / JENKINS-41134 failures in the windows build are ignored Change By: Alex Earl Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title SCM/JIRA link daemon commented on JENKINS-41134 Re: failures in the windows build are ignored Code changed in jenkins User: Alex Earl Path: src/test/java/hudson/tasks/junit/TestResultTest.java src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_first.xml src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_second.xml http://jenkins-ci.org/commit/junit-plugin/c0f470f994693d50d78491bde7deb938903ccd7e Log: Add test for JENKINS-41134 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title SCM/JIRA link daemon commented on JENKINS-41134 Re: failures in the windows build are ignored Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/tasks/junit/TestResult.java src/test/java/hudson/tasks/junit/TestResultTest.java src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_first.xml src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_second.xml src/test/resources/hudson/tasks/junit/JENKINS-41134/TestSuite_second_dup_first.xml http://jenkins-ci.org/commit/junit-plugin/631c41350f6eb24520af19083a9f2fe27163f572 Log: Merge pull request #63 from slide/master Fix JENKINS-41134 Compare: https://github.com/jenkinsci/junit-plugin/compare/90e7ddbda961...631c41350f6e Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Alex Earl assigned an issue to Alex Earl Jenkins / JENKINS-41134 failures in the windows build are ignored Change By: Alex Earl Assignee: Alex Earl Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Alex Earl commented on JENKINS-41134 Re: failures in the windows build are ignored See https://github.com/jenkinsci/junit-plugin/pull/63 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Daniel Beck commented on JENKINS-41134 Re: failures in the windows build are ignored That's where I'd have put it. Should be straightforward to write a test for. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title
Alex Earl commented on JENKINS-41134
Re: failures in the windows build are ignored
This is the change I made to TestResult.java
void merge(TestResult other) {
for (SuiteResult suite : other.suites) {
suite.setParent(null); // otherwise freeze ignores it
add(suite);
}
tally();
}
The call to tally() at the end is the addition.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Alex Earl commented on JENKINS-41134 Re: failures in the windows build are ignored That's looks like it is the problem. With the call to tally() in TestResult.merge(), the failures show up correctly and the build is marked as unstable. Not sure if the location I put the call is correct for all use cases, if people think it is, I can create a PR for it for the junit-plugin. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Alex Earl commented on JENKINS-41134 Re: failures in the windows build are ignored I added a call to tally() in the merge method of TestResult (which amounts to the same thing as putting it in mergeResult(). Rerunning...takes about 3 hours. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Daniel Beck commented on JENKINS-41134 Re: failures in the windows build are ignored Maybe a missing tally() call in mergeResult()? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Alex Earl commented on JENKINS-41134 Re: failures in the windows build are ignored I added a bit of logging to the junit plugin and when it gets to this point: https://github.com/jenkinsci/junit-plugin/blob/master/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java#L196 getFailCount() is returning 0. I'll continue to dig in. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Daniel Beck commented on JENKINS-41134 Re: failures in the windows build are ignored It's JUnit Plugin 1.19 on ci.j.io. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title James Nord commented on JENKINS-41134 Re: failures in the windows build are ignored I filed this at first as I thought the Jenkinsfile was wrong and was going to do a quick PR. Then I saw that it looked correct and hence my update above. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Jesse Glick commented on JENKINS-41134 Re: failures in the windows build are ignored You are passing -Dmaven.test.failure.ignore=true so the build correctly moves on. Why the junit step is not marking the build UNSTABLE I am not sure offhand. Would need to narrow it down to a reproducible test case perhaps. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title
James Nord updated an issue
Jenkins / JENKINS-41134
failures in the windows build are ignored
Change By:
James Nord
the Jenkisnfile Jenkisfile to build core ignores unit test failures on windows.https://ci.jenkins.io/job/Core/job/jenkins/job/master/209/console{noformat}02:49:52.718 [Windows] Tests run: 9198, Failures: 53, Errors: 11, Skipped: 34, Flakes: 302:49:52.718 [Windows] 02:49:52.718 [Windows] [ERROR] There are test failures.02:49:52.718 [Windows] {noformat}yet https://ci.jenkins.io/job/Core/job/jenkins/job/master/209 is PASSED
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title James Nord commented on JENKINS-41134 Re: failures in the windows build are ignored Looks like an issue in the junit plugin? there are test failures and it shows them - but at the same time it says "no test failures" Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title James Nord updated an issue Jenkins / JENKINS-41134 failures in the windows build are ignored Change By: James Nord Attachment: Untitled.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title James Nord updated an issue Jenkins / JENKINS-41134 failures in the windows build are ignored Change By: James Nord Component/s: junit-plugin Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title James Nord updated an issue Jenkins / JENKINS-41134 failures in the windows build are ignored Change By: James Nord Priority: Major Blocker Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-41134 failures in the windows build are ignored Change By: Jesse Glick Labels: testing Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-41134) failures in the windows build are ignored
Title: Message Title James Nord created an issue Jenkins / JENKINS-41134 failures in the windows build are ignored Issue Type: Bug Assignee: Unassigned Components: core Created: 2017/Jan/17 2:18 PM Priority: Major Reporter: James Nord the Jenkisnfile to build core ignores unit test failures on windows. https://ci.jenkins.io/job/Core/job/jenkins/job/master/209/console 02:49:52.718 [Windows] Tests run: 9198, Failures: 53, Errors: 11, Skipped: 34, Flakes: 3 02:49:52.718 [Windows] 02:49:52.718 [Windows] [ERROR] There are test failures. 02:49:52.718 [Windows] yet https://ci.jenkins.io/job/Core/job/jenkins/job/master/209 is PASSED Add Comment
