[JIRA] (JENKINS-42006) REGRESSION: NPE when checking permissions - UserImpl.getPermission

2017-02-15 Thread vivek.pan...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey updated  JENKINS-42006  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42006  
 
 
  REGRESSION: NPE when checking permissions - UserImpl.getPermission   
 

  
 
 
 
 

 
Change By: 
 Vivek Pandey  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42006) REGRESSION: NPE when checking permissions - UserImpl.getPermission

2017-02-14 Thread vivek.pan...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey updated  JENKINS-42006  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42006  
 
 
  REGRESSION: NPE when checking permissions - UserImpl.getPermission   
 

  
 
 
 
 

 
Change By: 
 Vivek Pandey  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42006) REGRESSION: NPE when checking permissions - UserImpl.getPermission

2017-02-14 Thread vivek.pan...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey commented on  JENKINS-42006  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: REGRESSION: NPE when checking permissions - UserImpl.getPermission   
 

  
 
 
 
 

 
 Opened PR on github-oauth plugin https://github.com/jenkinsci/github-oauth-plugin/pull/76.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42006) REGRESSION: NPE when checking permissions - UserImpl.getPermission

2017-02-14 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale commented on  JENKINS-42006  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: REGRESSION: NPE when checking permissions - UserImpl.getPermission   
 

  
 
 
 
 

 
 Vivek Pandey yes removing it sounds like the reasonable and conservative approach, but I am not sure I have the full picture.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42006) REGRESSION: NPE when checking permissions - UserImpl.getPermission

2017-02-14 Thread vivek.pan...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey commented on  JENKINS-42006  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: REGRESSION: NPE when checking permissions - UserImpl.getPermission   
 

  
 
 
 
 

 
 Michael NealeJames Dumay At present, User API allows fetching other user's permissions. At present it's determine by checking authenticated user's userid with the user id being asked in the API url e.g. /users/:id. If they do not match, and logged in user has admin rights, requested user is impersonated and his permissions are read. Its during this impersonation, NPE is happening from github-oauth-plugin. its a bug there, a null check is missing. There is also perf implication, however it can happen only if something is calling user API during activities rendering.  In any case, I don't know if there is use case to serve other user's permission. I propose we remove this feature of returning other user's permission. thoughts?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42006) REGRESSION: NPE when checking permissions - UserImpl.getPermission

2017-02-14 Thread vivek.pan...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Vivek Pandey started work on  JENKINS-42006  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Vivek Pandey  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-42006) REGRESSION: NPE when checking permissions - UserImpl.getPermission

2017-02-14 Thread mne...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Neale updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42006  
 
 
  REGRESSION: NPE when checking permissions - UserImpl.getPermission   
 

  
 
 
 
 

 
Change By: 
 Michael Neale  
 
 
Summary: 
 REGRESSION: NPE when  loading branches for blueocean pipeline  checking permissions  - UserImpl.getPermission  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.