[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title SCM/JIRA link daemon commented on JENKINS-42640 Re: Integer and decimal step parameters are save as string in Pipeline Editor Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/DescriptorLookupCache.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTStep.java pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/Messages.properties pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/JSONValidationTest.java pipeline-model-definition/src/test/resources/json/errors/jsonParameterTypeCoercion.json http://jenkins-ci.org/commit/pipeline-model-definition-plugin/2b20c589ab6f955c12471c2061e3a2bc01b28079 Log: JENKINS-42640 Fix validation of wrappers and some types In validating the options contents, we didn't actually look for a StepDescriptor, just a symbol-driven Descriptor. Which won't work for steps! So we never actually validated the contents of wrappers in options. Besides that, we needed to reject converting to int from String/Boolean - that gets through ScriptByteCodeAdapter.castToType, but not runtime. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title James Dumay updated JENKINS-42640 Thanks again Jenkins / JENKINS-42640 Integer and decimal step parameters are save as string in Pipeline Editor Change By: James Dumay Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title James Dumay commented on JENKINS-42640 Re: Integer and decimal step parameters are save as string in Pipeline Editor Thanks a lot Andrew Bayer - appreciate the fast turn around Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title Andrew Bayer commented on JENKINS-42640 Re: Integer and decimal step parameters are save as string in Pipeline Editor Declarative PR up for this (and JENKINS-42551) at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/133 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title SCM/JIRA link daemon commented on JENKINS-42640 Re: Integer and decimal step parameters are save as string in Pipeline Editor Code changed in jenkins User: Jeremie Violas Path: src/main/js/components/properties/DecimalPropertyInput.jsx src/main/js/components/properties/IntegerPropertyInput.jsx http://jenkins-ci.org/commit/blueocean-pipeline-editor-plugin/e0a0d5c3cee8fbe6f79d449570df8de92bddb4b7 Log: JENKINS-42640: Parse the value of the input of integer and decimal parameter before setting it in step data. (#30) Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title James Dumay updated JENKINS-42640 Jenkins / JENKINS-42640 Integer and decimal step parameters are save as string in Pipeline Editor Change By: James Dumay Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title James Dumay started work on JENKINS-42640 Change By: James Dumay Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title James Dumay commented on JENKINS-42640 Re: Integer and decimal step parameters are save as string in Pipeline Editor Thanks for the contribution jeremie violas Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title James Dumay assigned an issue to jeremie violas Jenkins / JENKINS-42640 Integer and decimal step parameters are save as string in Pipeline Editor Change By: James Dumay Assignee: James Dumay jeremie violas Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title jeremie violas commented on JENKINS-42640 Re: Integer and decimal step parameters are save as string in Pipeline Editor I think I tracked where the issue is, and I've submitted this pull request to fix it : https://github.com/jenkinsci/blueocean-pipeline-editor-plugin/pull/30 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-42640 Integer and decimal step parameters are save as string in Pipeline Editor Change By: James Dumay Component/s: pipeline-model-definition-plugin Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-42640 Integer and decimal step parameters are save as string in Pipeline Editor Change By: James Dumay Sprint: 1.0 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42640) Integer and decimal step parameters are save as string in Pipeline Editor
Title: Message Title jeremie violas created an issue Jenkins / JENKINS-42640 Integer and decimal step parameters are save as string in Pipeline Editor Issue Type: Bug Assignee: James Dumay Components: blueocean-pipeline-editor-plugin Created: 2017/Mar/09 8:42 PM Priority: Minor Reporter: jeremie violas When editing a step with an integer parameter (for example Sleep), the saved value for this parameter is a string, and this make the resulting pipeline failing. Here is an sample of what is generated by the pipeline editor sleep(time: '5', unit: 'MINUTES') and what is should have been sleep(time: 5, unit: 'MINUTES') Add
