[JIRA] (JENKINS-50566) Google Compute Engine Plugin JEP-200 Class rejected
Title: Message Title Oleg Nenashev commented on JENKINS-50566 Re: Google Compute Engine Plugin JEP-200 Class rejected So it's not resolved I'd guess Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50566) Google Compute Engine Plugin JEP-200 Class rejected
Title: Message Title Oleg Nenashev updated JENKINS-50566 Jenkins / JENKINS-50566 Google Compute Engine Plugin JEP-200 Class rejected Change By: Oleg Nenashev Status: Resolved In Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50566) Google Compute Engine Plugin JEP-200 Class rejected
Title: Message Title Oleg Nenashev commented on JENKINS-50566 Re: Google Compute Engine Plugin JEP-200 Class rejected Evan Brown In order to test it... In the local build with Maven you can use "mvn clean verify -Djenkins.version=2.107.2" to run with particular versions In Jenkinsfile you can use: buildPugin(jenkinsVersions: [null, '2.107.2'])/ It will make the PR builder to run tests with the current and the specified Maven version Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50566) Google Compute Engine Plugin JEP-200 Class rejected
Title: Message Title Oleg Nenashev commented on JENKINS-50566 Re: Google Compute Engine Plugin JEP-200 Class rejected AFAICT all problems come from the Launcher classes, which includes com.google.api.services.compute.model.Operation and the referenced chain of classes. But maybe there are other entries as well. It should be relatively easy to write a unit test and to capture at least some missing classes, but things like JacksonFactory worry me a lot. at hudson.XmlFile.write(XmlFile.java:200) at jenkins.model.Nodes.persistNode(Nodes.java:160) at jenkins.model.Nodes.addNode(Nodes.java:142) at jenkins.model.Jenkins.addNode(Jenkins.java:2054) at com.google.jenkins.plugins.computeengine.ComputeEngineCloud.doProvision(ComputeEngineCloud.java:283) The entire idea to Serialize Cloud agents to disk is a bit questionable, but there is some logic dependent on it. Note that Google OAuth plugin is also affected by JEP-200 (JENKINS-50216). Without it this plugin cannot work AFAICT, at least in some cases. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] (JENKINS-50566) Google Compute Engine Plugin JEP-200 Class rejected
Title: Message Title Emil Wypych commented on JENKINS-50566 Re: Google Compute Engine Plugin JEP-200 Class rejected There is a full stacktrace with "java.lang.reflect.Field": java.lang.UnsupportedOperationException: Refusing to marshal java.lang.reflect.Field for security reasons; see https://jenkins.io/redirect/class-filter/ at hudson.util.XStream2$BlacklistedTypesConverter.marshal(XStream2.java:543) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84) at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265) at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252) Caused: java.lang.RuntimeException: Failed to serialize com.google.api.client.util.FieldInfo#field for class com.google.api.client.util.FieldInfo at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256) at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224) at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138) at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88) at com.thoughtworks.xstream.converters.reflection.SerializableConverter$1.writeToStream(SerializableConverter.java:140) at com.thoughtworks.xstream.core.util.CustomObjectOutputStream.writeObjectOverride(CustomObjectOutputStream.java:84) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:344) at java.util.IdentityHashMap.writeObject(IdentityHashMap.java:1289) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.thoughtworks.xstream.converters.reflection.SerializationMethodInvoker.callWriteObject(SerializationMethodInvoker.java:135) Caused: com.thoughtworks.xstream.converters.ConversionException: Could not call java.util.IdentityHashMap.writeObject() : Failed to serialize com.google.api.client.util.FieldInfo#field for class com.google.api.client.util.FieldInfo Debugging information message : Could not call java.util.IdentityHashMap.writeObject() cause-exception : java.lang.RuntimeException cause-message : Failed to serialize com.google.api.client.util.FieldInfo#field for class com.google.api.client.util.FieldInfo --- at com.thoughtworks.xstream.converters.reflection.SerializationMethodInvoker.callWriteObject(SerializationMethodInvoker.java:141) at
[JIRA] (JENKINS-50566) Google Compute Engine Plugin JEP-200 Class rejected
Title: Message Title Oleg Nenashev edited a comment on JENKINS-50566 Re: Google Compute Engine Plugin JEP-200 Class rejected I cannot imagine wy the plugin would need to persist "java.lang.reflect.Field", likely needs to be fixed. IdentityHashMap could be whitelisted.Regarding google classes, things like PemReader indicate that likely there are issues with transient fields in the plugin (likely anon classes are passed) Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50566) Google Compute Engine Plugin JEP-200 Class rejected
Title: Message Title Oleg Nenashev commented on JENKINS-50566 Re: Google Compute Engine Plugin JEP-200 Class rejected I cannot imagine wy the plugin would need to persist "java.lang.reflect.Field", likely needs to be fixed. IdentityHashMap could be whitelisted. Regarding google classes, things like PemReader indicate that likely there are issues with transient fields in the plugin Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50566) Google Compute Engine Plugin JEP-200 Class rejected
Title: Message Title Emil Wypych commented on JENKINS-50566 Re: Google Compute Engine Plugin JEP-200 Class rejected This is the list of affected classes - it's not complete. Just cannot dig deeper... com.google.api classes are easy to fix, but I don't know what about java.lang.* com.google.api.client.googleapis.javanet.GoogleNetHttpTransport com.google.api.client.googleapis.services.AbstractGoogleClientRequest com.google.api.client.googleapis.services.GoogleClientRequestInitializer com.google.api.services.compute.model.AcceleratorType com.google.api.services.compute.Compute com.google.api.services.compute.model.Instance com.google.api.client.json.jackson.JacksonFactory com.google.api.client.util.PemReader com.google.api.services.compute.model.Network com.google.api.services.compute.model.Subnetwork com.google.api.services.compute.model.Image com.google.api.services.compute.model.Operation com.google.api.client.util.ArrayMap com.google.api.client.util.ClassInfo java.util.IdentityHashMap com.google.api.client.util.FieldInfo java.lang.reflect.Field Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-50566) Google Compute Engine Plugin JEP-200 Class rejected
Title: Message Title Emil Wypych created an issue Jenkins / JENKINS-50566 Google Compute Engine Plugin JEP-200 Class rejected Issue Type: Bug Assignee: Evan Brown Attachments: Screen Shot 2018-04-04 at 11.21.09.png, Screen Shot 2018-04-04 at 11.21.20.png Components: google-compute-engine-plugin Created: 2018-04-04 09:24 Environment: Jenkins 2.107 - docker image Google Compute Engine Plugin - v. 1.0.1 Labels: JEP-200 Priority: Critical Reporter: Emil Wypych Google Compute Engine Plugin is affected by JEP-200, there you have full stacktrace: Apr 04, 2018 9:06:13 AM WARNING jenkins.security.ClassFilterImpl lambda$isBlacklisted$1 com.google.api.services.compute.model.Operation in file:/var/jenkins_home/plugins/google-compute-engine/WEB-INF/lib/google-api-services-compute-v1-rev165-1.22.0.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/ Apr 04, 2018 9:06:13 AM WARNING org.eclipse.jetty.server.handler.ContextHandler$Context log Error while serving http://my-site.local/cloud/gce-Test-GCP/provision java.lang.UnsupportedOperationException: Refusing to marshal com.google.api.services.compute.model.Operation for security reasons; see
