[JIRA] (JENKINS-52926) "Git Build Data" should not appear more than once in the side menu for pipeline builds
Title: Message Title trejkaz commented on JENKINS-52926 Re: "Git Build Data" should not appear more than once in the side menu for pipeline builds Ah, there are even more problems with stash, so it's definitely unusable in its current state. For instance, if you stash from an Ubuntu slave and then unstash from a macOS slave, you wind up with the build in a weird state where some of the up-to-date checks don't work, because Gradle is storing absolute paths. It sounds like this has been separately reported to Gradle as well, but they didn't seem to understand the problem. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52926) "Git Build Data" should not appear more than once in the side menu for pipeline builds
Title: Message Title trejkaz commented on JENKINS-52926 Re: "Git Build Data" should not appear more than once in the side menu for pipeline builds On top of that, is stashing the entire repository really going to be performant enough to use during a build? We're not working with a toy project here... there are literally gigabytes of stuff in there. Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52926) "Git Build Data" should not appear more than once in the side menu for pipeline builds
Title: Message Title trejkaz commented on JENKINS-52926 Re: "Git Build Data" should not appear more than once in the side menu for pipeline builds Even if we only ran the merge on one agent, the fact of the matter is that the git info page will still give us no useful information about what it actually built against, since it will still be showing a hash which doesn't correspond to any actual commit in the repository. You claim that the SHA-1 hash is the most natural choice, but it isn't even a hash. You can't reproduce the same value even if you have the same content, so every time you run the same build, you get a new random value for it. Clearly the set of actual hashes which went into the merge is a much more suitable choice, both as an identifier, and to record the information about what actually got built. Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52926) "Git Build Data" should not appear more than once in the side menu for pipeline builds
Title: Message Title Mark Waite commented on JENKINS-52926 Re: "Git Build Data" should not appear more than once in the side menu for pipeline builds Thanks for the further explanation. You might perform the merge once, stash the result, then unstash it on each of the other platforms, rather than performing the merge on every platform. As another alternative, you might perform the checkout once on every platform, perform the merge on one, generate a patch of the merge result, stash the patch, and unstash the patch on each of the targets. You said: using the hash is not a good idea for deduplicating what code is being built The SHA-1 hash is the most natural choice to decide if something has changed. Performing the same merge on multiple agents is not a use case that the plugin is ready to handle. Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52926) "Git Build Data" should not appear more than once in the side menu for pipeline builds
Title: Message Title trejkaz commented on JENKINS-52926 Re: "Git Build Data" should not appear more than once in the side menu for pipeline builds The job is a pipeline job. Multiple checkouts do get performed, but I think that's a necessity? Otherwise, I don't understand how code would get from the node coordinating the build to each of the individual nodes doing the build. The hash built is different every time a separate node is spun off, because the merge gets performed again and git hashes are essentially random numbers, rather than actual hashes of the content. The multiple hashes reflect the random number each merge generated when the build for that node was performed. When I'm essentially saying is that using the hash is not a good idea for deduplicating what code is being built, because when a merge has occurred, the number is not usable in any way. If you replaced that information with enough information to actually reproduce the build, and then deduplicated on that, I think all the items would deduplicate properly. Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52926) "Git Build Data" should not appear more than once in the side menu for pipeline builds
Title: Message Title Mark Waite edited a comment on JENKINS-52926 Re: "Git Build Data" should not appear more than once in the side menu for pipeline builds Can you provide detailed steps to duplicate the problem? The sample you've provided almost looks like multiple checkout operations are being performed (and I doubt that is what you're actually doing in your build). Are the SHA-1 hashes in the git build data from the preceding builds? Since you indicate that the list continues to grow, it seems likely that they are somehow recording the history of the SHA-1's built by that job.Is the job a Pipeline job or a Freestyle job?If it is a Pipeline job, is it using a Pipeline shared library? Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52926) "Git Build Data" should not appear more than once in the side menu for pipeline builds
Title: Message Title Mark Waite commented on JENKINS-52926 Re: "Git Build Data" should not appear more than once in the side menu for pipeline builds Can you provide detailed steps to duplicate the problem? The sample you've provided almost looks like multiple checkout operations are being performed (and I doubt that is what you're actually doing in your build). Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52926) "Git Build Data" should not appear more than once in the side menu for pipeline builds
Title: Message Title Mark Waite assigned an issue to Unassigned Jenkins / JENKINS-52926 "Git Build Data" should not appear more than once in the side menu for pipeline builds Change By: Mark Waite Assignee: Mark Waite Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52926) "Git Build Data" should not appear more than once in the side menu for pipeline builds
Title: Message Title trejkaz created an issue Jenkins / JENKINS-52926 "Git Build Data" should not appear more than once in the side menu for pipeline builds Issue Type: Improvement Assignee: Mark Waite Attachments: Screen Shot 2018-08-08 at 9.34.41 am.png, Screen Shot 2018-08-08 at 9.34.50 am.png, Screen Shot 2018-08-08 at 9.34.58 am.png Components: git-plugin Created: 2018-08-08 00:41 Priority: Minor Reporter: trejkaz Currently, for pipeline builds, every time the pipeline runs on a new node and merges the branch you're building with master, you get an extra "Git Build Data" entry in the sidebar, even though you're building exactly the same thing. The individual screens show different revisions being built:But actually, these are the same PR branch, merged with the same master branch. In this situation, I would expect a single entry, and I would expect the linked page to list the branches which were merged, not to show the commit hash of the merge result. The merge result is literally impossible to access after the build has completed anyway, so there is no point having this information at all.
