[JIRA] (JENKINS-53322) Remove patched dom4j from Stapler
Title: Message Title Daniel Beck closed an issue as Fixed Jenkins / JENKINS-53322 Remove patched dom4j from Stapler Change By: Daniel Beck Status: Open Closed Resolution: Fixed Released As: jenkins-2.194 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.193404.153555107.4257.1569336001284%40Atlassian.JIRA.
[JIRA] (JENKINS-53322) Remove patched dom4j from Stapler
Title: Message Title Jeff Thompson commented on JENKINS-53322 Re: Remove patched dom4j from Stapler Stapler version 1.258 was released on 19 August 2019 containing changes to move to the standard dom4j library. Jenkins PR https://github.com/jenkinsci/jenkins/pull/4130 depends upon that version and removes dependency on the forked library. This PR is up for review. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.193404.153555107.6357.1566325440161%40Atlassian.JIRA.
[JIRA] (JENKINS-53322) Remove patched dom4j from Stapler
Title: Message Title Jeff Thompson commented on JENKINS-53322 Re: Remove patched dom4j from Stapler PR in Stapler to change to standard dom4j: https://github.com/stapler/stapler/pull/164 Enablement PR in Jenkins to old or new to work fine: https://github.com/jenkinsci/jenkins/pull/4089 ec2-plugin PR to enable old or new to work fine: https://github.com/jenkinsci/ec2-plugin/pull/372 (Already merged) Additional PRs to come later to include the new versions. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.193404.153555107.11040.1561669800262%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53322) Remove patched dom4j from Stapler
Title: Message Title Jeff Thompson commented on JENKINS-53322 Re: Remove patched dom4j from Stapler I've been working on this one for a while, compiling different libraries and plugins and running tests and checks. The specific tasks or conclusions I've found are a little different from those originally reported, but the overview remains the same. The forked dom4j version we use is ancient and really isn't necessary. We can get rid of it with a relatively few, independent tweaks. That will get us on a better footing. I'll start pushing a few PRs to various components to prepare them. Once we actually make the switch there are a few other places we can clean up. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.193404.153555107.8946.1561500360184%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53322) Remove patched dom4j from Stapler
Title: Message Title Jeff Thompson assigned an issue to Jeff Thompson Jenkins / JENKINS-53322 Remove patched dom4j from Stapler Change By: Jeff Thompson Assignee: Jeff Thompson Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.193404.153555107.7740.1561413660261%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53322) Remove patched dom4j from Stapler
Title: Message Title Daniel Beck commented on JENKINS-53322 Re: Remove patched dom4j from Stapler is there some epic or label for issues proposing to switch from forked to official versions of libraries in Jenkins? No such previous effort I'm aware of. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53322) Remove patched dom4j from Stapler
Title: Message Title Jesse Glick created an issue Jenkins / JENKINS-53322 Remove patched dom4j from Stapler Issue Type: Task Assignee: Unassigned Components: core Created: 2018-08-29 13:57 Labels: stapler dom4j Priority: Major Reporter: Jesse Glick stapler-jelly currently depends on a patched version¹ of dom4j, the original of which was released thirteen years ago. Current releases support Java 8, etc. A simple diff --git a/jelly/pom.xml b/jelly/pom.xml index 8aa4ec8d7..725f2ba56 100644 --- a/jelly/pom.xml +++ b/jelly/pom.xml @@ -32,9 +32,9 @@ commons-collections - org.jenkins-ci.dom4j + org.dom4j dom4j - 1.6.1-jenkins-4 + 2.1.1 org.jvnet.maven-jellydoc-plugin does not work because of an API added to HtmlWriter used by Stapler's HTMLWriterOutput. To be done: Write a unit test for HTMLWriterOutput demonstrating whatever it is supposed to do. Replace the missing setEnabled call. Perhaps just use Proxy to make a ContentHandler that dynamically switches between XMLWriter and HTMLWriter. That obviates the need for this patch. Close this PR accordingly. File an upstream PR for the static keyword addition from that patch.
