[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Paul Allen updated JENKINS-54222 Released in 1.9.3 Jenkins / JENKINS-54222 p4-plugin keeps opening connection during the build. Causing long delays Change By: Paul Allen Status: Fixed but Unreleased Closed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Paul Allen commented on JENKINS-54222 Re: p4-plugin keeps opening connection during the build. Causing long delays Thank you for trying this out, I'm pleased it resolved your issue. I have marked this 'ready for release' and it should be officially available in the next few days. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Paul Allen updated JENKINS-54222 Ready for release. Jenkins / JENKINS-54222 p4-plugin keeps opening connection during the build. Causing long delays Change By: Paul Allen Status: In Progress Fixed but Unreleased Assignee: Paul Allen Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Paul Allen updated an issue Jenkins / JENKINS-54222 p4-plugin keeps opening connection during the build. Causing long delays Change By: Paul Allen Labels: P4_A p4-plugin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Paul Allen started work on JENKINS-54222 Change By: Paul Allen Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Erez Arbell commented on JENKINS-54222 Re: p4-plugin keeps opening connection during the build. Causing long delays Awesome! It fixed the issue. Now the stage takes the same time as without using p4, and the redundant open connections stopped. My pipeline is much faster now. Also, the duration of the "p4 sync" itself reduced to 60% than it was before. Thank you. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Paul Allen commented on JENKINS-54222 Re: p4-plugin keeps opening connection during the build. Causing long delays It looks like buildEnvironment(Run run, Map env) is getting called many times by Jenkins. Normally this would not be a problem, however there is an environment variable P4_TICKET which was cached in the XML config, but now looked up on demand. I have cached this in a transient variable which will reduce the number of calls to P4D. https://ci.jenkins.io/job/Plugins/job/p4-plugin/job/master/287/ (assuming the build passes) Jenkins > Manage Jenkins > Manage Plugins > Advanced tab > Upload Plugin > Select HPI file > Upload > Restart Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Erez Arbell commented on JENKINS-54222 Re: p4-plugin keeps opening connection during the build. Causing long delays So you do not see that the p4 connections keep opening and closing without stop? I tried to do "p4 login" manually and I see that it always take little more than a second. So maybe my Perforce server is slower than the one you have, and this is why the effect on me is bigger? Can you suggest how can I investigate the issue, or how to tell the p4 plugin to stop to connect to the p4 server once it finished its task? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Paul Allen commented on JENKINS-54222 Re: p4-plugin keeps opening connection during the build. Causing long delays Yes I did try you example; I do see additional commands after the sync. Some of these will be related to change reporting and saving the build state, there did seem to be a few more than I was expecting and that may need investigating. However, the overhead was at most a second not the 53 seconds you reported. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Erez Arbell commented on JENKINS-54222 Re: p4-plugin keeps opening connection during the build. Causing long delays Thank you Paul. What about the original issue. Did you try to reproduce it using the steps I provided? Do you see the issue and the large time difference in the remaining of the build run, after the p4 stage has finished? If it is not a bug, can you suggest how to overcome the issue? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Paul Allen commented on JENKINS-54222 Re: p4-plugin keeps opening connection during the build. Causing long delays The extra logging is a code change; I have checked it in and you can access the latest build and 'p4.hpi' file on Jenkins CI server: https://ci.jenkins.io/job/Plugins/job/p4-plugin/job/master It will go out in the next release, or you can download the hpi file and install the plugin manually. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title
Erez Arbell commented on JENKINS-54222
Re: p4-plugin keeps opening connection during the build. Causing long delays
Thank you Paul Allen for the quick reply. I tried "autoClean", "forceClean" and "syncOnly". The behavior is he same. How can I use the new logging feature you added? The issue here is that the p4-pluging continue to do a loop of open and close p4 connections long after it finished its task. Can you please explain the need for this? I fail to see the need for it. If there will be need to do another use of p4, then it can open the connection then. I have jobs with duration of hours and days, and I keep see this slowness. You can see it yourself, in the pipeline code in steps to reproduce above, add long sleep between the p4 command and the "stage('run')". You will see that the plugin keep connecting to the p4 server and add long time to the build duration. This is not some overhead but a big issue. I apologize. I am not familiar with the internals of Jenkins so I do not understand the last paragraph you wrote. Anyway, as you can see be the simple steps to reproduce above, when using the p4-plugin, it makes the whole run of the build to be much slower. I am talking about a constant delay of 1-10 seconds between each two command in the Jenkinsfile. We had this slowness for long time but did not know why. Now that we discovered the reason we discussed it today in the team and due to this we consider moving to git.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title Paul Allen commented on JENKINS-54222 Re: p4-plugin keeps opening connection during the build. Causing long delays The 'p4-plugin' runs extra commands 'p4 reconcile', 'p4 revert', etc... to cleanup and prep the workspace. This was designed to help larger code bases, but does add an overhead. Which mode are you using with 'p4sync' - 'autoClean', 'forceClean', etc... I have added some additional logging to P4Logging.java, so I can see each command and its compute time. It probably makes sense to add this to aid with debugging. Unfortunately I can't share the P4 connection across Jenkins as it spawns multiple threads. In addition the plugin requires connections for the master and slave nodes. There are a few extra 'p4 info' and 'p4 login -s' commands that are used to test long running commands; they could be optimised, but with great care. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54222) p4-plugin keeps opening connection during the build. Causing long delays
Title: Message Title
Erez Arbell created an issue
Jenkins / JENKINS-54222
p4-plugin keeps opening connection during the build. Causing long delays
Issue Type:
Bug
Assignee:
Unassigned
Components:
p4-plugin
Created:
2018-10-24 12:30
Environment:
Pipeline scripted p4 plugin v 1.9.2 (latest) Both on Jenkins 2.107.3 and 2.138.2. Also on clean installed Jenkins server
Labels:
p4-plugin
Priority:
Critical
Reporter:
Erez Arbell
After using the p4 plugin, and after it finished its task, the p4 plugin keeps opening connection and closing it. Each such action takes 1-2 seconds. So during the rest of the build, there is a delay of 5-20 seconds between the commands. How to reproduce:
Go to /log/ and add a new logger called "p4" Logger = "org.jenkinsci.plugins.p4" ; Log level = "ALL"
Create a pipeline job with this script:
node() {
// library retriever: legacySCM(perforce( // fill your data here.
// p4sync // fill your data here.
stage('run') {
3.times {
sh 'date'
}
}
}
