[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Oliver Gondža updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Oliver Gondža Labels: evergreen-triggered fosdem2019 lts-candidate newbie-friendly Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Oleg Nenashev Labels: evergreen-triggered fosdem2019 lts-candidate newbie-friendly Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Oleg Nenashev updated JENKINS-55738 The fix has been released in Jenkins 2.164. Thanks Nisarg Shah! Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Oleg Nenashev Status: In Review Resolved Resolution: Fixed Released As: Jenkins 2.164 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Baptiste Mathus updated JENKINS-55738 Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Baptiste Mathus Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Baptiste Mathus I am attaching the screenshot of message after the fix. And I think the issue is solved as per acceptance criteria. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Attachment: Capture5 - Copy.JPG Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Comment: [~batmat]I am attaching screenshot of message after the fix.First photo is when there was an out of disk event detected.Second photo is when master node came online as the disk gets some empty space.And I think this fulfills the acceptance criteria. !image-2019-02-09-00-30-55-101.png|width=735,height=370! !Capture4 - Copy.JPG|width=598,height=263! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Baptiste Mathus I am attaching screenshot of message after the fix. First photo is when there was an out of disk event detected. Second photo is when master node came online as the disk gets some empty space. And I think this fulfills the acceptance criteria. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Attachment: image-2019-02-09-00-30-55-101.png Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Attachment: Capture4 - Copy.JPG Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Attachment: Capture2 - Copy.JPG Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Baptiste Mathus I am attaching the screenshot of the message before the fix : I have marked the issue with red marker. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Attachment: Capture3 - Copy.JPG Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Attachment: Capture3.JPG Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Baptiste Mathus commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Nisarg Shah the goal here is to fix the message explained in the description. See the acceptance criteria above. You need to see how Jenkins reacts when you remove the big files and have enough disk space again. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title
Baptiste Mathus updated an issue
Jenkins / JENKINS-55738
NodeMonitor out of disk space message is wrong for master
Change By:
Baptiste Mathus
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.The message has a blank where the node name should be:{{Putting back online as there is enough disk space again}}I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.h3. Acceptance criteria* This should show {{master}} instead of a space as the node name , i.e.{{Putting back *master* online as there is enough disk space}}
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Baptiste Mathus I have tested he fix and attaching screenshot of the output of Jenkins Window and CLI. And I think this fix has resolved the issue of displaying null message. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Attachment: Capture2.JPG Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Attachment: Capture1.JPG Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Comment: [~batmat]I have tested the fix and I am attaching the screenshot of the result obtained.!Capture1.JPG|thumbnail! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Baptiste Mathus I have tested the fix and I am attaching the screenshot of the result obtained. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Comment: I have tested this fix and I am attaching the screenshot of the result obtained. !Capture1.JPG! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master I have tested this fix and I am attaching the screenshot of the result obtained. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Attachment: Capture1.JPG Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Baptiste Mathus started work on JENKINS-55738 Change By: Baptiste Mathus Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Baptiste Mathus commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Answered in the open GitHub Pull Request. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Baptiste Mathus Can you suggest me the command(applied on Jenkins Folder) of test through which I can check this fix? I have checked some flow of the code and want to check whether this fix would actually work or not. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah edited a comment on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master [~batmat] [~jglick]Due to some issues I have deleted my previous repo and due to that my old PR got deleted.Here is my new PR : [ https://github.com/jenkinsci/jenkins/pull/3874 ] Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Baptiste Mathus Jesse Glick Due to some issues I have deleted my previous repo and due to that my old PR got deleted. Here is my new PR : https://github.com/jenkinsci/jenkins/pull/3874 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Baptiste Mathus Okay, great I had a thought of copying and pasting big files and manually create an out of disk event. But actually after this I have a doubt that how to run jenkins code on local and test that fixed part? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title
Baptiste Mathus edited a comment on JENKINS-55738
Re: NodeMonitor out of disk space message is wrong for master
[~nisarg14] are you on Windows or Linux?On Linux, the usual way for this is simply to use {{fallocate}} or {{dd}}, see https://stackoverflow.com/a/5688625/345845.On Windows, the simplest low-tech way I did that in the past is the following:* find a big enough file, or very big if you have a lot of free disk space* copy paste it as many times as needed, even using the UI and Ctrl-C Ctrl-V should be quick enough** i.e. if you have 10 GB of free disk space, find a big file, like 1GB, and copy-paste it like nine of or ten timesOr maybe try https://blogs.msdn.microsoft.com/oldnewthing/20150710-00/?p=45171 but didn't try it myself.HTH
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Baptiste Mathus commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Nisarg Shah are you on Windows or Linux? On Linux, the usual way for this is simply to use fallocate or dd, see https://stackoverflow.com/a/5688625/345845. On Windows, the simplest low-tech way I did that in the past is the following: find a big enough file, or very big if you have a lot of free disk space copy paste it as many times as needed, even using the UI and Ctrl-C Ctrl-V should be quick enough i.e. if you have 10 GB of free disk space, find a big file, like 1GB, and copy-paste it nine of ten times Or maybe try https://blogs.msdn.microsoft.com/oldnewthing/20150710-00/?p=45171 but didn't try it myself. HTH Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master The tests which got failed while checking got passed now, but now I am only facing some problem to verify the fix by manually creating an out of disk space event. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Okay. So I think I should check from where .getDisplayName() is assigned to the particular message. From that we can be sure whether this particular change will work or not. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Jesse Glick commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master here the behaviour of changed code is not okay Why do you say that? Error is of Remote call on jenkinsinfra-highmem8ca11 failed Likely a problem in CI infrastructure, not the code being tested. Are there any specific tests needed for this through which I can get to know that whether it works or not? As previously mentioned, I am not aware of any. The issue relates solely to the user interface and test coverage of the UI is low. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master I just need to verify the changes done by doing tests as I had a look on code once again and thought that the changes done in the pr looks fine just needed to get verify. Are there any specific tests needed for this through which I can get to know that whether it works or not? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah edited a comment on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master In my pull request yesterday testing was being done and it passed all the tests. And a green tick was given that all tests cases passed and this commit can be build. But today tests were running once again and one error occurred which is different from the errors occurred in earlier test. Error is of Remote call on jenkinsinfra-highmem8ca11 failed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master In my pull request yesterday testing was being done and it passed all the tests. And a green tick was given that all tests cases passed and this commit can be build. But today tests were running once again and one error occurred which is different from the errors occurred in earlier test. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master What about passing a string message directly into Logger.info(). I think by this change no behaviour of code will get changed and problem can also be solved? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Okay Thanks... I think here the behaviour of changed code is not okay and the tests failed are unrelated to my code. So now how should I approach to solve this? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Jesse Glick commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master mvn -DskipTests clean install && mvn -f test surefire:test -Dtest=WhateverTest\#method if there is a specific test you are interested in, though you can also just use CI (failures look unrelated to your code). In this case I doubt there is any relevant automated test coverage—the issue would need to be verified manually by actually simulating an out of disk space event. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Can anyone tell me how can I run tests on my local computer? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master https://github.com/jenkinsci/jenkins/pull/3863 In these pull request 4 existing tests got failed. Can you please help me in figuring out what happened? As no code of that modules were changed. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah updated an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Comment: Okay and Can I get just one help that how can I test my change in code. Like how would i run that code and check whether that issue has solved or not? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Okay and Can I get just one help that how can I test my change in code. Like how would i run that code and check whether that issue has solved or not? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Jesse Glick commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Maybe you should try it and find out. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Yes issue is of MasterComputer. But if we replace c.getName() with c.getDisplayName() than would it fix this issue? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Jesse Glick commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master The reported issue is about MasterComputer, which overrides getDisplayName as previously noted. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Yes it may be. But i looked each and every line where c.getName() is called and i think that it would create issue editing that method. So either we have to call another Display method or we should pass directly the string as it is. And in c.getDisplayName() it gets override by returning nodeName which exactly c.getName() does. So I am not sure but it may probably not work. There are two functions of getDisplayName in which one gets override by returning nodeName. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Jesse Glick commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master I suspect replacing the two occurrences of c.getName() in the abovementioned code section with c.getDisplayName() would fix this. Most of the work would be figuring out how to verify the fix. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master If we pass "Putting back online as there is enough disk space again" in Logger.info() then would it be a better behaviour and would it work? As if we change getName() method of Computer class than it would create a problem as this method is used in many places. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Okay. Thanks I will go through some necessary part of the code and will post comments here if required. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Jesse Glick commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master https://gitter.im/jenkinsci/jenkins is always available for live chat, though I generally feel that if you have a specific question about a specific JIRA issue, commenting in that issue is best unless you think it is a broader topic that many people might want to participate in. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master I want to ask few doubts. So which gitter room should I join to discuss? Or should I ask and discuss here? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Jesse Glick commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master I think it would suffice to use Computer.getDisplayName, which is overridden for MasterComputer. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Sure. Thank you!! Actually I am new to open source and also very much excited to contribute. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Sure. Thank you!! Actually I am new to open source and also very much excited to contribute. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah assigned an issue to Nisarg Shah Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Change By: Nisarg Shah Assignee: Nisarg Shah Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Baptiste Mathus commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master Nisarg Shah absolutely, please do. Thanks! If you need help, please reach out to us either on IRC, on on the developers mailing list. Thanks again! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Nisarg Shah commented on JENKINS-55738 Re: NodeMonitor out of disk space message is wrong for master I would like to work on this issue. So can I assign this to me? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title
Baptiste Mathus updated an issue
Jenkins / JENKINS-55738
NodeMonitor out of disk space message is wrong for master
Change By:
Baptiste Mathus
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.The message has a blank where the node name should be:{{Putting back online as there is enough disk space again}}I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.h3. Acceptance criteria* This should show {{master}} instead of a space as the node name
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title
Baptiste Mathus updated an issue
Jenkins / JENKINS-55738
NodeMonitor out of disk space message is wrong for master
Change By:
Baptiste Mathus
When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.The message has a blank where the node name should be:{{Putting back online as there is enough disk space again}}I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.h3. Acceptance criteria* This should show {{master}} instead of a space as the node name
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55738) NodeMonitor out of disk space message is wrong for master
Title: Message Title Baptiste Mathus created an issue Jenkins / JENKINS-55738 NodeMonitor out of disk space message is wrong for master Issue Type: Bug Assignee: Unassigned Components: core Created: 2019-01-23 08:33 Labels: evergreen-triggered newbie-friendly fosdem2019 Priority: Trivial Reporter: Baptiste Mathus When the master goes out of disk space, it is put offline by the hudson.node_monitors.AbstractDiskSpaceMonitor system. The message has a blank where the node name should be: Putting back online as there is enough disk space again I think this is just because c.getName() returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71. Acceptance criteria This should show master instead of a space as the node name
