[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-04-11 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-56688  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
 Map.getOrDefault(Object, Object) is now whitelisted by default in Script Security 1.57.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-04-11 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56688  
 
 
  pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Released As: 
 workflow-cps 2.66 , script-security 1.57  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-04-11 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-56688  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 The updated documentation was just released in version 2.66 of Pipeline: Groovy Plugin. I will try to release Script Security shortly to get the update that adds the new recommendation to the default whitelist.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-56688  
 
 
  pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Fixed but Unreleased Resolved  
 
 
Released As: 
 workflow-cps 2.66  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-03-26 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-56688  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56688  
 
 
  pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In Review Fixed but Unreleased  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-03-22 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick assigned an issue to Daniel Carrington  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56688  
 
 
  pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Assignee: 
 Jesse Glick Daniel Carrington  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-03-22 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick updated  JENKINS-56688  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56688  
 
 
  pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-03-22 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56688  
 
 
  pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Labels: 
 documentation  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-03-22 Thread daniel.carring...@hpe.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Daniel Carrington started work on  JENKINS-56688  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Daniel Carrington  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-03-22 Thread daniel.carring...@hpe.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Daniel Carrington commented on  JENKINS-56688  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
 https://github.com/jenkinsci/workflow-cps-plugin/pull/275 Minor documentation update fixing the words in the help.jelly to recommend Map.getOrDefault instead.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-03-22 Thread daniel.carring...@hpe.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Daniel Carrington updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56688  
 
 
  pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
Change By: 
 Daniel Carrington  
 
 
Component/s: 
 workflow-cps-plugin  
 
 
Component/s: 
 workflow-job-plugin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56688) pipeline-syntax Global Variables params.get doesn't work

2019-03-22 Thread daniel.carring...@hpe.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Daniel Carrington created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56688  
 
 
  pipeline-syntax Global Variables params.get doesn't work   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Jesse Glick  
 
 
Components: 
 workflow-job-plugin  
 
 
Created: 
 2019-03-22 17:36  
 
 
Environment: 
 jenkins 1.50.2, all workflow plugin versions  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Daniel Carrington  
 

  
 
 
 
 

 
 In Pipeline, doing params.get as recommended by Jesse Glick in: https://github.com/jenkinsci/workflow-cps-plugin/commit/7c29a4d24f575e61d80a7aed7b48d6ba5750a5a6 doesn't work because Groovy Map.get(Object, Object) actually tries to modify the map; whereas the params Map is an UnmodifiableMap. When I tried this code, I got the exception: 

 
java.lang.UnsupportedOperationException at
 java.util.Collections$UnmodifiableMap.put(Collections.java:1457) at
 org.codehaus.groovy.runtime.DefaultGroovyMethods.get(DefaultGroovyMethods.java:7080) 

 I recommend instead Map.getOrDefault, which does not try to modify the Map. Pull request incoming for an update to documentation.