[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title
Nils Engelbrecht updated an issue
Jenkins / JENKINS-56792
Create additional constructor in Issue (TreeString)
Change By:
Nils Engelbrecht
- Issue has a constructor with {{String}} values for fileName, packageName, message, description. Another constructor is required (same number of parameters) that uses a {{TreeString}} for these arguments. - - In a second step, {{IssueBuilder}} should be refined to store the members fileName, packageName, message, description in a {{TreeString}} as well. -Issue has a constructor with {{String}} values for fileName, packageName, message, description. The constructor has to be changed to required (same number of parameters) that uses a {{TreeString}} for these arguments.All normalization and transformation logic that is currently part of the constructor of {{Issue}} should be moved to {{IssueBuilder#build}}. The {{Issue}} constructor then needs to be changed as described above.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Nils Engelbrecht edited a comment on JENKINS-56792 Re: Create additional constructor in Issue (TreeString) Ok thank you - I’ll do that.My bad! You’re right: the fileName was already of type TreeString before. - I guess the test fails because I changed the type of the parameter of the setter for fileName and removed the logic of normalization. - - Might that be the reason? -I actually don't know why, but this specific serialization test mentioned above now passes.But now ReportTest#shouldReadIssueFromOldSerialization fails... Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Nils Engelbrecht commented on JENKINS-56792 Re: Create additional constructor in Issue (TreeString) Ok thank you - I’ll do that. My bad! You’re right: the fileName was already of type TreeString before. I guess the test fails because I changed the type of the parameter of the setter for fileName and removed the logic of normalization. Might that be the reason? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Ulli Hafner commented on JENKINS-56792 Re: Create additional constructor in Issue (TreeString) Am I allowed to delete test cases such as IssueTest#testFileNameBackslashConversion (therefore of course I would create a new one in the IssueBuilderTest class) ? Yes, just move the tests to the IssueBuilder class. Another question I got is how to cope with failure of the test case IssueTest#shouldReadIssueFromOldSerialization ? I assume this is due to the type-change of fileName from String to TreeString. Hmm, does the serialization change? The type changed only in the constructor, but the field still is TreeString. Or do I miss something? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Nils Engelbrecht commented on JENKINS-56792 Re: Create additional constructor in Issue (TreeString) I understand. Sounds good to me! After reworking this for the fileName parameter about 8 test cases are failing. Am I allowed to delete test cases such as IssueTest#testFileNameBackslashConversion (therefore of course I would create a new one in the IssueBuilderTest class) ? Another question I got is how to cope with failure of the test case IssueTest#shouldReadIssueFromOldSerialization ? I assume this is due to the type-change of fileName from String to TreeString. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Ulli Hafner commented on JENKINS-56792 Re: Create additional constructor in Issue (TreeString) Good catch! Actually the normalization needs to be done outside of Issue. Otherwise the caching effect of TreeString would not pay off. A TreeString actually is a kind of String cache that tries to minimize memory consumption. In order to build up that cache the TreeStringBuilder instance must be created once and reused for all issues (i.e. it is a kind of static field). This is currently broken as the builder is created for each instance. My idea about this issue was to provide the first part of the required refactoring. But after thinking again I think it makes more sense to rework that part completely. If it is not too complex for you we can rephrase this issue in the following way: all normalization and transformation logic that is currently part of the constructor of Issue should be moved to IssueBuilder#build. The Issue constructor then needs to be changed as described above. That means no new constructor. Then an IssueBuilder holds a TreeStringBuilder for each of the 4 fields and performs the whole transformation logic (and the rest of the String normalization). So the Issue constructor basically does nothing, just assigns the fields. Note that null should be not allowed anymore for these parameters, this should be ensured by the IssueBuilder. Does this sound reasonable? If the work around that gets to complex we can also drop the second issue... Changing IssueBuilder and Issue in such a way will break several test cases, but I think it should be easy to spot what to do in those tests. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Nils Engelbrecht edited a comment on JENKINS-56792 Re: Create additional constructor in Issue (TreeString) Do the values of those parameters (now being TreeStrings) have to be 'normalized' within the Issue class as well . ? If so, I would either have to implement the normalizeFeature within the TreeString.class or have to retrieve the String of e.g the fileName, normalize it and then create a new TreeString via TreeStringBuilder.Or shall should the normalization happen before being passed to the Issue-Constructor ( within the IssueBuilder ) ?Example for 'normalization':Issue.java(l. 305): this.fileName = builder.intern(normalizeFileName(fileName)); Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Nils Engelbrecht commented on JENKINS-56792 Re: Create additional constructor in Issue (TreeString) Do the values of those parameters (now being TreeStrings) have to be 'normalized' within the Issue class as well. If so, I would either have to implement the normalizeFeature within the TreeString.class or have to retrieve the String of e.g the fileName, normalize it and then create a new TreeString via TreeStringBuilder. Or shall the normalization happen before within the IssueBuilder? Example for 'normalization': Issue.java(l. 305): this.fileName = builder.intern(normalizeFileName(fileName)); Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Nils Engelbrecht started work on JENKINS-56792 Change By: Nils Engelbrecht Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Nils Engelbrecht assigned an issue to Nils Engelbrecht Jenkins / JENKINS-56792 Create additional constructor in Issue (TreeString) Change By: Nils Engelbrecht Assignee: Nils Engelbrecht Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title
Ulli Hafner updated an issue
Jenkins / JENKINS-56792
Create additional constructor in Issue (TreeString)
Change By:
Ulli Hafner
Priority:
Minor Major
Issue has a constructor with {{String}} values for fileName, packageName, message, description. Another constructor is required (same number of parameters) that uses a {{TreeString}} for these arguments. In a second step, {{IssueBuilder}} should be refined to store the members fileName, packageName, message, description in a {{TreeString}} as well.
Add Comment
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Ulli Hafner assigned an issue to Unassigned Jenkins / JENKINS-56792 Create additional constructor in Issue (TreeString) Change By: Ulli Hafner Assignee: Ulli Hafner Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56792) Create additional constructor in Issue (TreeString)
Title: Message Title Ulli Hafner created an issue Jenkins / JENKINS-56792 Create additional constructor in Issue (TreeString) Issue Type: Improvement Assignee: Ulli Hafner Components: analysis-model Created: 2019-03-28 10:24 Priority: Minor Reporter: Ulli Hafner Issue has a constructor with String values for fileName, packageName, message, description. Another constructor is required (same number of parameters) that uses a TreeString for these arguments. Add Comment This message was sent by
