[JIRA] (JENKINS-58571) It's possible to use renameTo for AbstractItem that has name NOT editable.
Title: Message Title Daniel Beck commented on JENKINS-58571 Re: It's possible to use renameTo for AbstractItem that has name NOT editable. Needs followup Javadoc fix as I commented in the PR. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200722.1563538638000.6286.1566318421263%40Atlassian.JIRA.
[JIRA] (JENKINS-58571) It's possible to use renameTo for AbstractItem that has name NOT editable.
Title: Message Title Daniel Beck resolved as Fixed Jenkins / JENKINS-58571 It's possible to use renameTo for AbstractItem that has name NOT editable. Change By: Daniel Beck Status: Open Resolved Resolution: Fixed Released As: 2.190 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200722.1563538638000.6284.1566318421235%40Atlassian.JIRA.
[JIRA] (JENKINS-58571) It's possible to use renameTo for AbstractItem that has name NOT editable.
Title: Message Title A. Jard updated an issue Jenkins / JENKINS-58571 It's possible to use renameTo for AbstractItem that has name NOT editable. Change By: A. Jard The “isNameEditable” value is not checked before doing the real rename action on the renameTo method: [ https://github.com/jenkinsci/jenkins/blob/38e94d197e65af66da67afdc5ebb5d8c0fcf3377/core/src/main/java/hudson/model/AbstractItem.java#L353 ] The rename method can lead to very bad issues if it’s used with item that must not be renamed, the “isNameEditable” must be check before doing any rename action.I am doing did a PR with a unit test and a code change, I will update this JIRA just after changes and unit tests: https://github . com/jenkinsci/jenkins/pull/4122 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200722.1563538638000.16388.1563539640066%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58571) It's possible to use renameTo for AbstractItem that has name NOT editable.
Title: Message Title A. Jard created an issue Jenkins / JENKINS-58571 It's possible to use renameTo for AbstractItem that has name NOT editable. Issue Type: Bug Assignee: Unassigned Components: core Created: 2019-07-19 12:17 Priority: Major Reporter: A. Jard The “isNameEditable” value is not checked before doing the real rename action on the renameTo method: https://github.com/jenkinsci/jenkins/blob/38e94d197e65af66da67afdc5ebb5d8c0fcf3377/core/src/main/java/hudson/model/AbstractItem.java#L353 The rename method can lead to very bad issues if it’s used with item that must not be renamed, the “isNameEditable” must be check before doing any rename action. I am doing a PR with a unit test and a code change, I will update this JIRA just after. Add Comment
