[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Chris Kilding closed an issue as Fixed Fixed on the branch. Jenkins / JENKINS-59302 Name fields of AWS Secrets Manager Secrets are not distinct Change By: Chris Kilding Status: Resolved Closed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201850.1568146774000.10598.1573137360228%40Atlassian.JIRA.
[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Chris Kilding updated JENKINS-59302 Jenkins / JENKINS-59302 Name fields of AWS Secrets Manager Secrets are not distinct Change By: Chris Kilding Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201850.1568146774000.10594.1573137300612%40Atlassian.JIRA.
[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Chris Kilding started work on JENKINS-59302 Change By: Chris Kilding Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201850.1568146774000.10592.1573137300524%40Atlassian.JIRA.
[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Chris Kilding updated JENKINS-59302 Jenkins / JENKINS-59302 Name fields of AWS Secrets Manager Secrets are not distinct Change By: Chris Kilding Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201850.1568146774000.10596.1573137300655%40Atlassian.JIRA.
[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Chris Kilding commented on JENKINS-59302 Re: Name fields of AWS Secrets Manager Secrets are not distinct I investigated a bit and found the following... As long as the `AwsCredentials` type implements `StringCredentials`, the ID is used for the name. But if it extends any of the other credentials types (`StandardUsernamePasswordCredentials` etc), even individually, the fallback text appears instead. I initially wondered if this could have been a bug in the credentials type definitions themselves so tried spawning some creds in the local disk-backed creds provider. But the names all worked properly, so the credentials type definitions are fine. One interesting thing is that when AWS credentials are shown in the list view, no matter what credentials interface I tell the `AwsCredentials` class to implement instead of `StringCredentials`, it is always presented as 'secret text' (with the blue key icon). So it seems that the `AwsCredentials` objects are always being treated as `StringCredentials`, even when they do not implement that type. And when they don't fit the `StringCredentials` form I guess the default descriptor message is used to fill in the blanks. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201850.1568146774000.1939.1568282880171%40Atlassian.JIRA.
[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Nat Talbot updated an issue Jenkins / JENKINS-59302 Name fields of AWS Secrets Manager Secrets are not distinct Change By: Nat Talbot Environment: Running off of the feature/multiple-credential-types branch , but this should be an overall issue not specific to the branch Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201850.1568146774000.1375.156880205%40Atlassian.JIRA.
[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Nat Talbot commented on JENKINS-59302 Re: Name fields of AWS Secrets Manager Secrets are not distinct Aha, looks like it was introduced by the changes, after re-installing from master. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201850.1568146774000.1373.1568221140254%40Atlassian.JIRA.
[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Nat Talbot commented on JENKINS-59302 Re: Name fields of AWS Secrets Manager Secrets are not distinct Was this introduced from the multiple-credential-types changes, or is it a separate issue? I had assumed it was a separate issue, but looking at the changes I'd guess it's related to the DescriptorImpl in AwsCredentials.java? Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201850.1568146774000.1371.1568220360177%40Atlassian.JIRA.
[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Chris Kilding commented on JENKINS-59302 Re: Name fields of AWS Secrets Manager Secrets are not distinct Ah yes, I think this bug was introduced by accident, since my team defines all its jobs through either JobDSL or Jenkinsfiles (and not through the Web UI - where we would have noticed and caught this bug). It definitely needs fixing. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201850.1568146774000.1197.1568194980196%40Atlassian.JIRA.
[JIRA] (JENKINS-59302) Name fields of AWS Secrets Manager Secrets are not distinct
Title: Message Title Nat Talbot updated an issue Jenkins / JENKINS-59302 Name fields of AWS Secrets Manager Secrets are not distinct Change By: Nat Talbot Summary: Description Name fields of AWS Secrets Manager Secrets are not distinct Currently, any AWS Secret in Jenkins has the description name "AWS Secrets Manager secret." This is not a major issue in the credentials browser or accessing in a pipeline script, as the credential ID is unique – however, in the "Configure System" page, many plugins use the descriptions names rather than the ID to choose these secrets from the dropdown (see images)The solution that I will experiment with is to source the credential description name from the description field attached to the secret in AWS, however, using the ID as the description instead would work well. !image-2019-09-10-15-54-15-902.png! !image-2019-09-10-15-54-24-054.png! Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
