[JIRA] (JENKINS-26148) Incorrect implementation of RetryStepExecution.stop
Title: Message Title Jesse Glick commented on JENKINS-26148 Re: Incorrect implementation of RetryStepExecution.stop Looks that way. Thanks for noticing! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26148) Incorrect implementation of RetryStepExecution.stop
Title: Message Title Sam Van Oort updated JENKINS-26148 Jesse Glick I think we got all the parts released here, right? Jenkins / JENKINS-26148 Incorrect implementation of RetryStepExecution.stop Change By: Sam Van Oort Status: In Review Closed Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26148) Incorrect implementation of RetryStepExecution.stop
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26148 Re: Incorrect implementation of RetryStepExecution.stop Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecution.java src/main/java/org/jenkinsci/plugins/workflow/cps/CpsStepContext.java src/test/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecutionTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/6933a4925a47b07206eaf059484b37c069aebe62 Log: [FIXED JENKINS-34637] CpsBodyExecution.cancel was failing to interrupt the innermost execution, and block-scoped StepExecution.stop does not generally kill its body (JENKINS-26148). getCurrentExecutions was also in direct violation of its Javadoc, though it does not appear to have ever been called, much less tested. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26148) Incorrect implementation of RetryStepExecution.stop
Title: Message Title SCM/JIRA link daemon commented on JENKINS-26148 Re: Incorrect implementation of RetryStepExecution.stop Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/cps/CpsStepContext.java http://jenkins-ci.org/commit/workflow-cps-plugin/38e8206153b3497fec5c6f9a2880779ea2bd3cc9 Log: JENKINS-26148 Be quiet in the case a block step is receiving a failure from its own body. Happens when stop() is implemented to call getContext().onFailure(cause), and something incorrectly calls stop on a non-innermost execution. Also providing much better diagnostics in other cases where a step seems to be completing twice. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26148) Incorrect implementation of RetryStepExecution.stop
Title: Message Title Jesse Glick commented on JENKINS-26148 Re: Incorrect implementation of RetryStepExecution.stop Similarly, there is no apparent reason for ParallelStepExecution.bodies to exist except to pass on failures in stop. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26148) Incorrect implementation of RetryStepExecution.stop
Title: Message Title Jesse Glick commented on JENKINS-26148 Re: Incorrect implementation of RetryStepExecution.stop Seems that the bogus overrides of stop are useful as a workaround for JENKINS-34637: CpsBodyExecution.getCurrentExecutions disobeys its contract (it returns just the first step running, not the innermost steps), and cancel suffers from the same problem. When that is fixed, I think it would be best for StepExecution.stop to have a default implementation—getContext().onFailure(cause)—and for most of the overrides to be deleted, leaving only those which actually do something before, after, or between body invocations. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-26148) Incorrect implementation of RetryStepExecution.stop
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-26148 Incorrect implementation of RetryStepExecution.stop Change By: Jesse Glick Component/s: workflow-basic-steps-plugin Component/s: pipeline Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
