[JIRA] (JENKINS-31931) archive step sets result to FAILURE but does not fail the job
Title: Message Title SCM/JIRA link daemon commented on JENKINS-31931 Re: archive step sets result to FAILURE but does not fail the job Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/ArtifactArchiverStepExecution.java src/main/java/org/jenkinsci/plugins/workflow/steps/CoreStep.java src/test/java/org/jenkinsci/plugins/workflow/steps/ArtifactArchiverStepTest.java src/test/java/org/jenkinsci/plugins/workflow/steps/CoreStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/05bf1fb6446d37ef8634555e1e1c8bb331cdf9ac Log: Merge pull request #17 from jglick/test-JENKINS-31931 JENKINS-31931 Adding test case Compare: https://github.com/jenkinsci/workflow-basic-steps-plugin/compare/86af7fdf73cd...05bf1fb6446d Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31931) archive step sets result to FAILURE but does not fail the job
Title: Message Title SCM/JIRA link daemon commented on JENKINS-31931 Re: archive step sets result to FAILURE but does not fail the job Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/ArtifactArchiverStepExecution.java src/main/java/org/jenkinsci/plugins/workflow/steps/CoreStep.java src/test/java/org/jenkinsci/plugins/workflow/steps/ArtifactArchiverStepTest.java src/test/java/org/jenkinsci/plugins/workflow/steps/CoreStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/be563c856a50995271be490911988be0996865c4 Log: Testing JENKINS-31931. Also fixing a buglet with nonexistent workspaces. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-31931) archive step sets result to FAILURE but does not fail the job
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-31931 archive step sets result to FAILURE but does not fail the job The now-deprecated archive step does not fail the build. ArtifactArchiver in core does fail the build unless you pass allowEmptyArchive: true. However its result != null && result.isBetterOrEqualTo(Result.UNSTABLE) condition ought to read result == null || result.isBetterOrEqualTo(Result.UNSTABLE) since for a Pipeline build normally the result is null until the end of the build. Also rather than calling build.setResult(Result.FAILURE), it should throw an AbortException. Similarly, the whole try-catch block could better be deleted. Change By: Jesse Glick Component/s: core Component/s: pipeline Labels: pipeline Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
