[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Dominic Hargreaves commented on JENKINS-36570 Re: Implement pipeline compatibility I was probably coming at this from the wrong direction. I can confirm that job groups/priority sorting works on a pipeline job as a whole and that is good enough for us at the moment. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Dominic Hargreaves commented on JENKINS-36570 Re: Implement pipeline compatibility Oleg Nenashev I had a look at https://wiki.jenkins-ci.org/display/JENKINS/Priority+Sorter+Plugin and the only mention of pipeline is a change entry mentioning this ticket. But I can't see anywhere how one would allocated a node in a given job group, which I assume is how this would need to work, any examples at all of it being used in a pipeline script. So given your reference to existing documentation I suspect there's something I'm just not finding from a google search? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title SCM/JIRA link daemon commented on JENKINS-36570 Re: Implement pipeline compatibility Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/pipeline-plugin/db5cf31926d7e009cf30ed14a8e7325d384067e9 Log: Merge pull request #428 from oleg-nenashev/PrioritySorter JENKINS-36570 - Add PrioritySorter to the Pipeline Compatibility list Compare: https://github.com/jenkinsci/pipeline-plugin/compare/74522f80f474...db5cf31926d7 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title SCM/JIRA link daemon commented on JENKINS-36570 Re: Implement pipeline compatibility Code changed in jenkins User: Oleg Nenashev Path: COMPATIBILITY.md http://jenkins-ci.org/commit/pipeline-plugin/615a0b9b0c3ade0157da4cd8118398b608a1e679 Log: JENKINS-36570 - Add PrioritySorter to the Pipeline Compatibility list Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Oleg Nenashev commented on JENKINS-36570 Re: Implement pipeline compatibility Dominic Hargreaves I've though the existing documentation is enough. What exactly you're interested in? The plugin itself or it's Pipeline integration features? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Dominic Hargreaves commented on JENKINS-36570 Re: Implement pipeline compatibility I see that this is now merged in, but could anyone say to what extent this is useful in practice, and how to use it, as it wasn't obvious from this issue and the PR Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title SCM/JIRA link daemon commented on JENKINS-36570 Re: Implement pipeline compatibility Code changed in jenkins User: Oleg Nenashev Path: src/main/java/jenkins/advancedqueue/PrioritySorterConfiguration.java src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionJobProperty.java src/main/java/jenkins/advancedqueue/priority/strategy/PriorityJobProperty.java http://jenkins-ci.org/commit/priority-sorter-plugin/f74d95fc13f4c17a4ab998846c4b087e6befc077 Log: Merge pull request #36 from oleg-nenashev/JENKINS-36570-AbstractProject-cleanup JENKINS-36570 - Cleanup references to AbstractProject in the core plugin classes Compare: https://github.com/jenkinsci/priority-sorter-plugin/compare/14df308bde82...f74d95fc13f4 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title SCM/JIRA link daemon commented on JENKINS-36570 Re: Implement pipeline compatibility Code changed in jenkins User: Oleg Nenashev Path: src/main/java/jenkins/advancedqueue/PrioritySorterConfiguration.java src/main/java/jenkins/advancedqueue/jobinclusion/strategy/JobInclusionJobProperty.java src/main/java/jenkins/advancedqueue/priority/strategy/PriorityJobProperty.java http://jenkins-ci.org/commit/priority-sorter-plugin/c9bfe6d16a2f34e1e184e448f1f8ac6329be531c Log: JENKINS-36570 - Cleanup references to AbstractProject in the core plugin classes Generally this change is not binary compatible, and likely it requires 4.0 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Oleg Nenashev assigned an issue to Oleg Nenashev Jenkins / JENKINS-36570 Implement pipeline compatibility Change By: Oleg Nenashev Assignee: Magnus Sandberg Oleg Nenashev Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Oleg Nenashev updated JENKINS-36570 Jenkins / JENKINS-36570 Implement pipeline compatibility Change By: Oleg Nenashev Status: In Review Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Oleg Nenashev commented on JENKINS-36570 Re: Implement pipeline compatibility https://github.com/jenkinsci/priority-sorter-plugin/pull/34 adds some bits of the Pipeline support, but it is not a final solution. Job property handling needs to be reworked and updated Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title SCM/JIRA link daemon commented on JENKINS-36570 Re: Implement pipeline compatibility Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/jenkins/advancedqueue/PriorityConfiguration.java src/main/java/jenkins/advancedqueue/PriorityConfigurationPlaceholderTaskHelper.java http://jenkins-ci.org/commit/priority-sorter-plugin/14df308bde82d46cd255ff777f9aaf4b3c13f06b Log: Merge pull request #34 from vitalii-vitrenko/master JENKINS-36570 Implement pipeline compatibility Compare: https://github.com/jenkinsci/priority-sorter-plugin/compare/5e5657d7d246...14df308bde82 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Oleg Nenashev updated JENKINS-36570 Jenkins / JENKINS-36570 Implement pipeline compatibility Change By: Oleg Nenashev Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Oleg Nenashev started work on JENKINS-36570 Change By: Oleg Nenashev Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-36570 Implement pipeline compatibility Change By: Oleg Nenashev Labels: pipeline Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title
Timothy Clarke edited a comment on JENKINS-36570
Re: Implement pipeline compatibility
A little digging through logs, and taking a "how to get it working with, even if not fully supported" approach. It looks like flyweight tasks are getting prioritised as per rules in http://jenkins_host:8080/jenkins/advanced-build-queue/Heavy weight tasks on the other hand (where prioritisation would be really useful) look to be hitting [PriorityConfiguration.java#L211 -L216 |https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/PriorityConfiguration.java#L211 -L216 ] and so getting assigned a default value. Can we ease {code}if (!(item.task instanceof Job)) {{code}That way we could atleast add filters to re-prioritise
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title
Timothy Clarke edited a comment on JENKINS-36570
Re: Implement pipeline compatibility
A little digging through logs, and taking a "how to get it working with, even if not fully supported" approach. It looks like flyweight tasks are getting prioritised as per rules in http://jenkins_host:8080/jenkins/advanced-build-queue/Heavy weight tasks on the other hand (where prioritisation would be really useful) look to be hitting [PriorityConfiguration.java#L211|https://github.com/jenkinsci/priority-sorter-plugin/blob/master/src/main/java/jenkins/advancedqueue/PriorityConfiguration.java#L211] and so getting assigned a default value. Can we ease {code}if (!(item.task instanceof Job)) {{code}That way we could atleast add filters to re- prioritize prioritise
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title
Timothy Clarke commented on JENKINS-36570
Re: Implement pipeline compatibility
A little digging through logs, and taking a "how to get it working with, even if not fully supported" approach. It looks like flyweight tasks are getting prioritised as per rules in http://jenkins_host:8080/jenkins/advanced-build-queue/ Heavy weight tasks on the other hand (where prioritisation would be really useful) look to be hitting PriorityConfiguration.java#L211 and so getting assigned a default value. Can we ease
if (!(item.task instanceof Job)) {
That way we could atleast add filters to re-prioritize
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36570) Implement pipeline compatibility
Title: Message Title Jochen Hinrichsen created an issue Jenkins / JENKINS-36570 Implement pipeline compatibility Issue Type: Improvement Assignee: Magnus Sandberg Components: prioritysorter-plugin Created: 2016/Jul/11 11:09 AM Priority: Minor Reporter: Jochen Hinrichsen The priority sorter plugin is not listed in the compatible plugin README.md. In addition, when using the "Run Exclusive" option, pipeline jobs get stuck in the queue. Unchecking the option leads to successful job migrations from the build queue to executors. Add Comment
