[JIRA] (JENKINS-37599) Custom groovy script for promoted builds always including classpath entry
Title: Message Title Jesse Glick commented on JENKINS-37599 Re: Custom groovy script for promoted builds always including classpath entry Filed a PR in Script Security to fail fast and report the issue number. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37599) Custom groovy script for promoted builds always including classpath entry
Title: Message Title Jesse Glick assigned an issue to Unassigned Not exactly critical since there is a straightforward workaround: remove the stray path when you (re-)configure the project. Jenkins / JENKINS-37599 Custom groovy script for promoted builds always including classpath entry Change By: Jesse Glick Component/s: core Component/s: script-security-plugin Priority: Critical Major Assignee: Jesse Glick Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-37599) Custom groovy script for promoted builds always including classpath entry
Title: Message Title
Jesse Glick commented on JENKINS-37599
Re: Custom groovy script for promoted builds always including classpath entry
I think I know what is going on. This code sets minimum=1, intended for the activeItems entry. This code does not bother specifying a minimum, since the default is 0, which is what we want. But the variable is mistakenly inherited across forms. Really this should be using attrs.minimum, which this should also propagate. Can be worked around in script-security via
diff --git a/src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript/config.jelly b/src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript/config.jelly
index d60c722..3154e4d 100644
--- a/src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript/config.jelly
+++ b/src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript/config.jelly
@@ -34,6 +34,6 @@ THE SOFTWARE.
"${%Use Groovy Sandbox}" default="${!h.hasPermission(app.RUN_SCRIPTS)}" />
"${%Additional classpath}" field="classpath">
-"${%Add entry}" header="${%Classpath entry}" field="classpath"/>
+"${%Add entry}" header="${%Classpath entry}" field="classpath" minimum="0"/>
but really this plugin is not at fault, and there may be many other promotion conditions which also suffer. A more tolerable workaround would be in promoted-builds, probably specifying
"minimum" value="0"/>
inside the repeatable blocks in JobPropertyImpl/config.jelly and PublisherImpl/config.jelly, the two places where minimum is specified. But should also be fixed in core.
Add Comment
[JIRA] (JENKINS-37599) Custom groovy script for promoted builds always including classpath entry
Title: Message Title Jesse Glick commented on JENKINS-37599 Re: Custom groovy script for promoted builds always including classpath entry Also reproduced in 1.580.1. But only with Promoted Builds; not, for example, with Groovy Post-Build. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37599) Custom groovy script for promoted builds always including classpath entry
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-37599 Custom groovy script for promoted builds always including classpath entry Reproduced on Linux in 2.7.3. The repeatable list is always showing an entry even where there should be none. Change By: Jesse Glick Summary: Custom groovy script for promoted builds not working on windows always including classpath entry Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
