[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title Liam Newman closed an issue as Fixed Bulk closing resolved issues. Jenkins / JENKINS-37824 Pipeline Model: Add sections for build parameters, triggers and general build properties Change By: Liam Newman Status: Resolved Closed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.173958.1472595021000.17650.1571801068762%40Atlassian.JIRA.
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title Andrew Bayer updated JENKINS-37824 Jenkins / JENKINS-37824 Pipeline Model: Add sections for build parameters, triggers and general build properties Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title SCM/JIRA link daemon commented on JENKINS-37824 Re: Pipeline Model: Add sections for build parameters, triggers and general build properties Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTBuildParameter.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTBuildParameters.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTElement.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTJobProperties.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTJobProperty.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTKeyValueOrMethodCallPair.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTMethodArg.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTMethodCallFromArguments.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTPipelineDef.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTPositionalArgumentList.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTTrigger.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTTriggers.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTValue.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/JobProperties.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/MethodsToList.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Parameters.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Root.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Tools.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Triggers.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidator.groovy src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ModelStepLoader.java src/main/resources/ast-schema.json src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ClosureModelTranslator.groovy src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/MethodsToListTranslator.groovy src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/JobPropertiesTest.java src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ParametersTest.java src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/TriggersTest.java src/test/resources/json/simpleJobProperties.json src/test/resources/json/simpleParameters.json src/test/resources/json/simpleTriggers.json src/test/resources/simpleJobProperties.groovy src/test/resources/simpleParameters.groovy src/test/resources/simpleTriggers.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/f533ef99e31ce44cbe999653e538ea39fdf772dc Log: [FIXED JENKINS-37824] Adding job property-related functionality More specifically, added "jobProperties", "parameters" and "triggers" section and related functionality. This required some fairly complex logic for translating something like "buildDiscard
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title Andrew Bayer commented on JENKINS-37824 Re: Pipeline Model: Add sections for build parameters, triggers and general build properties PR #27 - https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/27 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title Andrew Bayer updated JENKINS-37824 Jenkins / JENKINS-37824 Pipeline Model: Add sections for build parameters, triggers and general build properties Change By: Andrew Bayer Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title
Andrew Bayer commented on JENKINS-37824
Re: Pipeline Model: Add sections for build parameters, triggers and general build properties
So the best bet I've come up with so far is to translate something like:
triggers {
cron('@daily')
}
properties {
buildDiscarder(logRotator(numToKeepStr: '1'))
disableConcurrentBuilds()
}
into a quasi-AST that we can then re-assemble and invoke at runtime. If I could somehow tease each line out into their own closures directly, then we'd be good to go, but I don't see a way to do that currently. And something more like buildDiscarder logRotator(numToKeepStr: '1') (i.e., the syntax we use for tools, agent, etc) doesn't work because logRotator(numToKeepStr: '1') ends up being invoked at parse/config-time. The delegate-fallback approach used in the environment section doesn't, I think, work right here due to the fact that the symbol resolution only works in the right context. Soo. More experimentation to come.
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title Andrew Bayer commented on JENKINS-37824 Re: Pipeline Model: Add sections for build parameters, triggers and general build properties So what I'm trying to figure out here is how to define the properties in their separate sections and translate that into a list of parameters to properties(...). If the properties were all literals, well, that'd be fine. But that'd suck - we want symbols, meaning we want, effectively, lazily evaluated method calls. I have some vague ideas on that front at the moment, but need to keep experimenting to find what might actually work. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title Andrew Bayer commented on JENKINS-37824 Re: Pipeline Model: Add sections for build parameters, triggers and general build properties No longer dependent on JENKINS-38285 since I don't think that's going to happen. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title Andrew Bayer started work on JENKINS-37824 Change By: Andrew Bayer Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title Andrew Bayer commented on JENKINS-37824 Re: Pipeline Model: Add sections for build parameters, triggers and general build properties Marking this as depending on JENKINS-38285 since this is a good opportunity to make the config sections an ExtensionPoint. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37824) Pipeline Model: Add sections for build parameters, triggers and general build properties
Title: Message Title Andrew Bayer created an issue Jenkins / JENKINS-37824 Pipeline Model: Add sections for build parameters, triggers and general build properties Issue Type: Story Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2016/Aug/30 10:10 PM Environment: Pipeline Model 0.1 Priority: Minor Reporter: Andrew Bayer We're currently blacklisting the properties step from usage within the model, and we're going to stay that way - it can cause way too much confusion when executed outside of a central control. But that means we need to provide configuration sections for job properties. I'd like to do that as three separate sections - one for each of build parameters, triggers and other job properties. My reasoning is that the catch-allness of properties is part of its confusion - you can only call it once per Jenkinsfile and you have to have every JobProperty you care about defined in it. I want to add a layer of abstraction over that - the three groupings (parameters, triggers, misc) make sense as three separate sections with different syntax.
