[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title Jesse Glick resolved as Fixed I suppose this is now fixed? if a test specifies a detached plugin without a version, that bundled version will be used, even if LOCAL_SNAPSHOTS=true Seems to be fixed now too. Jenkins / JENKINS-38307 ATH erroneously installs detached plugins, causing needless restarts Change By: Jesse Glick Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38307 Re: ATH erroneously installs detached plugins, causing needless restarts Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_collector/AnalysisCollectorAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_collector/WarningsPerProjectPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AbstractTablePortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/checkstyle/CheckStyleAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/checkstyle/CheckStylePortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/dashboard_view/AbstractDashboardViewPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/findbugs/FindBugsAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/findbugs/FindBugsPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/pmd/PmdAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/pmd/PmdWarningsPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/tasks/TaskScannerAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/tasks/TasksColumn.java src/main/java/org/jenkinsci/test/acceptance/plugins/tasks/TasksPortlet.java src/main/java/org/jenkinsci/test/acceptance/plugins/warnings/WarningsAction.java src/main/java/org/jenkinsci/test/acceptance/plugins/warnings/WarningsPortlet.java src/main/java/org/jenkinsci/test/acceptance/po/AbstractListViewColumn.java src/main/java/org/jenkinsci/test/acceptance/po/Build.java src/main/java/org/jenkinsci/test/acceptance/po/Container.java src/main/java/org/jenkinsci/test/acceptance/po/Folder.java src/main/java/org/jenkinsci/test/acceptance/po/FolderItem.java src/main/java/org/jenkinsci/test/acceptance/po/Jenkins.java src/main/java/org/jenkinsci/test/acceptance/po/TopLevelItem.java src/main/java/org/jenkinsci/test/acceptance/po/WorkflowMultiBranchJob.java src/test/java/plugins/AbstractAnalysisTest.java src/test/java/plugins/AnalysisCollectorPluginTest.java src/test/java/plugins/CheckStylePluginTest.java src/test/java/plugins/FindBugsPluginTest.java src/test/java/plugins/FolderPluginTest.java src/test/java/plugins/JavadocPluginTest.java src/test/java/plugins/PmdPluginTest.java src/test/java/plugins/TaskScannerPluginTest.java src/test/java/plugins/WarningsPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/a71bfc4eca8b0b74a1f91aa3764a20f362476c5e Log: Merge branch 'master' into JENKINS-38307 Add Comment
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38307 Re: ATH erroneously installs detached plugins, causing needless restarts Code changed in jenkins User: Ryan Campbell Path: src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java http://jenkins-ci.org/commit/acceptance-test-harness/af9089a4ef4dce9df984b7c64caad011130e7ae1 Log: JENKINS-38307 Stop installing detached plugins Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38307 Re: ATH erroneously installs detached plugins, causing needless restarts Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java http://jenkins-ci.org/commit/acceptance-test-harness/d009f101d1aee9b0aa8430927a2a3bfc5e91be05 Log: Merge pull request #191 from recampbell/JENKINS-38307 [WIP] JENKINS-38307 Stop installing detached plugins Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38307 Re: ATH erroneously installs detached plugins, causing needless restarts Code changed in jenkins User: Ryan Campbell Path: src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java http://jenkins-ci.org/commit/acceptance-test-harness/01280a90556d901a83c349e6de30875cdb2693b9 Log: JENKINS-38307 Still need to be in test mode Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38307 Re: ATH erroneously installs detached plugins, causing needless restarts Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java src/main/java/org/jenkinsci/test/acceptance/po/JenkinsDatabaseSecurityRealm.java src/test/java/core/JenkinsDatabaseSecurityRealmTest.java src/test/java/core/PublisherOrderTest.java src/test/java/plugins/DescriptionSetterPluginTest.java src/test/java/plugins/JavadocPluginTest.java src/test/java/plugins/KerberosSsoTest.java src/test/java/plugins/MatrixReloadedPluginTest.java src/test/java/plugins/PlotPluginTest.java src/test/java/plugins/PostBuildScriptPluginTest.java src/test/java/plugins/ProjectDescriptionSetterPluginTest.java src/test/java/plugins/SshSlavesPluginTest.java src/test/java/plugins/XvncPluginTest.java src/test/resources/openstack_plugin/cloud-init http://jenkins-ci.org/commit/acceptance-test-harness/cb0267a8841de82c45b35bb205e5c5ef6defe406 Log: Merge pull request #251 from olivergondza/JENKINS-38307 [WIP] JENKINS-38307 Stop installing detached plugins Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/948a5c3ce5a0...cb0267a8841d Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title SCM/JIRA link daemon commented on JENKINS-38307 Re: ATH erroneously installs detached plugins, causing needless restarts Code changed in jenkins User: Jesse Glick Path: src/test/java/plugins/SshSlavesPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/a5ae9dc40e32dfd8847c3d63efa9a315a1fe21e9 Log: JENKINS-38307 Pending #191, make sure we are installing recent versions of plugins, not whatever old stuff happened to be in the detached list. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title Jesse Glick commented on JENKINS-38307 Re: ATH erroneously installs detached plugins, causing needless restarts I also find that if a test specifies a detached plugin without a version, that bundled version will be used, even if LOCAL_SNAPSHOTS=true; you need to add an @ version newer than the detached version to force ATH to use the specified version. I think ATH against Jenkins 2 should completely ignore detached plugins, and always pick the latest version from the UC (or a local snapshot if requested). Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title recampbell commented on JENKINS-38307 Re: ATH erroneously installs detached plugins, causing needless restarts It turns out that much of the trouble making this work is caused by JENKINS-37545. Plugins with old parent poms will pull in the correct dependencies when installed via the update center, but those dependencies won't be installed when the plugin is uploaded. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title recampbell started work on JENKINS-38307 Change By: recampbell Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title recampbell assigned an issue to recampbell Jenkins / JENKINS-38307 ATH erroneously installs detached plugins, causing needless restarts Change By: recampbell Assignee: Oliver Gondža recampbell Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title recampbell updated an issue Jenkins / JENKINS-38307 ATH erroneously installs detached plugins, causing needless restarts Change By: recampbell The acceptance test harness must restart Jenkins after plugin installation due to the fact that outdated, [detached plugins are installed|https://github.com/jenkinsci/acceptance-test-harness/blob/c1512e4da9dc3b4dd701988dae103eaec405ec25/src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java#L182] by default. As per this [outdated commit|https://github.com/jenkinsci/acceptance-test-harness/commit/61e55fa7517efd2ee41b61312d6659c0ce31d0a2], it looks like the intent is just to fix failing tests which have never had to declare detached plugins in their WithPlugins. One impact of this is that almost every test case must restart Jenkins because it installs updated plugins over the existing detached ones, which prevents dynamic deployment from working. I think we actually must take the hard path here and fix up the WithPlugins to be accurate. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-38307) ATH erroneously installs detached plugins, causing needless restarts
Title: Message Title recampbell created an issue Jenkins / JENKINS-38307 ATH erroneously installs detached plugins, causing needless restarts Issue Type: Bug Assignee: Oliver Gondža Components: acceptance-test-harness Created: 2016/Sep/17 11:11 PM Priority: Major Reporter: recampbell The acceptance test harness must restart Jenkins after plugin installation due to the fact that outdated, detached plugins are installed by default. As per this outdated commit, it looks like the intent is just to fix failing tests which have never had to declare detached plugins in their WithPlugins. I think we actually must take the hard path here and fix up the WithPlugins to be accurate. Add Comment
