[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick commented on JENKINS-38380 Re: timeout around input does not work with submitter I know, already fixed, get 2.5. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Digant Patel commented on JENKINS-38380 Re: timeout around input does not work with submitter Hi, When I upgraded to Pipeline: Input Step 2.4, I am getting below error. It seems Pipeline is not able to find "input" DSL keyword, I checked on Snippet Generator, it is missing there as well. java.lang.NoSuchMethodError: No such DSL method 'input' found among [archive, bat, build, catchError, checkout, deleteDir, dir, echo, emailext, emailextrecipients, error, fileExists, findFiles, getContext, isUnix, load, mail, milestone, node, parallel, properties, pwd, readFile, readManifest, readMavenPom, readProperties, readTrusted, retry, sh, sleep, splitTests, stage, stash, step, svn, timeout, timestamps, tool, touch, unarchive, unstash, unzip, waitUntil, withContext, withEnv, wrap, writeFile, writeMavenPom, ws, zip] at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:109) at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:113) at groovy.lang.MetaClassImpl.invokeMethodOnGroovyObject(MetaClassImpl.java:1144) at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1038) at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:903) at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:723) at groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) at groovy.lang.MetaClassImpl.invokeMethodOnGroovyObject(MetaClassImpl.java:1144) at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1038) at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:903) at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:39) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:42) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) at com.cloudbees.groovy.cps.sandbox.DefaultInvoker.methodCall(DefaultInvoker.java:15) at WorkflowScript.run(WorkflowScript:140) at __cps.transform__(Native Method) at com.cloudbees.groovy.cps.impl.ContinuationGroup.methodCall(ContinuationGroup.java:55) at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.dispatchOrArg(FunctionCallBlock.java:106) at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.fixArg(FunctionCallBlock.java:79) at sun.reflect.GeneratedMethodAccessor448.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72) at com.cloudbees.groovy.cps.impl.CollectionLiteralBlock$ContinuationImpl.dispatch(CollectionLiteralBlock.java:55) at com.cloudbees.groovy.cps.impl.CollectionLiteralBlock$ContinuationImpl.item(CollectionLiteralBlock.java:45) at sun.reflect.GeneratedMethodAccessor466.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72) at com.cloudbees.groovy.cps.impl.CollectionLiteralBlock$ContinuationImpl.dispatch(CollectionLiteralBlock.java:55) at com.cloudbees.groovy.cps.impl.CollectionLiteralBlock$ContinuationImpl.item(CollectionLiteralBlock.java:45) at sun.reflect.GeneratedMethodAccessor466.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72) at com.cloudbees.groovy.cps.impl.Col
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick commented on JENKINS-38380 Re: timeout around input does not work with submitter No need; update to Pipeline: Input Step 2.4, with the actual fix of this issue. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Thomas Kalmár commented on JENKINS-38380 Re: timeout around input does not work with submitter I can confirm, that the bug is fixed with Basic Steps 2.3 The timeout cancels the build, but i can approve the input afterwards. Should i fill another bug about that? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick updated JENKINS-38380 Jenkins / JENKINS-38380 timeout around input does not work with submitter Change By: Jesse Glick Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick updated JENKINS-38380 Jenkins / JENKINS-38380 timeout around input does not work with submitter Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick commented on JENKINS-38380 Re: timeout around input does not work with submitter Reproduced an error … jenkins.util.ErrorLoggingScheduledThreadPoolExecutor afterExecute WARNING: failure in task not wrapped in SafeTimerTask hudson.model.Failure: You need to be '…' (or have Job CANCEL permissions) to cancel this. at org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution.preAbortCheck(InputStepExecution.java:215) at org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution.doAbort(InputStepExecution.java:196) at org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution$1.run(InputStepExecution.java:91) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) which may be what you are talking about. When updating Pipeline: Basic Steps to 2.3, the error is still printed, though in that case the timeout does work, due I think to some fix from JENKINS-39072/JENKINS-34637. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick assigned an issue to Jesse Glick Jenkins / JENKINS-38380 timeout around input does not work with submitter Change By: Jesse Glick Assignee: Jesse Glick Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick started work on JENKINS-38380 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-38380 timeout around input does not work with submitter Change By: Jesse Glick Priority: Minor Critical Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Thomas Kalmár commented on JENKINS-38380 Re: timeout around input does not work with submitter The check inside canCancel seems to be ok. getRun().getParent().hasPermission(ACL.SYSTEM, Job.CANCEL) returns true, perhaps the problem is in the basic step not calling the cancel with SYSTEM-Authorization? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Thomas Kalmár commented on JENKINS-38380 Re: timeout around input does not work with submitter Seems to run as anonymous and has no Job.CANCEL Permission. Authentication authentication = Jenkins.getAuthentication(); GrantedAuthority[] authorities = authentication.getAuthorities(); contains only [anonymous] Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-38380 timeout around input does not work with submitter Change By: Jesse Glick Labels: regression Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick commented on JENKINS-38380 Re: timeout around input does not work with submitter Smells like a regression from the fix of JENKINS-37154 to me. canCancel() should have been true if running as SYSTEM; need to check it. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-38380 timeout around input does not work with submitter Change By: Jesse Glick Component/s: workflow-basic-steps-plugin Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Thomas Kalmár created an issue Jenkins / JENKINS-38380 timeout around input does not work with submitter Issue Type: Improvement Assignee: Unassigned Components: pipeline-input-step-plugin, workflow-basic-steps-plugin Created: 2016/Sep/20 2:29 PM Environment: Jenkins ver. 1.651.3 (also 2.7.4) Pipeline: Basic Steps 2.1 Pipeline: Input Step 2.1 Priority: Minor Reporter: Thomas Kalmár The example from https://jenkins.io/doc/pipeline/ timeout(time:5, unit:'DAYS') { input message:'Approve deployment?', submitter: 'it-ops' } does not work. I tested with a shorter timeout and as soon as i added an submitter the input stays for ever open. without submitter the input is correctly terminated. Add Com
[JIRA] (JENKINS-38380) timeout around input does not work with submitter
Title: Message Title Thomas Kalmár updated an issue Jenkins / JENKINS-38380 timeout around input does not work with submitter Change By: Thomas Kalmár Issue Type: Improvement Bug Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.