[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title Michael Neale updated JENKINS-38491 Jenkins / JENKINS-38491 Add new "waitingForInput" status to API for runs, dag and steps Change By: Michael Neale Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-38491 Add new "waitingForInput" status to API for runs, dag and steps Change By: James Dumay Sprint: pacific, atlantic, indian, arctic, tasman , frank Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title Vivek Pandey updated JENKINS-38491 Jenkins / JENKINS-38491 Add new "waitingForInput" status to API for runs, dag and steps Change By: Vivek Pandey Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title
Vivek Pandey edited a comment on JENKINS-38491
Re: Add new "waitingForInput" status to API for runs, dag and steps
[~svanoort] Yeah I saw StatusAndTiming.computechunkStatus() doing it and that looks to me a bug. It reports even the inputs busy doing stuff inside shell script are marked as waiting for PAUSED_PENDING_INPUT status. Basically its going to report every paused input as PAUSED_PENDING_INPUT if there is atleast one of the step is waiting for input.Try this:Inside StandardChunkVisitor.atomNode() implementation I commute status using this api:{code}StatusAndTiming.computeChunkStatus(run, before,atomNode,atomNode,after);{code}Try this script, it will report shell step with sleep inside 'right' branch as PAUSED_PENDING_INPUT status. That is wrong as it should really be IN_PROGRESS.{code}node {stage("parallelStage"){ parallel left : { sh " echo OMG BS " echo " running"def branchInput = input message: 'Please input branch to test against', parameters: [[$class: 'StringParameterDefinition', defaultValue: 'master', description: '', name: 'branch']]echo "BRANCH NAME: ${branchInput}"}, right : {sh "echo wozzle"sh 'sleep 1000'}}}{code}
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title
Vivek Pandey commented on JENKINS-38491
Re: Add new "waitingForInput" status to API for runs, dag and steps
Sam Van Oort Yeah I saw StatusAndTiming.computechunkStatus() doing it and that looks to me a bug. It reports even the inputs busy doing stuff inside shell script are marked as waiting for PAUSED_PENDING_INPUT status. Basically its going to report every paused input as PAUSED_PENDING_INPUT if there is atleast one of the step is waiting for input. Try this: Inside StandardChunkVisitor.atomNode() implementation I commute status using this api:
StatusAndTiming.computeChunkStatus(run, before,atomNode,atomNode,after);
Try this script, it will report shell step with sleep inside 'right' branch as PAUSED_PENDING_INPUT status. That is wrong as it should really be IN_PROGRESS.
node {
stage("parallelStage"){
parallel left : {
sh "echo OMG BS"
echo "running"
def branchInput = input message: 'Please input branch to test against', parameters: [[$class: 'StringParameterDefinition', defaultValue: 'master', description: '', name: 'branch']]
echo "BRANCH NAME: ${branchInput}"
},
right : {
sh "echo wozzle"
sh 'sleep 1000'
}
}
}
Add Comment
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title Sam Van Oort commented on JENKINS-38491 Re: Add new "waitingForInput" status to API for runs, dag and steps Vivek Pandey The run itself will have an InputAction on it – if present, one (or more!) of its heads will be paused for input. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title Vivek Pandey commented on JENKINS-38491 Re: Add new "waitingForInput" status to API for runs, dag and steps Sam Van Oort haha, yes So if I have 3 branches and and all of them have step that's waiting for input, not sure how FlowExecution.getCurrentHeads() will help there? I guess I can make it work by checking status of each atomNode and check if its PAUSED_PENDING_INPUT, assuming I get it on the atomNode thats waiting for input. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title Sam Van Oort commented on JENKINS-38491 Re: Add new "waitingForInput" status to API for runs, dag and steps @vivek I'm shocked to see you really do need all the statuses in pipeline-graph-analysis (PAUSED_PENDING_INPUT) Two easy ways to get the FlowNode: it'll be a current head (FlowExecution.getCurrentHeads()) and have a PauseAction on it, or mark it when the StatusAndTiming API gives you the node status (it'll be PAUSED_PENDING_INPUT). Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title Vivek Pandey commented on JENKINS-38491 Re: Add new "waitingForInput" status to API for runs, dag and steps Sam Van Oort We need to associate a FlowNode (StepAtomNode) with an InputStep. Only possible way I can do it now is, WorkflowRun.getExecutions() and then InputStepExecution.getInput() gives me input but there is no public method to get underlying FlowNode from InputStepExecution. Is there way we can do such association? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title James Dumay commented on JENKINS-38491 Re: Add new "waitingForInput" status to API for runs, dag and steps Vivek Pandey Paused is fine by me. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title Vivek Pandey commented on JENKINS-38491 Re: Add new "waitingForInput" status to API for runs, dag and steps James Dumay Michael Neale We should really be calling it PAUSED state. waiting for input really means run and node is in paused state, however specific step inside it could be in waitingForInput state though. This will let us use PAUSED state used for different type of pulse causes. What do you think? Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title Vivek Pandey started work on JENKINS-38491 Change By: Vivek Pandey Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-38491 Add new "waitingForInput" status to API for runs, dag and steps Change By: James Dumay Sprint: pacific, atlantic, indian, arctic , tasman Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-38491 Add new "waitingForInput" status to API for runs, dag and steps Change By: James Dumay Sprint: pacific, atlantic, indian , arctic Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-38491 Add new "waitingForInput" status to API for runs, dag and steps Change By: James Dumay *In Scope** We need a Add new run "waitingForInput" status when the run is waiting to API for input runs, dag and steps * Status should be called "waitingForInput"* A pipeline's run and any stages or parallels can have the status "waiting for input" so long as it contains one or more input steps waiting for input.*Context*We are showing any runs "waiting for input" with their own status indicator. Don't worry if the UI hasn't mapped it. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-38491) Add new "waitingForInput" status to API for runs, dag and steps
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-38491 Add new "waitingForInput" status to API for runs, dag and steps Change By: James Dumay Summary: Add new "waitingForInput" run status to API for runs, dag and steps Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
