[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-28 Thread svano...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sam Van Oort updated  JENKINS-40934  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Updating to note it is merged in now, pending next release.   
 

  
 
 
 
 

 
 Jenkins /  JENKINS-40934  
 
 
  LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
Change By: 
 Sam Van Oort  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.

[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-21 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 SCM/JIRA link daemon commented on  JENKINS-40934  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
 Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/support/actions/LogActionImpl.java http://jenkins-ci.org/commit/workflow-support-plugin/4b48f17fc8525a9d2cfb63c763d7ec5070192712 Log: Merge pull request #34 from svanoort/fix-bad-big-o-for-copylogs-with-parallels JENKINS-40934 Avoid redundant scans of parallels Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/494446bf5962...4b48f17fc852  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-21 Thread svano...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sam Van Oort edited a comment on  JENKINS-40934  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
 [~jglick] I agree that it would be better, but let us not permit "perfect" to become the enemy of "good" – if we were going to add a reusable API to FlowNode then the quality bar is much higher and it needs to address the fact that an O(n)    search is required at all.  There's no harm in making the fast fix while discussing.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-21 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick commented on  JENKINS-40934  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
 I think it is fine to take the implementation here and just move it to FlowNode, deprecating isRunning and noting in Javadoc that the current implementation runs in linear time. Better than nothing.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-21 Thread svano...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sam Van Oort commented on  JENKINS-40934  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
 Jesse Glick I agree that it would be better, but let us not permit "perfect" to become the enemy of "good" – if we were going to add a reusable API to FlowNode then the quality bar is much higher and it needs to address the fact that an O search is required at all.  There's no harm in making the fast fix while discussing.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-21 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick commented on  JENKINS-40934  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
 Would be better to have a tested and efficient implement in FlowNode to begin with: JENKINS-38223.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-21 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick assigned an issue to Jesse Glick  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40934  
 
 
  LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Assignee: 
 Jesse Glick  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-21 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick updated  JENKINS-40934  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40934  
 
 
  LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-21 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick started work on  JENKINS-40934  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-21 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick assigned an issue to Sam Van Oort  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40934  
 
 
  LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Assignee: 
 Jesse Glick Sam Van Oort  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-03 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-40934  
 
 
  LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
Change By: 
 Jesse Glick  
 
 
Summary: 
 Poor LogActionImpl listener inefficient; poor  performance queuing large parallel workloads  
 
 
Component/s: 
 workflow-support-plugin  
 
 
Component/s: 
 workflow-cps-plugin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-40934) LogActionImpl listener inefficient; poor performance queuing large parallel workloads

2017-03-03 Thread jgl...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jesse Glick commented on  JENKINS-40934  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: LogActionImpl listener inefficient; poor performance queuing large parallel workloads   
 

  
 
 
 
 

 
 Similar code was copied to JENKINS-38381.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.