[JIRA] (JENKINS-41018) Paths not "sanitized" in AccuRev CheckForChanges

2017-01-13 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 SCM/JIRA link daemon commented on  JENKINS-41018  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Paths not "sanitized" in AccuRev CheckForChanges
 

  
 
 
 
 

 
 Code changed in jenkins User: Arno Moonen Path: src/main/java/hudson/plugins/accurev/CheckForChanges.java http://jenkins-ci.org/commit/accurev-plugin/81d07fe4c7232b0dcb72edc39530098935480a35 Log: Merge PR #37 
 
Refactored some code in CheckForChanges and tried to sanitize the paths ( #JENKINS-41018 ). 
 
 
Processed the comments from @casz and made more use of the Apache Commons library (related to #JENKINS-41018 ). 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41018) Paths not "sanitized" in AccuRev CheckForChanges

2017-01-13 Thread a...@90a.nl (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Arno Moonen commented on  JENKINS-41018  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Paths not "sanitized" in AccuRev CheckForChanges
 

  
 
 
 
 

 
 PR has been merged. Should be fixed in next release.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41018) Paths not "sanitized" in AccuRev CheckForChanges

2017-01-13 Thread a...@90a.nl (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Arno Moonen resolved as Fixed  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41018  
 
 
  Paths not "sanitized" in AccuRev CheckForChanges
 

  
 
 
 
 

 
Change By: 
 Arno Moonen  
 
 
Status: 
 Open Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41018) Paths not "sanitized" in AccuRev CheckForChanges

2017-01-13 Thread a...@90a.nl (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Arno Moonen assigned an issue to Arno Moonen  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41018  
 
 
  Paths not "sanitized" in AccuRev CheckForChanges
 

  
 
 
 
 

 
Change By: 
 Arno Moonen  
 
 
Assignee: 
 Joseph Petersen Arno Moonen  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41018) Paths not "sanitized" in AccuRev CheckForChanges

2017-01-13 Thread a...@90a.nl (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Arno Moonen commented on  JENKINS-41018  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Paths not "sanitized" in AccuRev CheckForChanges
 

  
 
 
 
 

 
 PR: https://github.com/jenkinsci/accurev-plugin/pull/37  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41018) Paths not "sanitized" in AccuRev CheckForChanges

2017-01-12 Thread a...@90a.nl (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Arno Moonen commented on  JENKINS-41018  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Paths not "sanitized" in AccuRev CheckForChanges
 

  
 
 
 
 

 
 I've created a fix for this (PR coming up). Problem was not only that the paths were not sanitized, but also that, as soon as a transaction was found that had paths that did not match, it stopped checking for other transaction types.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41018) Paths not "sanitized" in AccuRev CheckForChanges

2017-01-11 Thread a...@90a.nl (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Arno Moonen created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41018  
 
 
  Paths not "sanitized" in AccuRev CheckForChanges
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Joseph Petersen  
 
 
Components: 
 accurev-plugin  
 
 
Created: 
 2017/Jan/12 7:11 AM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Arno Moonen  
 

  
 
 
 
 

 
 Recently I added a job that uses a filter when polling the SCM. In the log I could see the message This transaction seems to have happened after the latest build!!!, but no build was triggered. After looking in the code I'm pretty sure that this is due to the fact that the paths are not sanitized in CheckForChanges.java. By that I mean that my paths might contain different path separators (forward/backward slashes) than the paths in serverPaths. I think that converting the path to a File object and back might help (have not yet tried this), but other/better fixes/suggestions are welcome.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment