[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-03-03 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY updated  JENKINS-41642  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-03-02 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY commented on  JENKINS-41642  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
 https://github.com/jenkinsci/blueocean-plugin/pull/876 https://github.com/jenkinsci/jenkins-design-language/pull/156  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-03-02 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY updated  JENKINS-41642  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-03-02 Thread tom.fenne...@gmail.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom FENNELLY started work on  JENKINS-41642  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Tom FENNELLY  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-03-01 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 

  
 
 
 
 

 
 *In Scope* * If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed.  *  Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message .  * The toast should use the failure style   *Reproduce*You can make favouriting fail by:# Create a multibranch pipeline with no branches# Go to the dashboard# Favourite the pipeline*REST data*REST call will fail with:{code}{  "message" : "no master branch to favorite",  "code" : 400,  "errors" : [ ]}{code} *Scope** Show the failure toast in this case  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...

[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-03-01 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 

  
 
 
 
 

 
 *In Scope*If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user as a toast message*Reproduce*You can make favouriting fail by:# Create a multibranch pipeline with no branches# Go to the dashboard# Favourite the pipeline * REST  data*REST  call will fail with:{code}{  "message" : "no master branch to favorite",  "code" : 400,  "errors" : [ ]}{code}*Scope** Show the failure toast in this case  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://

[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-03-01 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 

  
 
 
 
 

 
 *In Scope* If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the user  as a toast message  *Reproduce* You can make favouriting fail by:# Create a multibranch pipeline with no branches# Go to the dashboard# Favourite the pipelineREST call will fail with:{code}{  "message" : "no master branch to favorite",  "code" : 400,  "errors" : [ ]}{code}*Scope** Show the failure toast in this case  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.goo

[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-02-19 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 

  
 
 
 
 

 
 If favouriting fails for any reason we should show an error toast to the user to tell them the error has failed. Usually there is a reason sent for the failed rest call and this is safe to send to the userYou can make favouriting fail by:# Create a multibranch pipeline with no branches# Go to the dashboard# Favourite the pipelineREST call will fail with:{code}{  "message" : "no master branch to favorite",  "code" : 400,  "errors" : [ ]}{code} *Scope** Show the failure toast in this case  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-02-16 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Sprint: 
 1.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-02-16 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Sprint: 
 iapetus  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-02-16 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Sprint: 
 panthalassa iapetus  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-02-16 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Sprint: 
 post-release panthalassa  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-02-16 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay assigned an issue to Tom FENNELLY  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Assignee: 
 Tom FENNELLY  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-02-05 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Issue Type: 
 Improvement Bug  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41642) Handle when favouriting a pipeline fails

2017-02-01 Thread jdu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 James Dumay updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-41642  
 
 
  Handle when favouriting a pipeline fails   
 

  
 
 
 
 

 
Change By: 
 James Dumay  
 
 
Summary: 
 Handle when favouriting  a pipeline  fails  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.