[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-42924 Favourite pipelines working oddly when there is no default branch to favourite Change By: James Dumay Priority: Major Minor Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title Cliff Meyers edited a comment on JENKINS-42924 Re: Favourite pipelines working oddly when there is no default branch to favourite The error handling won't be too difficult here, but we probably need to give some additional feedback that an error occurred? Clicking the star and having it do nothing will just leave lead to confusion. Should we display some kind of error toast? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title Cliff Meyers commented on JENKINS-42924 Re: Favourite pipelines working oddly when there is no default branch to favourite The error handling won't be too difficult here, but we probably need to give some additional feedback that an error occurred? Clicking the star and having it do nothing will just leave to confusion. Should we display some kind of error toast? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-42924 Favourite pipelines working oddly when there is no default branch to favourite Change By: James Dumay Sprint: Blue Ocean 1.1 If favouriting fails the state of the favourite should not be favourited. *Steps to reproduce (see [video|https://drive.google.com/file/d/0B8uklOZI9kkqNmx1dUUxRUlsQ28/view] with reproducible steps)*: * Go to [/|http://ec2-52-200-141-179.compute-1.amazonaws.com:8080/]blue * Star the hudson pipeline (or a pipeline that has no master to favorite) → you will get an error saying that there is an error starring this pipeline because there is no master. But the pipeline is starred when it shouldn't * Then star another pipeline successfully. The pipeline before gets unstarred * Refreshing the screen will show the failed favourite as unfavourited Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title Cliff Meyers commented on JENKINS-42924 Re: Favourite pipelines working oddly when there is no default branch to favourite James Dumay I recall this default branch issue being discussed quite a long ways back - perhaps there is another related ticket as well? In the event there's an error, should we display a friendly error message and ensure the favorite star isn't shaded in? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title Isa Vilacides updated an issue Jenkins / JENKINS-42924 Favourite pipelines working oddly when there is no default branch to favourite Change By: Isa Vilacides Issue Type: Improvement Bug Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-42924) Favourite pipelines working oddly when there is no default branch to favourite
Title: Message Title Isa Vilacides created an issue Jenkins / JENKINS-42924 Favourite pipelines working oddly when there is no default branch to favourite Issue Type: Improvement Assignee: Unassigned Components: blueocean-plugin Created: 2017/Mar/20 9:41 AM Environment: 1.0.0-rc1 · Core 2.32.3 · 9ac3256 Priority: Major Reporter: Isa Vilacides Steps to reproduce (see video with reproducible steps): Go to /blue Star the hudson pipeline (or a pipeline that has no master to favorite) → you will get an error saying that there is an error starring this pipeline because there is no master. But the pipeline is starred when it shouldn't Then star another pipeline successfully. The pipeline before gets unstarred Add Comment
