[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Vivek Pandey updated an issue Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Change By: Vivek Pandey Sprint: Blue Ocean 1.6 - beta 2 , Blue Ocean - 1.6 - beta 4 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title
Andrew Bayer commented on JENKINS-43016
Re: BlueOcean editor: does not allow empty string for label on agent or node
FYI, I've put up https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/264 on the Declarative side - this'll convert
agent {
label ''
}
to the JSON for agent any when translating to JSON for the editor, which will unbreak the most general use case for an empty string label. However, it'll still have an empty string label in the JSON if there are additional options, like in the case of
agent {
label ''
customWorkspace '/some/path'
}
...so even with this, the editor should still ideally have a way to specify an empty string for the label.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Vivek Pandey updated an issue Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Change By: Vivek Pandey Sprint: Blue Ocean 1.6 - beta 1 2 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Liam Newman commented on JENKINS-43016 Re: BlueOcean editor: does not allow empty string for label on agent or node That sounds like a reasonable workaround to me. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Andrew Bayer commented on JENKINS-43016 Re: BlueOcean editor: does not allow empty string for label on agent or node Ah - yes, that error is bad. Didn't think of that. There is no way to do "required but can be empty (or null)". Probably the best bet would be to have the conversion to JSON just shrug and change to agent any when it hits that scenario. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title
Liam Newman edited a comment on JENKINS-43016
Re: BlueOcean editor: does not allow empty string for label on agent or node
I strongly disagree. "agent \{ label '' }" is valid declarative syntax. If I open a pipeline with that syntax in it, Blue Ocean will report an error and force me not to use that syntax. That is not acceptable. I understand that we'd like people to use "agent any" instead, but we should not be reporting an error in the editor for valid Declarative syntax. It sounds like this might be exposing a design bug - there plenty of situations where required string is allowed to be empty. Is there no way to specify "required but may be an empty string"?
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title
Liam Newman commented on JENKINS-43016
Re: BlueOcean editor: does not allow empty string for label on agent or node
I strongly disagree. "agent { label '' }" is valid declarative syntax. If I open a pipeline with that syntax in it, Blue Ocean will report an error and force me not to use that syntax. I understand that we'd like people to use "agent any" instead, but we should not be reporting an error in the editor for valid Declarative syntax. It sounds like this might be exposing a design bug - there plenty of situations where required string is allowed to be empty. Is there no way to specify "required but may be an empty string"?
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Andrew Bayer commented on JENKINS-43016 Re: BlueOcean editor: does not allow empty string for label on agent or node Yeah, I'm fine with leaving things as they are now. We're stuck with the required field bit for various historic reasons, but I don't think it's worth anyone's time to hack out a way to support empty string in the editor in this context when agent any achieves exactly the same thing. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Nicolae Pascu commented on JENKINS-43016 Re: BlueOcean editor: does not allow empty string for label on agent or node I understand your reasoning but in the front-end a required field means it should not be empty e.g. "". I suggest we either leave things as they are now or if we want an empty string to be a valid value in BO then I suggest we change the isRequired to false. Vivek Pandey what do you think? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Andrew Bayer commented on JENKINS-43016 Re: BlueOcean editor: does not allow empty string for label on agent or node Yes, the label parameter is required for the label agent. But "" should be an acceptable value for it. That said, I don't think this is a must-fix - agent label with "" is literally the same thing as agent any in execution. Not just analogous - literally the same thing. So agent any is a perfectly acceptable alternative. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Vivek Pandey updated an issue Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Change By: Vivek Pandey Sprint: Blue Ocean 1. 5 6 - beta 3 1 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Nicolae Pascu commented on JENKINS-43016 Re: BlueOcean editor: does not allow empty string for label on agent or node Andrew Bayer I am receiving the Label param from node as being required from jenkins/blue/rest/pipeline-metadata/agentMetadata?depth=20 After talking to Vivek Pandey he said I should ping you about it. This is the full JSON response: https://gist.github.com/NicuPascu/9ed1d96d4604274683ad2ef48a0778fc Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Nicolae Pascu started work on JENKINS-43016 Change By: Nicolae Pascu Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Nicolae Pascu assigned an issue to Nicolae Pascu Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Change By: Nicolae Pascu Assignee: Nicolae Pascu Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Nicolae Pascu updated an issue Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Change By: Nicolae Pascu Sprint: Blue Ocean 1.5 - Candidates beta 3 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Change By: James Dumay Sprint: Blue Ocean 1.1 up next Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Change By: James Dumay Sprint: Blue Ocean up next 1.1 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Change By: James Dumay Sprint: Blue Ocean 1.1 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title James Dumay updated an issue Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Change By: James Dumay Priority: Minor Major Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-43016) BlueOcean editor: does not allow empty string for label on agent or node
Title: Message Title Liam Newman created an issue Jenkins / JENKINS-43016 BlueOcean editor: does not allow empty string for label on agent or node Issue Type: Bug Assignee: Unassigned Attachments: Screen Shot 2017-03-21 at 2.03.13 PM.png Components: blueocean-pipeline-editor-plugin Created: 2017/Mar/22 1:21 AM Environment: rc1 Priority: Minor Reporter: Liam Newman Node and agent label strings in Pipeline can be an empty string '', but BlueOcean editor does not allow it be blank (see attached). Add Comment
