[JIRA] (JENKINS-48563) Agent Labels missing in GUI
Title: Message Title Allan BURDAJEWICZ commented on JENKINS-48563 Re: Agent Labels missing in GUI Note that when reproducing, I noticed that the labels in the node status page are not missing immediately after adding the faulty label to the freestyle project. Even when reloading the page. Reloading the page after some time exposes it though. I am not too sure why. But the double quotes are definitely the culprit. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48563) Agent Labels missing in GUI
Title: Message Title Daniel Beck commented on JENKINS-48563 Re: Agent Labels missing in GUI Seems likely to me that the handling of STRINGLITERAL, specifically the call to QuotedStringTokenizer.unquote, is to blame here. Perhaps nobody considered that stripping quotes will result in a non-atomic label _expression_? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48563) Agent Labels missing in GUI
Title: Message Title Daniel Beck commented on JENKINS-48563 Re: Agent Labels missing in GUI The reproduction steps indicate this is basically just b")" class="issue-link" data-issue-key="JENKINS-22975" style="color: #3b73af; text-decoration: none">JENKINS-22975. Spaces make the problem go away here as well. Not 100% certain though (and my analysis related to the legixal nondeterminism in x86" is an invalid _expression_" class="issue-link" data-issue-key="JENKINS-16728" style="color: #3b73af; text-decoration: none">JENKINS-16728 may well be wrong if other expressions are affected as well). Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48563) Agent Labels missing in GUI
Title: Message Title Allan BURDAJEWICZ commented on JENKINS-48563 Re: Agent Labels missing in GUI A way to reproduce this issue is to: create a simple node with labels, for example dedicated osx Go to the nodes status page: the "Labels" section displays each label with a link to it create a freestyle project, tick "Restrict where this project can be run" and use the label _expression_ "dedicated||master" - including the double quotes! Go to the nodes status page: the "Labels" section displays no labels anymore Note that when you enter the label with double quotes "dedicated||master" in the project, you see a exception in the UI: classcastexception-abstractproject.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48563) Agent Labels missing in GUI
Title: Message Title Allan BURDAJEWICZ updated an issue Jenkins / JENKINS-48563 Agent Labels missing in GUI Change By: Allan BURDAJEWICZ Attachment: classcastexception-abstractproject.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-48563) Agent Labels missing in GUI
Title: Message Title Allan BURDAJEWICZ commented on JENKINS-48563 Re: Agent Labels missing in GUI Found interesting exception in the logs: 2017-11-27 18:04:23.501+ [id=11338] WARNING h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: it.node.labelCloud in /computer/my-agent/. Reason: java.lang.reflect.InvocationTargetException java.lang.ClassCastException: hudson.model.labels.LabelExpression$And cannot be cast to hudson.model.labels.LabelAtom at jenkins.model.Jenkins.getLabelAtom(Jenkins.java:2003) at hudson.model.labels.LabelAtom.get(LabelAtom.java:235) at hudson.model.labels.LabelExpressionParser.term6(LabelExpressionParser.java:208) at hudson.model.labels.LabelExpressionParser.term5(LabelExpressionParser.java:164) at hudson.model.labels.LabelExpressionParser.term4(LabelExpressionParser.java:136) at hudson.model.labels.LabelExpressionParser.term3(LabelExpressionParser.java:113) at hudson.model.labels.LabelExpressionParser.term2(LabelExpressionParser.java:83) at hudson.model.labels.LabelExpressionParser.term1(LabelExpressionParser.java:60) at hudson.model.labels.LabelExpressionParser.expr(LabelExpressionParser.java:50) at hudson.model.Label.parseExpression(Label.java:611) at hudson.model.AbstractProject.getAssignedLabelString(AbstractProject.java:425) at hudson.model.Label.getTiedJobCount(Label.java:410) at hudson.model.Node$1.weight(Node.java:284) at hudson.model.Node$1.weight(Node.java:282) at hudson.util.TagCloud.(TagCloud.java:73) at hudson.model.Node.getLabelCloud(Node.java:282) Caused: java.lang.reflect.InvocationTargetException This points to an offending label _expression_ in an AbstractProject: https://github.com/jenkinsci/jenkins/blob/jenkins-2.60.3/core/src/main/java/hudson/model/Label.java#L410 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
[JIRA] (JENKINS-48563) Agent Labels missing in GUI
Title: Message Title Carlos Lopez commented on JENKINS-48563 Re: Agent Labels missing in GUI Daniel Beck I opened this issue on behalf of Jason Newblanc. Jason Newblanc - Can you please provide the requested input when the issue is exposed? The output from Required Data: CJP/CJT Hang Issue On Linux might be really useful in this context. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
