[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi Emil Wypych, that's enough, I'll close the issue. Thank you very much for reporting and testing. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano closed an issue as Fixed Jenkins / JENKINS-49368 Last Changes causes the JENKINS-45892 Change By: Rafael Pestano Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Emil Wypych commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Rafael Pestano I've just updated Last Changes Plugin and made some tests - I confirm that problem was solved. Now I just see SUCCESS: main build action completed: SUCCESS Tested with few different jobs. Do you need something else, or is it enough for confirmation? Also thank you very much for resolving this issue - logs look much better. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Emil Wypych commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Rafael Pestano yes, sure, I will do it today, but at evening (~9 P.M. CET). I will give you feedback when I'm done. Thank you very much for fast release! Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Emil Wypych, can you try with v2.6.1 and share the results? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Just created JENKINS-50116. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano resolved as Fixed Jenkins / JENKINS-49368 Last Changes causes the JENKINS-45892 Change By: Rafael Pestano Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Oleg Nenashev I've looked into the "xstream" stuff and did not figured out how to "restore the field". If you want to provide a PR or point to a plugin which does that I'll be happy to fix. Meanwhile I'll create another issue for that case. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Oleg Nenashev commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Rafael Pestano https://wiki.jenkins.io/display/JENKINS/Hint+on+retaining+backward+compatibility, but maybe you do not need that: > I would actually suggest modifying getJob() to restore the field if null and then switch all the code to using this method instead of the direct field access. Your mileage may vary Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano edited a comment on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi Oleg,Yes, this issue after restart always happened. Although no NPE is raised the list from getLastChangesBuilds comes empty and only is populated after user runs the job again.Can you point me to an example of how to implement the redResolve readResolve to restore the list form disk? Thank you! Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi Oleg, Yes, this issue after restart always happened. Although no NPE is raised the list from getLastChangesBuilds comes empty and only is populated after user runs the job again. Can you point me to an example of how to implement the redResolve to restore the list form disk? Thank you! Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Oleg Nenashev commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Rafael Pestano FYI https://github.com/jenkinsci/last-changes-plugin/commit/0cb6083a31b207099c5400e4f4a93bee8510f3a5 will not work correctly after the Jenkins restart. The class has no readResolve() resolution, so the value will be null when you save new jobs and reload them from the disk. It will cause NPEs in methods like getLastChangesBuilds(). I would actually suggest modifying getJob() to restore the field if null and then switch all the code to using this method instead of the direct field access. Your mileage may vary Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi Oleg Nenashev, you nailed it. Thank you one more time! I'll do some more tests and release v2.6.1 containing the fix. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Oleg Nenashev commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 References which can be cleaned up: https://github.com/jenkinsci/last-changes-plugin/blob/master/src/main/java/com/github/jenkins/lastchanges/LastChangesBuildAction.java#L17 https://github.com/jenkinsci/last-changes-plugin/blob/master/src/main/java/com/github/jenkins/lastchanges/LastChangesProjectAction.java#L13 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Emil Wypych commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Ok, thanks for the update. No problem - there are more important things and I know about it, just wanted to know how estimation looks like. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi, the mentioned issue is almost done so I hope to look into this one during this week. Sorry for the delay. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Emil Wypych commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi Rafael Pestano ! Have you finished the issue you mentioned? Could you please update me on the status of this issue or give some ETA? Now we work on Jenkins 2.109 and issue still persists. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano edited a comment on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi Emil, thank you for all the details.I'm working on another issue (SECURITY-308) and as soon I fix It In got it fixed I will look into this one. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi Emil, thank you for all the details. I'm working on another issue (SECURITY-308) and as soon I fix It In will look into this one. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Emil Wypych commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Rafael Pestano , could you please update me on the status of this issue? Thanks in advance! Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Emil Wypych commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi, I'm sure, I have checked this. When I add the Last Changes as the post-build action (even with the simplest job, just one shell step without any parameters, but with the valid git repository), this stacktrace appears in Jenkins log. Without the Publish Last Changes, everything is ok. I know that Last Changes isn't mentioned in the stacktrace and that's why it was difficult to check which plugin cause this problem. I've just run the docker image jenkins/jenkins:lts (2.89.3), fresh installation, default plugins + Last Changes. Created new Freestyle Job, xml: false 2 https://github.com/ewypych/icinga-domain-expiration-plugin.git */master false true false false false false echo test PREVIOUS_REVISION LINE NONE true true 0.25 1000 false false And there is the stacktrace of the warning in the Jenkins logs: Feb 12, 2018 4:51:19 PM WARNING hudson.XmlFile replaceIfNotAtTopLevel JENKINS-45892: reference to hudson.model.FreeStyleProject@46e5a689[test-last-changes] being saved from unexpected /var/jenkins_home/jobs/test-last-changes/builds/1/build.xml java.lang.IllegalStateException at hudson.XmlFile.replaceIfNotAtTopLevel(XmlFile.java:210) at hudson.model.AbstractItem.writeReplace(AbstractItem.java:509) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.thoughtworks.xstream.converters.reflection.SerializationMethodInvoker.callWriteReplace(SerializationMethodInvoker.java:89) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:141) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84) at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265) at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252) at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224) at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138) at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano edited a comment on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi [~ewypych], I could not look into this yet, are you sure it is related to last-changes? I don't see last-changes in stacktrace. When you remove the plugin the error stops? - Also have you tried with last-changes v2.5? - (Now I see you've tested with previous versions). Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Rafael Pestano commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hi Emil Wypych, I could not look into this yet, are you sure it is related to last-changes? I don't see last-changes in stacktrace. When you remove the plugin the error stops? Also have you tried with last-changes v2.5? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49368) Last Changes causes the JENKINS-45892
Title: Message Title Emil Wypych commented on JENKINS-49368 Re: Last Changes causes the JENKINS-45892 Hello, Rafael Pestano ! Could you please update me on the status of this issue? Have you already checked this? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
