[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title Nicolas De Loof closed an issue as Not A Defect Jenkins / JENKINS-49446 Regression with 1.15 and WithContainerStep Change By: Nicolas De Loof Status: Open Closed Resolution: Not A Defect Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title Nicolas De Loof commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep docker-workflow plugin comes with constraints, which unfortunately never have been clearly documented. Those are pretty comparable to https://github.com/knative/docs/blob/master/build/builder-contract.md But there's no way we support arbitrary docker images and entrypoint script. Adapt your docker images so they fit into our model Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title Mark Russell commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep This issue is stopping up from upgrading this plugins. Is anyone looking at it? Is there any chance for a solution on this? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title Nicolas De Loof commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep Andrew Bayer > "abusing container lifecycle" is, frankly, irrelevant here. What matters is that we keep from breaking users any more than absolutely necessary Sorry to say it has bee absolutely necessary. We need entrypoint support for many major use-cases, disabling them was a breaking change. It just has been restored, and introduced diagnostic code to assist end-user in fixing his pipeline/image. And we do abuse container lifecycle forcing the container to run a command it has not been designed for. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title Nicolas De Loof commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep @myoung34 you're perfectly right, this is not a requirement but a convention on official image (it's required to get official image approved), and many custom image don't follow this. Our issue here is we are abusing the container lifecycle : an arbitrary docker image is not designed to run arbitrary command like we use them for. One option is to override entrypoint to run a custom command. But then we disable the initial entrypoint designed by image author, which in many cases is required for the image to make any sense. Typically, Selenium images do use it to run a X11 server. This option has been adopted in the past, introducing https://issues.jenkins-ci.org/browse/JENKINS-41316 regression. The other is to assume newcomers mostly will try docker pipeline using official images. So we offer a solution which works out-of-the box, and can't report issue with target image if detected not to match our requirements. Those who are already used with docker-pipeline then get a documented direction on how to fix their image or update their pipeline. I welcome any suggestion for a 3rd option. As one can't "docker exec" in a stopped container, we have to find some way for the container to run a "pause" command, and this is definitively not part of docker spec to support this. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title
marc young edited a comment on JENKINS-49446
Re: Regression with 1.15 and WithContainerStep
I'd also like to point out (aside from breaking everything at 3 of my contracts): you've based everything on "requirements" that are actually suggestions.The error I'm now facing in dozens of builds:{code}04:11:59 ERROR: The container started but didn't run the expected command. Please double check your ENTRYPOINT does execute the command passed as docker run argument, as required by official docker images (see https://github.com/docker-library/official-images#consistency for entrypoint consistency requirements).{code}Youve stated *as required by* . However those docs clearly say:{code}All official images should provide a consistent interface. {code}Should != require. Your use-case and assumptions are not a standard to hold an entire community to Please remember: I'm using *other* peoples *official* containers to run in jenkins. I cannot (and will not) fork every single one of these to meet your guidelines.
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title marc young commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep I'd also like to point out (aside from breaking everything at 3 of my contracts): you've based everything on "requirements" that are actually suggestions. The error I'm now facing in dozens of builds: 04:11:59 ERROR: The container started but didn't run the expected command. Please double check your ENTRYPOINT does execute the command passed as docker run argument, as required by official docker images (see https://github.com/docker-library/official-images#consistency for entrypoint consistency requirements). Youve stated as required by . However those docs clearly say: All official images should provide a consistent interface. Should != require. Your use-case and assumptions are not a standard to hold an entire community to Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title Andrew Bayer commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep fwiw, "abusing container lifecycle" is, frankly, irrelevant here. What matters is that we keep from breaking users any more than absolutely necessary. I strongly agreed with going back to cmd rather than entrypoint, but there is a valid point that we may have waited too long to do so. Not to say I have the right answer, but we do need to think about this. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title R. Tyler Croy commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep Nicolas De Loof, I think that's a reasonable concern. Would you be willing perhaps to write for jenkins.io about entrypoint and changes for Docker Pipeline 1.15? My highest concern here is that a point release might introduce surprising, and seemingly breaking, behavior for the nearly 100k installations of this plugin. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title Nicolas De Loof commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep I dislike the idea we magically disable entrypoint. If image doesn't support passing a command, should be explicit by end-user to disable entrypoint, of doing this in the background will result in some unexpected side effects and resurection for some older issues. but that's just my opinion, if others consider this a sane approach, feel free to follow up this way. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title R. Tyler Croy commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep Nicolas De Loof, I understand that defaulting to -entrypoint="" is problematic, but why wouldn't it be reasonable to add the behavior to try -entrypoint="" when that docker top check fails. That would be, IMHO, ideal for end users to avoid breakages and consistent usage of docker.image.inside Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title Nicolas De Loof commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep Removing support for entrypoint was a breaking change, restoring is another from some point of view. Making --entrypoint="" the default behaviour would be wrong as well. Nothing we can do here, docker.inside is just abusing container lifecycle. Should be deprecated imho, but being highly used by declarative we miss an alternative Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title R. Tyler Croy commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep Nicolas De Loof, I'm trying to understand more whether this is a bug or whether this is a breaking change which should be very broadly communicated. As I referenced in my previous comment, this Jenkinsfile has worked for a long-long time, and works with 1.14. As of 1.15 this Pipeline now breaks. If the solution is to add `--entrypoint=""`, then could the Docker Pipeline plugin simply doi that automatically? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title
R. Tyler Croy commented on JENKINS-49446
Re: Regression with 1.15 and WithContainerStep
Tested with a 1.5.1 .hpi downloaded from repo.jenkins-ci.org, still the same error with this Pipeline:
node {
docker.image('koalaman/shellcheck:v0.4.6').inside {
sh 'pwd'
}
}
(simialr to this Jenkinsfile)
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title Nicolas De Loof commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep it seems so indeed. 1.15.1 won't fix this by magic, you might have to pass extra arg `–entrypoint=""` if image's entrypoint isn't designed as recommended by docker for official images. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49446) Regression with 1.15 and WithContainerStep
Title: Message Title R. Tyler Croy commented on JENKINS-49446 Re: Regression with 1.15 and WithContainerStep I think this might be a duplicate of JENKINS-49278. Will test with the new 1.15.1 release to verify Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
