[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title Rick Liu commented on JENKINS-49486 Re: Approvers field doesn't expand variable in the build Pull-request prepared: https://github.com/jenkinsci/promoted-builds-plugin/pull/114 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title Rick Liu updated an issue Jenkins / JENKINS-49486 Approvers field doesn't expand variable in the build Change By: Rick Liu Comment: [~samsun387]test Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title Rick Liu commented on JENKINS-49486 Re: Approvers field doesn't expand variable in the build Kevin Yu test Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title
Rick Liu updated an issue
Jenkins / JENKINS-49486
Approvers field doesn't expand variable in the build
Change By:
Rick Liu
Comment:
[~oleg_nenashev]Hi Oleg,If I want to develop this feature,what approach would you recommand?1. Try to bring in Token Macro plugin's {{TokenMacro.expandAll(build, listener, approval.name)}}in File "*conditions/ManualCondition.java*" [Line118|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java#L118], [Line140|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java#L140]2.Or try something similar in File "*conditions/ParameterizedSelfPromotionCondition.java*"[Line49|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ParameterizedSelfPromotionCondition.java#L49] to use {{build.getBuildVariables()}} to cross-reference the variable
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title
Rick Liu edited a comment on JENKINS-49486
Re: Approvers field doesn't expand variable in the build
[~oleg_nenashev]Hi Oleg,If I want to develop this feature,what approach would you recommand?1. Try to bring in Token Macro plugin's {{TokenMacro.expandAll( build, listener, approval.name ) }}in File "*conditions/ManualCondition.java*" [Line118|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java#L118], [Line140|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java#L140]2.Or try something similar in File "*conditions/ParameterizedSelfPromotionCondition.java*"[Line49|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ParameterizedSelfPromotionCondition.java#L49] to use {{build.getBuildVariables()}} to cross-reference the variable
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title
Rick Liu edited a comment on JENKINS-49486
Re: Approvers field doesn't expand variable in the build
[~oleg_nenashev]Hi Oleg,If I want to develop this feature,what approach would you recommand?1. Try to bring in Token Macro plugin's {{ TokenMacro.expandAll( build, listener, approval.name )}} in File "*conditions/ManualCondition.java*" [Line118|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java#L118], [Line140|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java#L140]2.Or try something similar in File " * conditions/ParameterizedSelfPromotionCondition.java * "[Line49|https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/main/java/hudson/plugins/promoted_builds/conditions/ParameterizedSelfPromotionCondition.java#L49] to use {{ build.getBuildVariables() }} to cross-reference the variable
Add Comment
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title Rick Liu commented on JENKINS-49486 Re: Approvers field doesn't expand variable in the build Oleg Nenashev Hi Oleg, If I want to develop this feature, what approach would you recommand? 1. Try to bring in Token Macro plugin's TokenMacro.expandAll( build, listener, approval.name ) in File "conditions/ManualCondition.java" Line118, Line140 2. Or try something similar in File "conditions/ParameterizedSelfPromotionCondition.java" Line49 to use build.getBuildVariables() to cross-reference the variable Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title Oleg Nenashev commented on JENKINS-49486 Re: Approvers field doesn't expand variable in the build IMHO it is rather a new feature request, not a defect. Reason: support of properties in this field is not documented anywhere AFAICT. Please correct me if I am wrong Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title Oleg Nenashev updated an issue Jenkins / JENKINS-49486 Approvers field doesn't expand variable in the build Change By: Oleg Nenashev Issue Type: Bug New Feature Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title Oleg Nenashev assigned an issue to Unassigned Jenkins / JENKINS-49486 Approvers field doesn't expand variable in the build Change By: Oleg Nenashev Assignee: Oleg Nenashev Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title Rick Liu updated an issue Jenkins / JENKINS-49486 Approvers field doesn't expand variable in the build Change By: Rick Liu Attachment: Selection_020.png Attachment: Selection_021.png Attachment: Selection_022.png Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-49486) Approvers field doesn't expand variable in the build
Title: Message Title Rick Liu created an issue Jenkins / JENKINS-49486 Approvers field doesn't expand variable in the build Issue Type: Bug Assignee: Oleg Nenashev Components: promoted-builds-plugin Created: 2018-02-10 03:30 Environment: Ubuntu 16.04 Jenkins ver. 2.46.2 LTS promoted builds plugin v2.28.1 Priority: Major Reporter: Rick Liu Under "Criteria" section, when select "Only when manually approved", Approvers field doesn't expand variable in the build. Add Comment
