[JIRA] (JENKINS-49928) Add editor ATH coverage for changing agent settings in a Jenkinsfile

2018-05-24 Thread kshu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Karl Shultz updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-49928  
 
 
  Add editor ATH coverage for changing agent settings in a Jenkinsfile   
 

  
 
 
 
 

 
Change By: 
 Karl Shultz  
 
 
Component/s: 
 blueocean-acceptance-test  
 
 
Component/s: 
 blueocean-pipeline-editor-plugin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-49928) Add editor ATH coverage for changing agent settings in a Jenkinsfile

2018-04-11 Thread kshu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Karl Shultz updated  JENKINS-49928  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Merged 1716.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-49928  
 
 
  Add editor ATH coverage for changing agent settings in a Jenkinsfile   
 

  
 
 
 
 

 
Change By: 
 Karl Shultz  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Done  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-49928) Add editor ATH coverage for changing agent settings in a Jenkinsfile

2018-04-10 Thread kshu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Karl Shultz updated  JENKINS-49928  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-49928  
 
 
  Add editor ATH coverage for changing agent settings in a Jenkinsfile   
 

  
 
 
 
 

 
Change By: 
 Karl Shultz  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-49928) Add editor ATH coverage for changing agent settings in a Jenkinsfile

2018-04-10 Thread kshu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Karl Shultz commented on  JENKINS-49928  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add editor ATH coverage for changing agent settings in a Jenkinsfile   
 

  
 
 
 
 

 
 PR up.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-49928) Add editor ATH coverage for changing agent settings in a Jenkinsfile

2018-03-28 Thread kshu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Karl Shultz started work on  JENKINS-49928  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Karl Shultz  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-49928) Add editor ATH coverage for changing agent settings in a Jenkinsfile

2018-03-06 Thread kshu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Karl Shultz assigned an issue to Karl Shultz  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-49928  
 
 
  Add editor ATH coverage for changing agent settings in a Jenkinsfile   
 

  
 
 
 
 

 
Change By: 
 Karl Shultz  
 
 
Assignee: 
 Karl Shultz  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-49928) Add editor ATH coverage for changing agent settings in a Jenkinsfile

2018-03-05 Thread kshu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Karl Shultz updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-49928  
 
 
  Add editor ATH coverage for changing agent settings in a Jenkinsfile   
 

  
 
 
 
 

 
Change By: 
 Karl Shultz  
 

  
 
 
 
 

 
 *Summary:*Making changes to build agent settings in a Jenkinsfile is an important feature available in the editor, but none of our existing tests cover this path. A simple ATH test (or even an addition to another, existing test) would be a nice coverage  improement  improvement .*Ideas:*An offline test could create a repository including an existing Jenkinsfile, stored in [our resources directory|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline], like we're doing [here|https://github.com/jenkinsci/blueocean-plugin/tree/master/acceptance-tests/src/test/resources/io/blueocean/ath/offline/multibranch/ParallelNavigationTest]. This existing Jenkinsfile might include something like:{code:none}agent {label ("linux")}{code}which we could then use the editor to change into {code:none}agent any{code}And then verify that the changes were made correctly.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  

[JIRA] (JENKINS-49928) Add editor ATH coverage for changing agent settings in a Jenkinsfile

2018-03-05 Thread kshu...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Karl Shultz created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-49928  
 
 
  Add editor ATH coverage for changing agent settings in a Jenkinsfile   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 blueocean-pipeline-editor-plugin  
 
 
Created: 
 2018-03-05 18:37  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Karl Shultz  
 

  
 
 
 
 

 
 Summary: Making changes to build agent settings in a Jenkinsfile is an important feature available in the editor, but none of our existing tests cover this path. A simple ATH test (or even an addition to another, existing test) would be a nice coverage improement. Ideas: An offline test could create a repository including an existing Jenkinsfile, stored in our resources directory, like we're doing here. This existing Jenkinsfile might include something like: 

 

agent {
label ("linux")
}
 

 which we could then use the editor to change into  

 

agent any
 

 And then verify that the changes were made correctly.