[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title Jesse Glick updated JENKINS-51397 Jenkins / JENKINS-51397 docker login being called without server-related environment variables Change By: Jesse Glick Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title SCM/JIRA link daemon commented on JENKINS-51397 Re: docker login being called without server-related environment variables Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java http://jenkins-ci.org/commit/docker-workflow-plugin/a19719c196def05b740b44b75376e25dda077b84 Log: Merge pull request #140 from jglick/docker-login-env-JENKINS-51397 JENKINS-51397 Pass environment to docker login command Compare: https://github.com/jenkinsci/docker-workflow-plugin/compare/e8a1815cf41b...a19719c196de *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title SCM/JIRA link daemon commented on JENKINS-51397 Re: docker login being called without server-related environment variables Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java http://jenkins-ci.org/commit/docker-workflow-plugin/2319da7e180d2c49d77f8572becb980573bdf241 Log: JENKINS-51397 Pass environment to docker login command. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title SCM/JIRA link daemon commented on JENKINS-51397 Re: docker login being called without server-related environment variables Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryEndpoint.java src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryToken.java src/main/java/org/jenkinsci/plugins/docker/commons/impl/RegistryKeyMaterialFactory.java src/test/java/org/jenkinsci/plugins/docker/commons/util/SampleDockerBuilder.java http://jenkins-ci.org/commit/docker-commons-plugin/4f7f7772d36c277c0a055489d35bccaa3658890e Log: JENKINS-51397 Define API for passing environment to docker login command. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title SCM/JIRA link daemon commented on JENKINS-51397 Re: docker login being called without server-related environment variables Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryEndpoint.java src/main/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryToken.java src/main/java/org/jenkinsci/plugins/docker/commons/impl/RegistryKeyMaterialFactory.java src/test/java/org/jenkinsci/plugins/docker/commons/util/SampleDockerBuilder.java http://jenkins-ci.org/commit/docker-commons-plugin/a5e6fa06a9d2f2419dc4e9cf1c07ff2886df5a5e Log: Merge pull request #71 from jglick/docker-login-env-JENKINS-51397 JENKINS-51397 Define API for passing environment to docker login command Compare: https://github.com/jenkinsci/docker-commons-plugin/compare/5bd5ad32f534...a5e6fa06a9d2 *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title Hans Schulz commented on JENKINS-51397 Re: docker login being called without server-related environment variables Jesse Glick The fix works for us, thank you! Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title Jesse Glick commented on JENKINS-51397 Re: docker login being called without server-related environment variables (The downloads above also include the fix for JENKINS-51395.) Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title Jesse Glick commented on JENKINS-51397 Re: docker login being called without server-related environment variables BTW Nico Navarrete the version of the docker plugin is probably irrelevant here. docker-commons and docker-workflow are the plugins involved. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title Jesse Glick commented on JENKINS-51397 Re: docker login being called without server-related environment variables Nico Navarrete Scott Williams Hans Schulz et al., anyone care to test a proposed fix? If so, use the Advanced tab to manually update this build of docker-commons and of docker-workflow. Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title Jesse Glick updated JENKINS-51397 Jenkins / JENKINS-51397 docker login being called without server-related environment variables Change By: Jesse Glick Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title Jesse Glick started work on JENKINS-51397 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title
Nico Navarrete commented on JENKINS-51397
Re: docker login being called without server-related environment variables
This works with
docker-plugin
1.1.4
docker-workflow
1.15.1
but not with
docker-plugin
1.1.4
docker-workflow
1.6
// run from base dir for folder builds and from tmp for url builds
dir ("$runPwd") {
echo "Build with server ${env.DOCKER_HOST} and registry ${env.CP_DOCKER_RELEASE}"
docker.withServer(env.DOCKER_HOST) {
docker.withRegistry(env.CP_DOCKER_RELEASE,env.DOCKER_CREDENTIALS ){
echo "Execute docker build -t $name:$version $params"
sh "docker build -t $name:$version $params"
// def image = docker.build ("$name:$version", params)
}
}
}
[JIRA] (JENKINS-51397) docker login being called without server-related environment variables
Title: Message Title Jesse Glick created an issue Jenkins / JENKINS-51397 docker login being called without server-related environment variables Issue Type: Bug Assignee: Jesse Glick Components: docker-commons-plugin, docker-workflow-plugin Created: 2018-05-17 15:27 Priority: Critical Reporter: Jesse Glick Split out from JENKINS-38018. The environment variables set by withDockerServer are not being passed to the docker login command. Add Comment This message was sent by Atlassian JIRA (v7.3.0#7
