[JIRA] (JENKINS-53197) Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125
Title: Message Title Karl Shultz updated JENKINS-53197 As described above. Jenkins / JENKINS-53197 Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125 Change By: Karl Shultz Status: In Review Resolved Resolution: Done Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53197) Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125
Title: Message Title Karl Shultz commented on JENKINS-53197 Re: Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125 1798 has been reviewed, passes in CI, and is now merged. Closing issue. Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53197) Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125
Title: Message Title Karl Shultz updated JENKINS-53197 Jenkins / JENKINS-53197 Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125 Change By: Karl Shultz Status: In Progress Review Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53197) Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125
Title: Message Title Karl Shultz commented on JENKINS-53197 Re: Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125 PR 1798 is up. Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53197) Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125
Title: Message Title Karl Shultz updated an issue Jenkins / JENKINS-53197 Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125 Change By: Karl Shultz Summary: Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core > 2.125 Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53197) Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core >2.125
Title: Message Title Karl Shultz started work on JENKINS-53197 Change By: Karl Shultz Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53197) Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core 2.125
Title: Message Title Karl Shultz created an issue Jenkins / JENKINS-53197 Make AbstractRunImplTest#queuedSingleNode compatible with Jenkins core 2.125 Issue Type: Improvement Assignee: Karl Shultz Components: blueocean-plugin Created: 2018-08-22 20:23 Labels: cb-triaged Priority: Minor Reporter: Karl Shultz Summary The test queuedSingleNode , in blueocean-pipeline-api-impl, fails if run in such a way that a version of Jenkins core greater than 2.125 is in use. This can happen if the developer switches jenkins.version in pom.xml. Here's what's going on. 1. This change introduced quotes around node labels. 2. You can also see here that the change went in around jenkins-2.125: 3. This assert fails, because it's looking for a string that doesn't contain those quotes. 4. Blue Ocean builds, done via something like mvn clean install, choose what version of Jenkins to run with via jenkins.version in pom.xml. And other approaches like the ATH, use the jenkins/jenkins:lts docker image. That docker image is running 2.121.3, meaning, it doesn't have the quotation marks change. 5. That means we'd have never seen this issue before. The test is written for an older version of Jenkins, and since Blue Ocean intentionally builds against an older version of Jenkins that predates the quotes change, the test passes. I'm working on a different sort of Assert, which will allow the new way and the old way.
