[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Michael Kriese edited a comment on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit This can be closed as fixed with docker-workflow-plugin 1.19 and pipeline-model-definition-plugin 1.4.0 (not yet released)https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/350 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196741.1547472484000.1144.1568189640385%40Atlassian.JIRA.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Michael Kriese commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit This can be closed as fixed with docker-workflow-plugin 1.19 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196741.1547472484000.1137.1568188981203%40Atlassian.JIRA.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Peter Niederlag commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit anyone in on this? As BUILDKIT provides way better handling of secrets it should really be possible to use this on jenkins. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196741.1547472484000.3971.1562577420633%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Peter Niederlag updated an issue Jenkins / JENKINS-55577 docker agent using a custom Dockerfile is broken with docker buildkit Change By: Peter Niederlag Priority: Minor Major Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196741.1547472484000.3952.1562577361542%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Fabian Grutschus commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit buildctl has the option --export-cache=mode=max, which seems to export all layers when running Buildkit. It seems there is no way to pass this option within docker build or by an environment variable. Unfortunately I can't test it by myself, since I can't build Builkit from the repository. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Thomas Riccardi commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit Parsing the output of buildkit is ambitious: it changes (new buildkit v0.5.0 changed it for example, but not the part that would interest us...). I'm not sure it's a robust way to do it, but I don't see another way to do it (ideally buildkit should give us a structured build report, but I don't think this exists...) Anyway, buildkit is used more and more, maybe the priority of this issue should be increased? Is there a maintainer somewhere? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Fabian Grutschus edited a comment on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit That true. So the only option would be to get the sha256 from the output and pull the image by it that digest? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Fabian Grutschus commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit That true. So the only option would be to get the sha256 from the output and pull the image by it that digest? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Thomas Riccardi commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit Valentin Delaye This would be vulnerable to race-conditions: what if the image changed between the two actions ? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Fabian Grutschus commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit Instead of removing the functionality we just need to pull the last used image explicit before running docker build? Correct? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Valentin Delaye edited a comment on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit Same issue for us Jenkins 2.164.1 and docker-workflow-plugin version: 1.17 and docker 18.09.3 with buildkit ``` {code} [Pipeline] End of Pipeline java.io.IOException: Cannot retrieve .Id from 'docker inspect ubuntu:18.04' ``` {code} Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Valentin Delaye commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit Same issue for us Jenkins 2.164.1 and docker-workflow-plugin version: 1.17 and docker 18.09.3 with buildkit ``` [Pipeline] End of Pipeline java.io.IOException: Cannot retrieve .Id from 'docker inspect ubuntu:18.04' ``` Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Thomas Riccardi commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit As a workaround, I simply disabled the whole function that tried to collect the base image id: https://github.com/Deepomatic/docker-workflow-plugin/commit/826b06d2188b01f9a91be5130bb9eec30831c731 It's OK for me as I don't use any of these jenkins collected metadata; it should not be merged. I pushed the .hpi file I built there: https://github.com/Deepomatic/docker-workflow-plugin/releases/tag/deepomatic-docker-workflow-1.18-SNAPSHOT Built using these commands: docker run -it --rm -v $PWD:/app -v $PWD/.m2:/root/.m2 maven:3-jdk-8 bash cd /app mvn -DskipTests clean install # result at ls .m2/repository/org/jenkins-ci/plugins/docker-workflow/1.18-SNAPSHOT/docker-workflow-1.18-SNAPSHOT.hpi No issue encountered since we deployed that version more than a month ago. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Konstantin Shcherban commented on JENKINS-55577 Re: docker agent using a custom Dockerfile is broken with docker buildkit Faced the same issue. jenkins version: 2.138.1 docker engine version: 18.09.2, API version: 1.39, Git commit: 6247962 docker-workflow-plugin version: 1.17 Following step fails docker.withRegistry(registry) { docker.build(image_repo + ":$tag", '-f docker/Dockerfile .').push() docker.image(image_repo + ":$tag").push(shortTag) } Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55577) docker agent using a custom Dockerfile is broken with docker buildkit
Title: Message Title Thomas Riccardi created an issue Jenkins / JENKINS-55577 docker agent using a custom Dockerfile is broken with docker buildkit Issue Type: Bug Assignee: Unassigned Components: docker-workflow-plugin Created: 2019-01-14 13:28 Environment: ubuntu 16.04 docker 18.09.0 jenkins 2.150.1 docker-workflow-plugin 1.17 Labels: docker Priority: Minor Reporter: Thomas Riccardi When enabling buildkit in docker (either via `/etc/docker/daemon.json` or a global env var in jenkins: DOCKER_BUILDKIT=1), the job fails just after building the docker image used for the agent: https://jenkins.io/doc/book/pipeline/docker/#dockerfile [Pipeline] // stage [Pipeline] withEnv [Pipeline] { [Pipeline] stage [Pipeline] { (Declarative: Agent Setup) [Pipeline] isUnix [Pipeline] readFile [Pipeline] sh [workspace] Running shell script + docker build -t -f Dockerfile . ... buildkit logs ... [Pipeline] dockerFingerprintFrom [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] End of Pipeline java.io.IOException: Cannot retrieve .Id from 'docker inspect ubuntu:18.04' at org.jenkinsci.plugins.docker.workflow.client.DockerClient.inspectRequiredField(DockerClient.java:220) at org.jenkinsci.plugins.docker.workflow.FromFingerprintStep$Execution.run(FromFingerprintStep.java:133) at org.jenkinsci.plugins.docker.workflow.FromFingerprintStep$Execution.run(F