[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Daniel Spilker closed an issue as Fixed Jenkins / JENKINS-33482 Git scm option "Create tag for each build" is activated by default for oneliner syntax Change By: Daniel Spilker Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title SCM/JIRA link daemon commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax Code changed in jenkins User: Daniel Spilker Path: job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/ScmContextSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/f68c860066bdf570432bc36981760f11c391fe55 Log: Merge pull request #786 from ldez/ JENKINS-33482 JENKINS-33482 enhance Git one-liner test Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/aa04e510af4a...f68c860066bd Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title SCM/JIRA link daemon commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax Code changed in jenkins User: Daniel Spilker Path: docs/Home.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ScmContext.groovy http://jenkins-ci.org/commit/job-dsl-plugin/cb854277fb46e147bde0e13a3b3388df50277ae2 Log: enhanced documentation for the Git plugin [FIXES JENKINS-33482] Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title SCM/JIRA link daemon resolved as Fixed Jenkins / JENKINS-33482 Git scm option "Create tag for each build" is activated by default for oneliner syntax Change By: SCM/JIRA link daemon Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title SCM/JIRA link daemon commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax Code changed in jenkins User: Daniel Spilker Path: docs/Home.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ScmContext.groovy http://jenkins-ci.org/commit/job-dsl-plugin/aa04e510af4a08dd4f23a492bf1a208f808cc864 Log: Merge pull request #785 from daspilker/ JENKINS-33482 JENKINS-33482 enhanced documentation for the Git plugin Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/5d924941836f...aa04e510af4a Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Daniel Spilker commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax Changing the behavior will introduce an incompatibility for users who rely on this feature. In version 1.x of the Git plugin, creating a tag for each build was the default behavior and Job DSL enables this explicitly to maintain compatibility with 1.x. See https://github.com/jenkinsci/job-dsl-plugin/commit/4c1ca921fdfbd055dcdf72d2f578a1cc7a7000f1. But when using Git plugin 2.x, this behavior is unexpected. So it should be mentioned in the docs. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax fix : https://github.com/jenkinsci/job-dsl-plugin/pull/783 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Geoffroy Jabouley commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax I can manage the PR on monday, if you're ok with the fix: remove L183 to L185 of ScmContext.groovy What about extending a little bit the checks on test case "call git scm methods" to ensure defaults values for all fields? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez edited a comment on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax With 0.43 & 0.44:- reproduce with Jenkins Job DSL Playground (http://job-dsl.herokuapp.com/)- reproduce with Jenkins ver. 1.642.1- not reproduce `./gradlew run -Pargs=job.dsl` Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez edited a comment on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax I'm trying with 0.44:- not reproduce with tests or `./gradlew run -Pargs=job.dsl` With 0.43 & 0.44 :- reproduce with Jenkins Job DSL Playground (http://job-dsl.herokuapp.com/)- reproduce with Jenkins ver. 1.642.1- but not reproduce with tests or `./gradlew run -Pargs=job.dsl` Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax ScmContext.groovy#L184 it's the problem, you're right Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez edited a comment on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax GitContext.groovy#L118 : it's the default value if the method is call but it's not call.ScmContext.groovy#L184 : It think not call in the test, it's the problem strange Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Geoffroy Jabouley commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax Thanks for your answers the test case "call git scm methods" does not seem to check anything but the remote and branch fields. https://github.com/jenkinsci/job-dsl-plugin/blob/master/job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/ScmContextSpec.groovy#L1173 But i'm not familiar with groovy testing. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez edited a comment on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax GitContext.groovy#L118 : it's the default value if the method is call but it's not call.ScmContext.groovy#L184 : like I say tests work properly, code is correct It think it's the problem Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax GitContext.groovy#L118 : it's the default value if the method is call but it's not call. ScmContext.groovy#L184 : like I say tests work properly, code is correct Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Geoffroy Jabouley edited a comment on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax Maybe the default value shall be set to false here:https://github.com/jenkinsci/job-dsl-plugin/blob/master/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/scm/GitContext.groovy#L118 Or this line is wrong:https://github.com/jenkinsci/job-dsl-plugin/blob/master/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ScmContext.groovy#L184 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Geoffroy Jabouley commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax Maybe the default value shall be set to false here: https://github.com/jenkinsci/job-dsl-plugin/blob/master/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/scm/GitContext.groovy#L118 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez edited a comment on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax I'm trying with 0.44:- not reproduce with tests or `./gradlew run -Pargs=job.dsl`With 0.43:- but not reproduce with tests or `./gradlew run -Pargs=job.dsl`- reproduce with Jenkins Job DSL Playground (http://job-dsl.herokuapp.com/)- reproduce with Jenkins ver. 1.642.1 - but not reproduce with tests or `./gradlew run -Pargs=job.dsl` Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez edited a comment on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax I'm trying with 0.44:- not reproduce with Jenkins Job DSL Playground (http: tests or `. / /job gradlew run - Pargs=job. dsl `With 0 . herokuapp.com/) 43: - but not reproduce with tests or `./gradlew run -Pargs=job.dsl` With 0.43 - reproduce with Jenkins Job DSL Playground (http : //job-dsl.herokuapp.com/) - reproduce with Jenkins ver. 1.642.1 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez edited a comment on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax I'm trying with 0.44 :- Reproduce reproduce with Jenkins Job DSL Playground (http://job-dsl.herokuapp.com/)- But but not reproduce with tests or `./gradlew run -Pargs=job.dsl` With 0.43:- reproduce with Jenkins ver. 1.642.1 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title Ludovic Fernandez commented on JENKINS-33482 Re: Git scm option "Create tag for each build" is activated by default for oneliner syntax I'm trying with 0.44 : Reproduce with Jenkins Job DSL Playground (http://job-dsl.herokuapp.com/) But not reproduce with tests or `./gradlew run -Pargs=job.dsl` Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-33482) Git scm option "Create tag for each build" is activated by default for oneliner syntax
Title: Message Title
Geoffroy Jabouley created an issue
Jenkins / JENKINS-33482
Git scm option "Create tag for each build" is activated by default for oneliner syntax
Issue Type:
Bug
Assignee:
Daniel Spilker
Components:
job-dsl-plugin
Created:
11/Mar/16 1:57 PM
Environment:
jenkins 1.596.3 LTS job-dsl plugin 1.39 git plugin 2.4.0
Priority:
Major
Reporter:
Geoffroy Jabouley
scm {
git {
remote {
url ('ssh://blabla')
}
}
}
set by defaut option "Create Tags for each build" to false (true in the build.xml)
scm {
git ('ssh://blabla')
}
Activates the option by default (false in the build.xml)
Unless specified, i think the option shall be deactivated by default for all syntaxes.
