[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Alex Earl commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification I submitted a pull request for "fixing" this. https://github.com/jenkinsci/mailer-plugin/pull/11 I'm also planning on making a pull request for the Mercurial plugin that would create user accounts a little differently. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Your test case is reproducible but it does not really tell us anything, because the malformed culprits are simply being copied from earlier builds (#2 #5). What is needed is a test case which demonstrates fresh additions to the culprits list with the malformed names; specifically the call stack of User.init with an incorrect fullName. Note that the Mercurial changelog.xml in these builds show the correct text. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Alex Earl commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification @Jesse, I agree it should be calling it with the 's, but I think because of this code in AbstractBuild.java, it will call it with the _'s https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/AbstractBuild.java#L729 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Still working on reproducing from scratch. I think I may see what the issue is. If I am right, it is a bug in core as I suspected on Dec 19. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Alex Earl commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Could this have anything to do with this code? https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/AbstractBuild.java#L728 It's using String's instead of User's This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Alex Earl commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification I think this code in Mailer could be an issue as well. https://github.com/jenkinsci/mailer-plugin/blob/41de8d6ada29693073b2c122a367be112ae55663/src/main/java/hudson/tasks/MailAddressResolver.java#L137 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
cowwoc
updated JENKINS-16332
Leading and trailing underscores are added to commiters email address, unable to send build notification
Guys,
I've managed to produce a minimal testcase for this bug.
Extract testcase.zip into $JENKINS_HOME/jobs
Run the job
You should get this output:
Started by user Gili Tzabari
[EnvInject] - Loading node environment variables.
Building remotely on MacOS X 10.8 in workspace /Users/builds/.jenkins/workspace/Test
[Test] $ /usr/local/bin/hg showconfig paths.default
ERROR: Workspace reports paths.default as https://bbs.darktech.org/code/test/
which looks different than https://cow...@bitbucket.org/cowwoc/test
so falling back to fresh clone rather than incremental update
$ /usr/local/bin/hg clone --rev default --noupdate https://cow...@bitbucket.org/cowwoc/test /Users/builds/.jenkins/workspace/Test
adding changesets
adding manifests
adding file changes
added 19 changesets with 19 changes to 2 files
[Test] $ /usr/local/bin/hg update --rev default
2 files updated, 0 files merged, 0 files removed, 0 files unresolved
[Test] $ /usr/local/bin/hg log --rev . --template {node}
[Test] $ /usr/local/bin/hg log --rev . --template {rev}
[Test] $ /usr/local/bin/hg log --rev 6ddb7626f1d05f3e67a4c92fa255ba32a5406020
changeset: 18:6ddb7626f1d0
tag: tip
user:Getcho Getchev getcho.getc...@gmail.com
date:Fri Feb 21 23:40:41 2014 +0200
summary: added line 10
[Test] $ /usr/local/bin/hg log --template "changeset node='{node}' author='{author|xmlescape}' rev='{rev}' date='{date}'msg{desc|xmlescape}/msgadded{file_adds|stringify|xmlescape}/addeddeleted{file_dels|stringify|xmlescape}/deletedfiles{files|stringify|xmlescape}/filesparents{parents}/parents/changeset\n" --rev default:0 --follow --prune 6ddb7626f1d05f3e67a4c92fa255ba32a5406020 --encoding UTF-8 --encodingmode replace
[Test] $ /bin/sh -xe /var/folders/ht/zq3sdm6s55j4cv6gvjtkc8vmgp/T/hudson4438504154854395225.sh
+ ./test.sh
/var/folders/ht/zq3sdm6s55j4cv6gvjtkc8vmgp/T/hudson4438504154854395225.sh: line 2: ./test.sh: No such file or directory
Build step 'Execute shell' marked build as failure
Invalid address: Getcho Getchev _getcho.getchev@gmail.com_
Invalid address: Gili Tzabari _gili.tzabari@gmail.com_
An attempt to send an e-mail to empty list of recipients, ignored.
Finished: FAILURE
Change By:
cowwoc
(23/Feb/14 6:05 AM)
Attachment:
testcase.zip
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
toomasr edited a comment on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Experiencing similar problem. Unable to send out the emails to the build failed culprits. I went checked out the relevant code in Jenkins, Mercurial plugin and the Mailer plugin. Here is my understanding based on the read source code: Mercurial states that the author format is FirstName LastName email@address ( see http://www.selenic.com/mercurial/hgrc.5.html ) Now the mercurial plugin sees the author part with that format and asks Jenkins to get a user or create one by indirectly invoking https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/User.java#L298 During the creation Jenkins will introduce some replacing ( https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/jenkins/model/DefaultUserCanonicalIdResolver.java#L44 ) and all and turn into underscores. And now we've created a Jenkins user FirstName LastName email@address. Not sure why we want to do this but probably a good thing for later to pick up the culprits. Now a build fails and Mailer plugin asks Jenkins to give him the culprits. Jenkins has recorded those users for the build and provides the list of FirstName Lastname email@address users. Now Mailer asks for the addresses of the users but as those are empty it will use a MailAddressResolver ( https://github.com/jenkinsci/mailer-plugin/blob/master/src/main/java/hudson/tasks/MailAddressResolver.java#L100 - there is a specific subclass for Subversion also but didn't sis Mercurial) and it will do some magic but probably fails because Mailer still tries to send to FirstName Lastname email@address. I see couple of options here Mailer plugin(s) to detect the emails better when none is defined Mercurial plugin will do the email address extraction itself, as it knows the format and will then set explicitly the email addresses for the users it creates Mercurial plugin will create the user with the email address instead of the FirstName LastName email@address format. In this case any dark magic that does email address extraction from user id might succeed. Any holes in my logic? Anyone wants to take crack at it? I'm off to vacation without a laptop This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
toomasr edited a comment on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Experiencing similar problem. Unable to send out the emails to the build failed culprits. I went checked out the relevant code in Jenkins, Mercurial plugin and the Mailer plugin. Here is my understanding based on the read source code: Mercurial states that the author format is FirstName LastName email@address ( see http://www.selenic.com/mercurial/hgrc.5.html ) Now the mercurial plugin sees the author part with that format and asks Jenkins to get a user or create one by indirectly invoking https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/User.java#L298 During the creation Jenkins will introduce some replacing ( https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/jenkins/model/DefaultUserCanonicalIdResolver.java#L44 ) and all and turn into underscores. And now we've created a Jenkins user FirstName LastName email@address. Not sure why we want to do this but probably a good thing for later to pick up the culprits. Now a build fails and Mailer plugin asks Jenkins to give him the culprits. Jenkins has recorded those users for the build and provides the list of FirstName Lastname email@address users. Now Mailer asks for the addresses of the users but as those are empty it will use a MailAddressResolver ( https://github.com/jenkinsci/mailer-plugin/blob/master/src/main/java/hudson/tasks/MailAddressResolver.java#L100 - there is a specific subclass for Subversion also but didn't sis Mercurial) and it will do some magic but probably fails because Mailer still tries to send to FirstName Lastname email@address. I see couple of options here Mailer plugin(s) to detect the emails better when none is defined Mercurial plugin will do the email address extraction itself, as it knows the format and will then set explicitly the email addresses for the users it creates Mercurial plugin will create the user with the email address instead of the FirstName LastName email@address format. In this case any dark magic that does email address extraction from user id might succeed. Any holes in my logic? Anyone wants to take crack at it? I'm off to vacation without a laptop This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
cowwoc commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Jesse, I am now 100% I am seeing: Jan 08, 2014 6:36:06 PM FINE hudson.model.User hudson.model.User$FullNameIdResolver@934e9b mapped First Last _first.last@gmail.com_ to First Last _first.last@gmail.com_ without: [JENKINS-16332] Suspicious fullName being stored: First Last _first.last@gmail.com_ ever being logged. It looks like you'll need to add more aggressive logging for us to track this down. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification If that never gets logged, and you are still unsure how to reproduce the problem, then I am out of ideas for the moment. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick
commented on JENKINS-16332
Leading and trailing underscores are added to commiters email address, unable to send build notification
@cowwoc so something called
User.get("First Last _first.last@gmail.com_")
which is OK, but there was already a User which had that not only as an id but also as a fullName, which is wrong. The question is how and when that User got created, which this log snippet does not indicate. To learn that, we would need an (earlier) log message starting with
[JENKINS-16332] Suspicious fullName being stored: First Last _first.last@gmail.com_
which includes a stack trace possibly indicating the culprit.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
cowwoc commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification I didn't see such a log entry but I will keep my eye open if this happens again. Mail-Ext just committed an interesting bugfix: https://issues.jenkins-ci.org/browse/JENKINS-20215 Do you think this could have been at fault? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
cowwoc edited a comment on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification I didn't see such a log entry but I will keep my eye open if this happens again. The EMail-ext plugin just fixed an interesting bug: https://issues.jenkins-ci.org/browse/JENKINS-20215 Do you think this could have been at fault? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Offhand I would guess that is not related. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
cowwoc commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Okay, so to reiterate, I did not see [JENKINS-16332] Suspicious fullName being stored: First Last _first.last@gmail.com_ in the log file even though the problem occurred. Doesn't that imply that we need to add more logs? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Doesn't that imply that we need to add more logs? Not necessarily; you might have turned on logging after this user record ($JENKINS_HOME/users/*.xml) was created with the faulty information. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
cowwoc commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification @Jesse, I enabled this log a few weeks ago, so that's unlikely. That being said, the log did seem pretty short (2 pages long). Does Jenkins truncate the log on startup? Does it begin logging automatically or do I need to intervene manually every startup? Does it log to disk or just to memory? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification The log displayed in /log/all is just the last hundred or so messages in memory (since Jenkins was started). Depending on how you launch Jenkins, typically a log file will be written somewhere to disk. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification And custom loggers are normally not written to disk at all. I have an unreleased change in the Support Core plugin which writes custom logs to a location inside the Jenkins home dir (rotated after restart). Plan to release that update soonish. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
cowwoc commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Jesse, I triggered a build that failed, and tried emailing the author: Invalid address: First Last _first.last@gmail.com_ I opened the logger and saw these two lines: Jan 08, 2014 6:36:06 PM FINE hudson.model.User hudson.model.User$FullNameIdResolver@934e9b mapped First Last _first.last@gmail.com_ to First Last _first.last@gmail.com_ Jan 08, 2014 6:36:06 PM FINE hudson.model.User hudson.model.User$FullNameIdResolver@934e9b mapped First Last _first.last@gmail.com_ to First Last _first.last@gmail.com_ (I've replaced the person's actual name with "First Last" but the rest of the log is identical) Does this help? Where do we go from here? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
cowwoc commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Jesse, I just reproduced the problem. Unfortunately I didn't have the logger enabled so we missed an opportunity. I did notice something very interesting though: 1. A build failed and tried to send an email to an auto-generated user with underscores 2. I went into Jenkins - People and sure enough the user's email address had underscores 3. I rebooted Jenkins and went into Manage Jenkins - Manage Users and all of a sudden that same user no longer had underscores in the email address. It's not clear whether the reboot or Manage Users fixed the email address, but that's another clue of what's going on. I've enabled the logger, so the next time this happens I will catch it. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification If you figure out how to reproduce it from scratch then I can fix it. I am pretty sure the problem somehow lies with a userId getting passed from one place to another without a User context, and then Jenkins serializing the user record at the wrong time, but I do not know the sequence of events that makes this happen to some people some times. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification @jgoodspeed it helps if you can reproduce the problem and are willing to run the logger (FINE in hudson.model.User). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jim Goodspeed commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification If it helps I am also seeing this using 1.537 on Windows with RTC as my SCM tool along with the email-ext plugin. Editing the people (these are not real users, they are picked up from SCM changes) to fix the email address seems to fix the issue for a short period of time, but the records are being updated again intermittently. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jerry Maloney commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification I believe there may be an issue in MercurialChangeLogParser method MercurialChangeSetList parse(AbstractBuild build, File changelogFile). If I pass in a changelog that looks like the following: changelog.xml ?xml version='1.0' encoding='UTF-8'? changesets changeset author='joe.schmo lt;joe.sc...@example.comgt;'/ !-- note that those escape characters are on purpose and not some relic of posting in Jira -- /changesets I get a changeset author with the ID and fullname "joe.schmo joe.sc...@example.com", which is the error reported in this ticket. I believe the Digester class from Apache Commons is taking the escaped XML characters in the changesets/changeset/@author attribute and rendering them as underscores. I pushed a unit test showing this to my fork of mercurial-plugin, but not requesting a pull because I don't have a fix yet. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Sergey Grigoriev commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification The problem persists in 1.519. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Peter Becker edited a comment on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification We are using Mercurial as well, having normal looking commits on that end. Jenkins 1.506 adds underscores to some but not all email addresses. In one build two out of three email addresses failed. They all look the same in hg, the one big different is that the two failing ones belong to users with Jenkins accounts, the one that works belongs to a user that never created a Jenkins account. The user profiles in the Jenkins installation look fine, the addresses in there seem to be ok. The person that gets the build notification does not have a profile at all. One thing we noticed is that there are two additional user profiles in the file system that follow the pattern FirstName LastName email@address as folder names. These are about a month old now and belong to other users, both of which have a normal profile as well. I don't know if that is related somehow. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Peter Becker commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Upgrading to 1.509.1 seems to have resolved this issue for us. The one thing we did notice while looking at this is that it was not actually just adding underscores to the email addresses, it was using the whole Mercurial username with the lesser than/greater than symbols replaced. For example Peter Becker pbec...@example.com should have turned into pbec...@example.com but resulted in Peter Becker pbec...@example.com being used as email address. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Peter Becker commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification We are using Mercurial as well, having normal looking commits on that end. Jenkins 1.506 adds underscores to some but not all email addresses. In one build two out of three email addresses failed. They all look the same in hg, the one big different is that the two failing ones belong to users with Jenkins accounts, the one that works belongs to a user that never created a Jenkins account. The user profiles in the Jenkins installation look fine, the addresses in there seem to be ok. The person that gets the build notification does not have a profile at all. One thing we noticed is that there are two additional user profiles in the file system that follow the pattern "FirstName LastName email@address" as folder names. These are about a month old now and belong to other users, both of which have a normal profile as well. I don't know if that is related somehow. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Paul Wilkinson commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification We are also using Mercurial and have the same problem. We log in to Jenkins to run jobs. IT has asked us to turn off email notifications because the bad email addresses are choking our servers. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
wee thomas commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification I should also indicate that my manual access of Jenkins is anonymous. While I've created accounts for all users in SCM, I don't actually login to Jenkins when making changes, manually triggering builds, etc. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
wee thomas commented on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification I've been experiencing this issue as well. I found that it occurs with my build-pipeline. Initially, a clone is made from an Hg repository. This then kicks off a build of the source. If successful, I archive the workspace and then I trigger another job (to run lint). This downstream job uses the saved successful workspace. I've noticed that when I manually trigger builds within Jenkins, at that point, the email gets screwed up. This occurs with a fresh (1.514) Jenkins build with only the Mercurial and Clone Workspace plugins installed. This occurs whether I do it on the initial build job or the downstream lint job. I'd been doing this (triggering builds manually) to test job configuration. My current workaround is to make a small comment change in my source, commit and push. Both jobs have email user who broke the build as a post-build step. I didn't experience this bug when experimenting with build configurations using a project on a subversion repository. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
wee thomas edited a comment on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification I've been experiencing this issue as well. I found that it occurs with my build-pipeline. Initially, a clone is made from an Hg repository. This then kicks off a build of the source. If successful, I archive the workspace and then I trigger another job (to run lint). This downstream job uses the saved successful workspace. I've noticed that when I manually trigger builds within Jenkins, at that point, the email gets screwed up. This occurs with a fresh (1.514) Jenkins build with only the Mercurial and Clone Workspace plugins installed. This occurs whether I do it on the initial build job or the downstream lint job. I'd been doing this (triggering builds manually) to test job configuration. My current workaround is to make a small comment change in my source, commit and push. Both jobs have email user who broke the build as a post-build step. I didn't experience this bug when experimenting with build configurations using a project on a subversion repository. To fix the phantom invalid user which Jenkins then recognizes for future SCM changes, I have to delete history of all builds that involve that user (if the build was successful, all jobs builds that it triggered), then restart Jenkins. At this point, the invalid user disappears and I can proceed. The other option is to just clone the jobs, then delete the old ones and rename them back. The downside of both approaches is that you lose a bit (or a lot) of build history. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
wee thomas edited a comment on JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification I've been experiencing this issue as well. I found that it occurs with my build-pipeline. Initially, a clone is made from an Hg repository. This then kicks off a build of the source. If successful, I archive the workspace and then I trigger another job (to run lint). This downstream job uses the saved successful workspace. I've noticed that when I manually trigger builds within Jenkins, at that point, the email gets screwed up. This occurs with a fresh (1.514) Jenkins build with only the Mercurial and Clone Workspace plugins installed. This occurs whether I do it on the initial build job or the downstream lint job. I'd been doing this (triggering builds manually) to test job configuration. My current workaround is to make a small comment change in my source, commit and push. Both jobs have email user who broke the build as a post-build step. I didn't experience this bug when experimenting with build configurations using a project on a subversion repository. To fix the phantom invalid user which Jenkins then recognizes for future SCM changes, I have to delete history of all builds that involve that user (if the build was successful, all jobs builds that it triggered), then restart Jenkins. At this point, the invalid user disappears and I can proceed. The other option is to just clone the jobs, then delete the old ones and rename them back (still requires a restart after this). The downside of both approaches is that you lose a bit (or a lot) of build history. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [mailer] (JENKINS-16332) Leading and trailing underscores are added to commiters email address, unable to send build notification
Jesse Glick updated JENKINS-16332 Leading and trailing underscores are added to commiters email address, unable to send build notification Setting component to mailer based on comment suggesting that the extraction of the email resolver to a separate plugin somehow triggered this bug. Change By: Jesse Glick (07/May/13 3:02 PM) Component/s: mailer Component/s: core This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
