[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
teilo updated JENKINS-18895 MavenModuleSetBuild.getResult is expensive Change By: teilo (02/Aug/13 12:15 PM) Labels: lazy-loading lts-candidate performance This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
dogfood commented on JENKINS-18895 MavenModuleSetBuild.getResult is expensive Integrated in jenkins_main_trunk #2769 Result = UNSTABLE This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
SCM/JIRA link daemon resolved JENKINS-18895 as Fixed MavenModuleSetBuild.getResult is expensive Change By: SCM/JIRA link daemon (30/Jul/13 3:18 AM) Status: Reopened Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
SCM/JIRA link daemon commented on JENKINS-18895 MavenModuleSetBuild.getResult is expensive Code changed in jenkins User: Jesse Glick Path: maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java http://jenkins-ci.org/commit/jenkins/ec9b4f11866e80ae4a432b9127e71afddf30de86 Log: [FIXED JENKINS-18895] Refined fix once again. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
Jesse Glick reopened JENKINS-18895 MavenModuleSetBuild.getResult is expensive Some test failures, need to diagnose. Change By: Jesse Glick (30/Jul/13 2:49 AM) Resolution: Fixed Status: Resolved Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
dogfood commented on JENKINS-18895 MavenModuleSetBuild.getResult is expensive Integrated in jenkins_main_trunk #2765 Result = UNSTABLE This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
SCM/JIRA link daemon commented on JENKINS-18895 MavenModuleSetBuild.getResult is expensive Code changed in jenkins User: Jesse Glick Path: maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java http://jenkins-ci.org/commit/jenkins/8d46aa6d976f5b0d89a4ad4969d455cd3a4add5c Log: JENKINS-18895 Refined fix to not cache status during the build. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
dogfood commented on JENKINS-18895 MavenModuleSetBuild.getResult is expensive Integrated in jenkins_main_trunk #2763 [FIXED JENKINS-18895] MavenModuleSetBuild.getResult is expensive. (Revision d1d524863cbb2f1f443fc4bf7c25933b7a31b85d) Result = UNSTABLE Jesse Glick : d1d524863cbb2f1f443fc4bf7c25933b7a31b85d Files : test/src/test/java/hudson/maven/MavenBuildSurefireFailedTest.java changelog.html maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java test/src/main/java/org/jvnet/hudson/test/RunLoadCounter.java This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
SCM/JIRA link daemon commented on JENKINS-18895 MavenModuleSetBuild.getResult is expensive Code changed in jenkins User: Jesse Glick Path: changelog.html maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java test/src/main/java/org/jvnet/hudson/test/RunLoadCounter.java test/src/test/java/hudson/maven/MavenBuildSurefireFailedTest.java http://jenkins-ci.org/commit/jenkins/d1d524863cbb2f1f443fc4bf7c25933b7a31b85d Log: [FIXED JENKINS-18895] MavenModuleSetBuild.getResult is expensive. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
SCM/JIRA link daemon resolved JENKINS-18895 as Fixed MavenModuleSetBuild.getResult is expensive Change By: SCM/JIRA link daemon (29/Jul/13 8:06 PM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [maven] (JENKINS-18895) MavenModuleSetBuild.getResult is expensive
Jesse Glick created JENKINS-18895 MavenModuleSetBuild.getResult is expensive Issue Type: Bug Assignee: Unassigned Components: maven Created: 23/Jul/13 8:50 PM Description: MavenModuleSetBuild.getResult looks for the worst result of any of the last builds of the component modules. If you are using Maven 2, some of these might have been run after the MavenModuleSetBuild itself completed, either because you build modules in parallel, or because you manually rebuilt one of the modules; in such cases the result of the module set can be retroactively worsened. (Although Run.setResult is only permitted while building, getResult is nonfinal, effectively a backdoor to get around that restriction.) Besides the logical confusion over whether a given build of a job was successful or not, this logic is very problematic for lazy-loading: at jenkins.model.lazy.AbstractLazyLoadRunMap.search(AbstractLazyLoadRunMap.java:496) at hudson.model.AbstractProject.getNearestOldBuild(AbstractProject.java:1067) at hudson.maven.MavenModuleSetBuild.getModuleLastBuilds(MavenModuleSetBuild.java:434) at hudson.maven.MavenModuleSetBuild.getResult(MavenModuleSetBuild.java:189) at hudson.model.PermalinkProjectAction$Permalink$3.apply(PermalinkProjectAction.java:134) at jenkins.model.PeepholePermalink.resolve(PeepholePermalink.java:95) at hudson.model.Job.getLastSuccessfulBuild(Job.java:802) For example, every time the Maven job is displayed in a view, getResult is called at least once for the icon color. (Probably also to verify the permalink even when the symlink such as lastSuccessfulBuild exists, which after JENKINS-16023 it should.) But this forces the most recent build of each module to be loaded, too, and if there are a lot of modules that can take significant time, either after startup or after some have been evicted from memory. Not clear what can be done here. Options: Delete this override and break functional compatibility. Means that jobs using parallel module building will not show meaningful status. Suppress the override in case the job is currently configured to use Maven 3, which does not support the trigger conditions to begin with. But it is not trivial to tell this; a MavenInstallation will resolve to a specific version only during a build (it might not exist at all on the master). Store the current effective result in build.xml and use some listener to update it after relevant module builds. Project: Jenkins Labels: performance lazy-loading Priority: Major Reporter: Jesse Glick This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
