Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-11-13 Thread Michael Neale
Hrm - I didn't need to do anything like that, no. Unless something has changed since I tried it, I was using a very stock setup with the github plugin etc, and it worked fine if I setup the pipeline as a github source type. On Thu, Nov 14, 2019 at 9:02 AM Craig Rodrigues wrote: > Michael, > > I

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-11-13 Thread Craig Rodrigues
Michael, I tried following your blog post: https://jenkins.io/blog/2019/01/07/webhook-firewalls/ I did the following additional steps not in your blog post using a Jenkins 2.190.2 server: 1. I configured the smee endpoint, https://smee.io/myendpoint 2. I ran the smee client, which just si

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-11-11 Thread Craig Rodrigues
I tried with the trailing slash, and still got a 404 error. I think your blog post is missing details of how to configure the *github-webhook* URL. I think this is configured via this plugin: https://github.com/jenkinsci/github-plugin/ -- Craig On Sun, Nov 10, 2019 at 2:34 PM Michael Neale wrot

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-11-10 Thread Michael Neale
Hi Craig - I think that you need the trailing slash (as per the blog - I seem to recall it was very fickle about that, probably stapler!) On Sat, Nov 9, 2019 at 7:06 AM Craig Rodrigues wrote: > Michael, > > It looks like the smee client has a *--target* option to specify where to > send notifica

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-11-08 Thread Craig Rodrigues
Michael, It looks like the smee client has a *--target* option to specify where to send notifications to: *Usage: smee [options]Options: -v, --version output the version number -u, --url URL of the webhook proxy service. Default: https://smee.io/new

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-10-24 Thread Michael Neale
yeah - as long as it can post the webhook, it can run anywhere it needs to. It is run by github, but not sure of its officially supported status (they also open source the code to it) On Fri, Oct 25, 2019 at 11:10 AM Craig Rodrigues wrote: > Awesome! So I could run the smee client on a separat

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-10-24 Thread Craig Rodrigues
Awesome! So I could run the smee client on a separate physical host, but with network connectivity to my Jenkins server. Both the smee client and the Jenkins server would be behind the firewall. To be cool, I could Dockerize the smee client, and deploy that in my Kubernetes cluster. However, I w

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-10-24 Thread Michael Neale
yeah fair point it doesn't have to be right next to it - but it has to be somewhere it can reach /github-webhook endpoint - so could be a totally separate app? (as long as your Jenkins master instance is discoverable and accessible from elsewhere from the cluster - which I guess it would be right?)

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-10-24 Thread Craig Rodrigues
This seems unnecessarily complicated. Why does the smee client need to be next to the Jenkins server at all? If I was not using Kubernetes, and if I had two separate physical machines, one running Jenkins and one running smee, would it be possible for smee to interact with Jenkins via the REST API

Re: GitHub webhooks, where to put smee client if Jenkins is in a container?

2019-10-24 Thread Michael Neale
Hi Craig, glad that post is getting mileage! So in kubernetes, I guess that would be adding to the pod that is running your Jenkins container: there would be a pod definition (not sure if you wrote it) somewhere, and you could cook up an image with smee running and have it as a "sidecar" next to t