Re: [Jfs-discussion] [PATCH 30/31] ext4: eliminate xattr entry e_hash recalculation for removes

2017-06-19 Thread Jan Kara
On Fri 16-06-17 19:04:44, Tahsin Erdogan wrote: > On Thu, Jun 15, 2017 at 2:10 AM, Jan Kara wrote: > > I agree with moving ext4_xattr_rehash_entry() out of ext4_xattr_rehash(). > > However how about just keeping ext4_xattr_rehash() in > > ext4_xattr_block_set() (so that you don't

Re: [Jfs-discussion] [PATCH 30/31] ext4: eliminate xattr entry e_hash recalculation for removes

2017-06-16 Thread Tahsin Erdogan via Jfs-discussion
On Thu, Jun 15, 2017 at 2:10 AM, Jan Kara wrote: > I agree with moving ext4_xattr_rehash_entry() out of ext4_xattr_rehash(). > However how about just keeping ext4_xattr_rehash() in > ext4_xattr_block_set() (so that you don't have to pass aditional argument > to

Re: [Jfs-discussion] [PATCH 30/31] ext4: eliminate xattr entry e_hash recalculation for removes

2017-06-15 Thread Jan Kara
On Wed 14-06-17 10:23:40, Tahsin Erdogan wrote: > When an extended attribute block is modified, ext4_xattr_hash_entry() > recalculates e_hash for the entry that is pointed by s->here. This is > unnecessary if the modification is to remove an entry. > > Currently, if the removed entry is the last