On 13/08/2014 22:29, Mike Duigou wrote:
:
- modules.xml "Changes to this file will require review by Committers to Project
Jigsaw." Will this be true after integration into jdk9/dev repo?
There's a section in JEP 200 about modules.xml, it is temporary until
there is a module system in place.
There's a lot to review here. This is not a complete review but hopefully
contributes to our review "coverage". I am focusing on the top project in this
set of comments.
- --with-output-sync seems like it should be on by default if available.
Downside? This could also be split out from the jigs
Changeset: 9feef5e086a4
Author:chegar
Date: 2014-08-13 20:07 +0100
URL: http://hg.openjdk.java.net/jigsaw/stage/rev/9feef5e086a4
Revert default JPRT release
! make/jprt.properties
Changeset: 4440ed486012
Author:mr
Date: 2014-08-13 08:50 -0700
URL: http://hg.openjdk.java.net/jigsaw/stage/rev/4440ed486012
Add legal notice to modules.xml
! modules.xml
Thanks for the explanation Erik.
I have taken a pass over the changes, and they look ok to me ( I am
happy to be listed as a reviewer ). I also did several build and test
runs on Solaris, Linux, Max OSX, and Windows. All look good.
I am seeing, in some cases, about a 20% reduction in image bu
On 2014-08-13 14:17, Chris Hegarty wrote:
Thanks for the explanation Erik.
I have taken a pass over the changes, and they look ok to me ( I am
happy to be listed as a reviewer ). I also did several build and test
runs on Solaris, Linux, Max OSX, and Windows. All look good.
I am seeing, in some
Just to add to Chris and Erik's mails, I would encourage everyone that
pushes to jdk9/dev or the other jdk9 project integration forests to
clone and build jigsaw/stage and get familiar with the proposed layout,
new build targets, and the very different output emitted during the
build. The cha
I should probably write something about the rather extensive changes to
the build logic in this patch.
As the source gets organized around modules, it made sense to also
organize the build more around modules. In this patch, the makefiles
have in large parts been split into module specific fil
