RE: jigsaw EA feedback for apache lucene

2015-09-10 Thread Uwe Schindler
Hi, > On 10/09/2015 06:06, Robert Muir wrote: > > : > > > > Problems were basically all test/build related: > > * API oddities around FileChannel required a better hack (thanks > > Brian): > > http://mail.openjdk.java.net/pipermail/nio-dev/2015- > September/003322.h > > tml > This one is subtle

Re: jigsaw EA feedback for apache lucene

2015-09-10 Thread Alan Bateman
Uwe Schindler wrote: So you would first to find out the module of a class and then ask the module for the resource. Is there a way to get the module from the binary (string a la Class#forName()) class name without actually loading the class? Yes, you'd need the Class object so you can call

Re: jigsaw EA feedback for apache lucene

2015-09-10 Thread Robert Muir
On Thu, Sep 10, 2015 at 4:21 AM, Alan Bateman wrote: > >> * Cleaning up a bunch of bad package accesses, these were already >> TODOs in our test security policy, mostly just test bugs and the like. > > "bad package accesses", do you mean direct use of JDK-internal

Re: jigsaw EA feedback for Eclipse/JBoss Tools and WildFly

2015-09-10 Thread Alan Bateman
On 10/09/2015 14:21, Rory O'Donnell wrote: Martin - thanks for your feedback, not sure your email made it to the list without subscribing. It will now, rgds Rory On 10/09/2015 13:59, Martin Malina wrote: I reported it here: https://issues.jboss.org/browse/JBIDE-20635 Thanks for

Re: jigsaw EA feedback for apache lucene

2015-09-10 Thread Robert Muir
On Thu, Sep 10, 2015 at 8:10 AM, Alan Bateman wrote: > > If I understand you then you are finding these usages with JDK 7 and JDK 8 > because you're forced to configure the security policy to grant access to > these sun.* packages. So some extent then it means you have a

RE: jigsaw EA feedback for apache lucene

2015-09-10 Thread Uwe Schindler
Hi, > -Original Message- > From: jigsaw-dev [mailto:jigsaw-dev-boun...@openjdk.java.net] On Behalf > Of Alan Bateman > Sent: Thursday, September 10, 2015 12:23 PM > To: Sundararajan Athijegannathan; Robert Muir > Cc: jigsaw-dev@openjdk.java.net > Subject: Re: jigsaw EA feedback for apache

Re: jigsaw EA feedback for apache lucene

2015-09-10 Thread Dawid Weiss
> Yes, unfortunately when it comes to java libs this is "widespread" to > say the least. > Often this isn't even intentional. For example the failure in the static memory leak checker isn't caused by its codebase (no private class is referenced); the exception is thrown at runtime when test case

Re: jigsaw EA feedback for Eclipse/JBoss Tools and WildFly

2015-09-10 Thread Rory O'Donnell
Martin - thanks for your feedback, not sure your email made it to the list without subscribing. It will now, rgds Rory On 10/09/2015 13:59, Martin Malina wrote: Hi, Today I tried out the early access build of jdk 1.9 with jigsaw [1]. I tried it with JBoss Developer Studio 9.0.0.CR1 nightly

RE: jigsaw EA feedback for apache lucene

2015-09-10 Thread Uwe Schindler
Hi Alan, thanks for the useful information. I was able to fix the forbidden-apis checker to work correctly using the Class#getModule() approach. This can be done with easy core reflection also from older code that has to compile against Java 6. I tested it with the nightly build of b80 and

Re: Another Quick Start Guide Nitpick

2015-09-10 Thread Mani Sarkar
Jim, Yes that's another issue there. I meant to report - already switched it around in my bash scripts see the 5_Missing_xxx folders. One more thing while we are at it - wherever possible in the examples we need to mention that the javac and java commands should be executed from outside the src

RE: Groovy with Jigsaw

2015-09-10 Thread Robert Muir
I agree with Uwe. Practically this just makes more code to fix. I dont see any advantage of using a new exception, what is the rationale? Using an existing exception means existing try catch blocks will take care in many of these cases and just slow the adoption of java 9 even more. On Sep 10,

Re: Initial module-system design, API, and early-access builds

2015-09-10 Thread mark . reinhold
2015/9/10 3:00 -0700, snfu...@gmx.de: > reading the overview document I stumbled upon the sentence, that the > module declaration should by convention go to a file named > module-info.java and therefore complied to ||module-info.class file in > the root directory of the jar file. Does this

Re: Initial module-system design, API, and early-access builds

2015-09-10 Thread Stefan Fuchs
Hi, reading the overview document I stumbled upon the sentence, that the module declaration should by convention go to a file named module-info.java and therefore complied to ||module-info.class file in the root directory of the jar file. Does this mean, that a modular jar file may only

Re: Project Jigsaw: Early-Access Builds available on jdk9.java.net/jigsaw

2015-09-10 Thread Mandy Chung
On 09/10/2015 01:55 PM, Jim Connors wrote: When you run the com.greetings.Main class via: $ java -mp mods -m com.greetings/com.greetings.Main The Quick Start guide shows the output as: class org.fastsocket.FastNetworkSocket The Main.java file referenced above prints nothing (at

hg: jigsaw/jake/hotspot: Move code out of locked regsion to aid moving of logging code

2015-09-10 Thread alan . bateman
Changeset: 46f34d9a3520 Author:hseigel Date: 2015-09-10 20:42 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/46f34d9a3520 Move code out of locked regsion to aid moving of logging code ! src/share/vm/classfile/modules.cpp

Re: Project Jigsaw: Early-Access Builds available on jdk9.java.net/jigsaw

2015-09-10 Thread Alan Bateman
On 10/09/2015 17:15, Mani Sarkar wrote: Hi Rory, I have played with the Jigsaw JDK using the Quick starter guide and have this to share with our community: https://github.com/neomatrix369/jdk9-jigsaw There is a small mistake in the example on Services (see my implementation you will spot it

Re: Project Jigsaw: Early-Access Builds available on jdk9.java.net/jigsaw

2015-09-10 Thread Jim Connors
On 9/10/2015 4:30 PM, Alan Bateman wrote: I don't immediately see the error in the services example (I need to look closer) but I think you have a point that this example jumps ahead too much. Good idea to get the examples into a repo with scripts. In the Services Section:

Re: Project Jigsaw: Early-Access Builds available on jdk9.java.net/jigsaw

2015-09-10 Thread Mani Sarkar
Jim you stole my thunder and lightening - that was it. Cheers, Mani On Thu, Sep 10, 2015 at 9:55 PM, Jim Connors wrote: > On 9/10/2015 4:30 PM, Alan Bateman wrote: > > I don't immediately see the error in the services example (I need to look > closer) but I think you

Another Quick Start Guide Nitpick

2015-09-10 Thread Jim Connors
One more thing while I'm at it: In the "Missing requires or missing exports" section: http://openjdk.java.net/projects/jigsaw/quick-start#missing We now fix this module declaration but introduce a different mistake, this time we omit the |exports| from the |org.astro| module