Re: JOSM feedback on Java 7,8,9, including Jigsaw EA

2015-11-12 Thread Alan Bateman
On 12/11/2015 14:41, Wang Weijun wrote: make/Images.gmk uses both JDK_COMPACTn and JRE_COMPACTn. Should it be only JRE_COMPACTn? Yes, Images.gmk should be more consistent in the naming of its variables. -Alan

Re: RFR 8141521: jrt file system's DirectoryStream reports child paths with wrong paths for directories under /packages

2015-11-12 Thread Sundararajan Athijegannathan
May I get review(s) on the updated webrev please? http://cr.openjdk.java.net/~sundar/8141521/webrev.01/ Thanks, -Sundar On 11/11/2015 9:16 PM, Sundararajan Athijegannathan wrote: Hi, Please find the updated webrev @ http://cr.openjdk.java.net/~sundar/8141521/webrev.01/ * Removed NodeAndIma

hg: jigsaw/jake/jdk: Backout compressed resource header length change that breaks windows build

2015-11-12 Thread mandy . chung
Changeset: 103e023995ba Author:mchung Date: 2015-11-12 18:51 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/103e023995ba Backout compressed resource header length change that breaks windows build ! src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressedR

Re: Proposal to enhance jdeps tool to search split packages/add some kind of general API

2015-11-12 Thread Mandy Chung
> On Nov 12, 2015, at 2:39 AM, Patrick Reinhart wrote: > > Hi there, > > I like to do some early adoption tests with software using the new module > system. Now we got an unknown amount of split packages in our system, the we > will need to fix in order to migrate our codebase. > > I could i

Re: Annotations across modules

2015-11-12 Thread Alex Buckley
On 11/12/2015 5:50 AM, Stephen Colebourne wrote: My understanding of annotations today is that annotations are not required at runtime. ie. if an annotation is placed into a class at compile time but the .class file for the annotation is not available on the runtime classpath. then there is no er

RFR 9: 8141571 : jdk/internal/jimage/JImageReadTest.java crashing in msvcr120.dll

2015-11-12 Thread Roger Riggs
Please review additions to jimageFile to diagnose an intermittent failure. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-jimage-segv-8141571/ Issue: https://bugs.openjdk.java.net/browse/JDK-8141571 Thanks, Roger

Annotations across modules

2015-11-12 Thread Stephen Colebourne
My understanding of annotations today is that annotations are not required at runtime. ie. if an annotation is placed into a class at compile time but the .class file for the annotation is not available on the runtime classpath. then there is no error. Does this change in any way with modules? My

Re: JOSM feedback on Java 7,8,9, including Jigsaw EA

2015-11-12 Thread Wang Weijun
make/Images.gmk uses both JDK_COMPACTn and JRE_COMPACTn. Should it be only JRE_COMPACTn? --Max

hg: jigsaw/jake/jdk: Fix for 8142485. Jake doesn't build on Windows after recent change to libjimage

2015-11-12 Thread jean-francois . denise
Changeset: 1b50ccfd6f27 Author:jfdenise Date: 2015-11-12 15:00 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1b50ccfd6f27 Fix for 8142485. Jake doesn't build on Windows after recent change to libjimage Reviewed-by: jlaskey ! src/java.base/share/native/libjimage/imageDec

Proposal to enhance jdeps tool to search split packages/add some kind of general API

2015-11-12 Thread Patrick Reinhart
Hi there, I like to do some early adoption tests with software using the new module system. Now we got an unknown amount of split packages in our system, the we will need to fix in order to migrate our codebase. I could imagine, that there are other potential users of the JDK, that have the sa