Re: Unnamed module and duplicate package

2016-03-10 Thread Paul Benedict
On Thu, Mar 10, 2016 at 10:02 PM, Stephen Felts wrote: > Yes, it is compiling and running on Jigsaw. It’s not pretty but generally > getting better. I’m concerned about a number of behaviors that aren’t > pinned down yet and I’m worried that a discussion like this one will > introduce a non-upwa

RE: Unnamed module and duplicate package

2016-03-10 Thread Stephen Felts
Yes, it is compiling and running on Jigsaw.  It’s not pretty but generally getting better. I’m concerned about a number of behaviors that aren’t pinned down yet and I’m worried that a discussion like this one will introduce a non-upward-compatible behavior that will break things worse.   We ha

Re: Unnamed module and duplicate package

2016-03-10 Thread Paul Benedict
Stephen, regarding your first paragraph, I would like some more detail. Are you running your application server with jigsaw? Cheers, Paul On Thu, Mar 10, 2016 at 8:33 PM, Stephen Felts wrote: > I'm aware of classes in our application server (not javax) that are unused > when running with our ow

RE: Unnamed module and duplicate package

2016-03-10 Thread Stephen Felts
I'm aware of classes in our application server (not javax) that are unused when running with our own JVM and used when running with another JVM. In that case, the packages are duplicate of classes in the JDK. I would not want that usage to generate a fatal error. This is unrelated to endorsed ja

Re: Unnamed module and duplicate package

2016-03-10 Thread Alex Buckley
The subtlety is that the Endorsed Standards Override Mechanism interpreted "alternative implementations of the javax.* hierarchy" as "wholesale replacements of entire javax.* packages placed in the location specified by java.endorsed.dirs". It was never permissible to simply throw a handful of

hg: jigsaw/jake/langtools: suppress -sourcepath in internal Ant build

2016-03-10 Thread jonathan . gibbons
Changeset: 28556ee3299f Author:jjg Date: 2016-03-10 17:26 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/28556ee3299f suppress -sourcepath in internal Ant build ! make/build.xml

hg: jigsaw/jake/langtools: prohibit -sourcepath and -modulesourcepath together

2016-03-10 Thread jonathan . gibbons
Changeset: d34fb849c377 Author:jjg Date: 2016-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d34fb849c377 prohibit -sourcepath and -modulesourcepath together ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java ! src/jdk.compiler/sha

hg: jigsaw/jake/langtools: 2 new changesets

2016-03-10 Thread jonathan . gibbons
Changeset: ea916dd6ad45 Author:jjg Date: 2016-03-10 16:09 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ea916dd6ad45 fix CSS issues and merge issues ! src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/

Re: Unnamed module and duplicate package

2016-03-10 Thread Neil Bartlett
Paul, This sounds like you are suggesting a backwards-incompatible change to the behaviour of the application classpath. For example, many apps include on their classpath a library containing javax.transaction.xa, since the version of this package provided by the JDK is broken (omits several t

Re: Initial webrev with changes for JDK 9 - jimage

2016-03-10 Thread Jim Laskey (Oracle)
Thank you Roger. Comments inline. In general, I will hold off changes until after merge so as not to destabilize. Note that ImageBufferCache and Decompression are not currently used. > On Mar 8, 2016, at 2:07 PM, Roger Riggs wrote: > > Hi, > > Review comments for the jimage code in java.ba

hg: jigsaw/jake/jdk: 2 new changesets

2016-03-10 Thread mandy . chung
Changeset: 3a45b4e73ac5 Author:mchung Date: 2016-03-10 14:24 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3a45b4e73ac5 java.lang.reflect review comment ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java Changeset: 63693c17e651 Author:mchung Date

hg: jigsaw/jake/jdk: 2 new changesets

2016-03-10 Thread mandy . chung
Changeset: 780e06e3572b Author:lana Date: 2016-03-10 09:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/780e06e3572b Added tag jdk-9+109 for changeset 1c7bad079890 ! .hgtags Changeset: f4d2641ccce8 Author:mchung Date: 2016-03-10 14:09 -0800 URL: http://

hg: jigsaw/jake/jaxws: 2 new changesets

2016-03-10 Thread mandy . chung
Changeset: 0db939c930f3 Author:lana Date: 2016-03-10 09:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/0db939c930f3 Added tag jdk-9+109 for changeset 4b0697e4ce89 ! .hgtags Changeset: 0b5ceffe466b Author:mchung Date: 2016-03-10 14:09 -0800 URL: http:

hg: jigsaw/jake/corba: 2 new changesets

2016-03-10 Thread mandy . chung
Changeset: 9666775734fb Author:lana Date: 2016-03-10 09:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/9666775734fb Added tag jdk-9+109 for changeset b75afa17aefe ! .hgtags Changeset: 2dca1f095652 Author:mchung Date: 2016-03-10 14:08 -0800 URL: http:

hg: jigsaw/jake/hotspot: 2 new changesets

2016-03-10 Thread mandy . chung
Changeset: 407003fcbdb9 Author:lana Date: 2016-03-10 09:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/407003fcbdb9 Added tag jdk-9+109 for changeset 7e7e50ac4faf ! .hgtags Changeset: 81db3766ab04 Author:mchung Date: 2016-03-10 14:09 -0800 URL: htt

hg: jigsaw/jake/langtools: 2 new changesets

2016-03-10 Thread mandy . chung
Changeset: 47206f242e0a Author:lana Date: 2016-03-10 09:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/47206f242e0a Added tag jdk-9+109 for changeset f5991c73ed73 ! .hgtags Changeset: a311acb5b771 Author:mchung Date: 2016-03-10 14:09 -0800 URL: h

hg: jigsaw/jake: 2 new changesets

2016-03-10 Thread mandy . chung
Changeset: b0d82bafd78d Author:lana Date: 2016-03-10 09:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/b0d82bafd78d Added tag jdk-9+109 for changeset 1787bdaabb2b ! .hgtags Changeset: 579099c4d41d Author:mchung Date: 2016-03-10 14:08 -0800 URL: http://hg.o

hg: jigsaw/jake/jaxp: 2 new changesets

2016-03-10 Thread mandy . chung
Changeset: d9afbcf9f454 Author:lana Date: 2016-03-10 09:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/d9afbcf9f454 Added tag jdk-9+109 for changeset 24e247ee1fff ! .hgtags Changeset: 6ac32375d722 Author:mchung Date: 2016-03-10 14:08 -0800 URL: http:/

Re: Unnamed module and duplicate package

2016-03-10 Thread Alex Buckley
Yes -- and also the javax.** APIs in the modules directly required by java.se.ee (see http://openjdk.java.net/jeps/200). Alex On 3/10/2016 1:41 PM, David M. Lloyd wrote: One case to consider is javax.transaction.xa, which is part of the JDK and also in the JTA API along with javax.transaction.

Re: Unnamed module and duplicate package

2016-03-10 Thread Alex Buckley
This would entail the module system enumerating every JAR on the classpath after creating the module graph, in order to detect whether the unnamed module splits any package exported by any named module. There's no reason to special case JDK modules -- augmenting a user module would lead to erro

RE: Unnamed module and duplicate package

2016-03-10 Thread Stephen Felts
We allowed classes in the classpath that were provided by the JDK to go silently unchallenged. I think making this an error will be a big problem. -Original Message- From: Paul Benedict [mailto:pbened...@apache.org] Sent: Thursday, March 10, 2016 4:25 PM To: Alex Buckley Cc: jigsaw-de

Re: Unnamed module and duplicate package

2016-03-10 Thread David M. Lloyd
One case to consider is javax.transaction.xa, which is part of the JDK and also in the JTA API along with javax.transaction. On 03/09/2016 05:13 PM, Alex Buckley wrote: Paul, thank you for asking. The module system's treatment of the unnamed module vis-a-vis named modules is probably the bigges

Re: Unnamed module and duplicate package

2016-03-10 Thread Paul Benedict
My apologies for omitting some key qualifiers in my explanation. Read everything as a proposal to prohibit classpath jars from silently splitting whatever packages the JDK exports. -- Thanks On Thu, Mar 10, 2016 at 3:25 PM, Paul Benedict wrote: > Alex, > > For the sake of usability, however, it

Re: Unnamed module and duplicate package

2016-03-10 Thread Paul Benedict
Alex, For the sake of usability, however, it would be nice if the JDK verified that jars do not contain any exported JDK packages. This would be an RFE. I understand that in order to avoid split packages between modules and classpath, the module version takes precedent. For developer vs. developer

Re: Unnamed module and duplicate package

2016-03-10 Thread Alex Buckley
Yes, we can keep tightening the split package scenario to ensure safety without scanning the classpath. First, you have to promise that the JAR on the classpath never has classes that overlap with a module in the system image. Second, the named module of interest in the system image can't be a

Re: Unnamed module and duplicate package

2016-03-10 Thread Alex Buckley
I see xml-apis.jar (2.0.2) contains: - a javax.xml.parser package, which includes a FactoryFinder class that's not in Java SE, and - a javax.xml.transform package hierarchy, whose types at first glance look identical to those in Java SE except for yet another FactoryFinder class in javax.xml

hg: jigsaw/jake/hotspot: Renamed tests based on feedback

2016-03-10 Thread christian . tornqvist
Changeset: 7d54046f40aa Author:gtriantafill Date: 2016-03-10 12:17 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/7d54046f40aa Renamed tests based on feedback + test/runtime/modules/AccessCheck/CheckRead.java + test/runtime/modules/AccessCheck/DiffCL_CheckRead.java +

hg: jigsaw/jake/langtools: Fix GenModuleInfo.java failing on windows

2016-03-10 Thread mandy . chung
Changeset: 5bc1e98df6d3 Author:mchung Date: 2016-03-10 11:23 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5bc1e98df6d3 Fix GenModuleInfo.java failing on windows ! test/tools/jdeps/modules/GenModuleInfo.java

Re: Unnamed module and duplicate package

2016-03-10 Thread Paul Benedict
Alex, there are JARs that contain javax packages. Anyone in the web development community knows how many people have included xml-apis in their WEB-INF :-) only to find out it wasn't loaded or it took precedent over the JDK versions. Has Jigsaw introduced any restrictions here on this front? Hones

hg: jigsaw/jake/jdk: 46 new changesets

2016-03-10 Thread mandy . chung
Changeset: d6dbe934ed0f Author:rriggs Date: 2016-02-29 18:00 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d6dbe934ed0f 8150346: java/lang/ProcessHandle/InfoTest.java failed - startTime after process spawn completed Reviewed-by: redestad, martin ! test/java/lang/Proces

hg: jigsaw/jake: 6 new changesets

2016-03-10 Thread mandy . chung
Changeset: 009487c0169b Author:erikj Date: 2016-03-07 09:13 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/009487c0169b 8151300: Build shell trace functionality lost in JDK-8076060 Reviewed-by: tbell ! make/common/MakeBase.gmk Changeset: 2436705f4a75 Author:erikj Date:

hg: jigsaw/jake/langtools: 15 new changesets

2016-03-10 Thread mandy . chung
Changeset: 20c4b78bf457 Author:alundblad Date: 2016-03-02 12:54 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/20c4b78bf457 8150941: Sjavac should not wait for portfile to materialize if server process is terminated Summary: Sjavac cancels forking early if server p

hg: jigsaw/jake/jaxws: 3 new changesets

2016-03-10 Thread mandy . chung
Changeset: ebff1bd3627a Author:aefimov Date: 2016-03-01 17:19 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/ebff1bd3627a 8150174: Update JAX-WS RI integration to latest version (2.3.0-SNAPSHOT) Reviewed-by: lancea ! src/java.xml.bind/share/classes/com/sun/xml/interna

hg: jigsaw/jake/hotspot: 41 new changesets

2016-03-10 Thread mandy . chung
Changeset: 0b63d854f7a6 Author:kbarrett Date: 2016-02-16 21:58 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0b63d854f7a6 8146728: TestPrintGCDetailsVerbose is never run by jtreg Summary: Remove requirement for fastdebug, update logging option Reviewed-by: sjohanss,

Re: Automatic module names

2016-03-10 Thread Alan Bateman
On 10/03/2016 08:27, Stephen Colebourne wrote: : Joda-Time compiles for JDK 1.5, other Joda projects for 1..6. Last time I looked, the tool didn't go back far enough to be useful. It's three back so `javac -release 6` should be okay. -Alan.

Re: Automatic module names

2016-03-10 Thread Paul Benedict
Yes, Stephen is correct. This is true. And as Robert Scholte of Maven pointed out, he still needs to support JRE 6 as the minimum. Lots of OSS projects still target 6. I think we should give them a little help in this area. Cheers, Paul On Thu, Mar 10, 2016 at 2:27 AM, Stephen Colebourne wrote:

hg: jigsaw/jake/hotspot: Cleanup from internal code review comments.

2016-03-10 Thread lois . foltan
Changeset: 291f29771cd0 Author:lfoltan Date: 2016-03-10 09:43 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/291f29771cd0 Cleanup from internal code review comments. ! src/share/vm/classfile/moduleEntry.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/runtime/argumen

hg: jigsaw/jake: Fixing JDK-8149775: Exploded image has _the. files on system module path

2016-03-10 Thread erik . joelsson
Changeset: 6b9bb0953873 Author:erikj Date: 2016-03-10 15:39 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/6b9bb0953873 Fixing JDK-8149775: Exploded image has _the. files on system module path ! make/CreateJmods.gmk ! make/common/JavaCompilation.gmk

hg: jigsaw/jake/hotspot: Fix issue with test JFR capturing system properties at startup.

2016-03-10 Thread lois . foltan
Changeset: ee0c70bdad15 Author:lfoltan Date: 2016-03-10 09:08 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ee0c70bdad15 Fix issue with test JFR capturing system properties at startup. ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp

hg: jigsaw/jake/jdk: Use String.isEmpty() instead of checking for "".

2016-03-10 Thread harold . seigel
Changeset: 0a46b03f327c Author:hseigel Date: 2016-03-10 08:19 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0a46b03f327c Use String.isEmpty() instead of checking for "". ! src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java

Re: Unnamed module and duplicate package

2016-03-10 Thread Alan Bateman
On 10/03/2016 12:39, David M. Lloyd wrote: I presume this wouldn't happen if the packages were sealed though, whether in Java 8 or earlier or under the unnamed module in Java 9. Right? That's right although I don't think sealed packages have been popular. With named modules then the packag

hg: jigsaw/jake/langtools: Fixing tests on Win.

2016-03-10 Thread jan . lahoda
Changeset: 4316d49b4bb1 Author:jlahoda Date: 2016-03-10 14:35 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4316d49b4bb1 Fixing tests on Win. ! test/tools/javac/modules/AddLimitMods.java ! test/tools/javac/modules/AnnotationProcessorsInModulesTest.java ! test/tool

Re: Unnamed module and duplicate package

2016-03-10 Thread David M. Lloyd
I presume this wouldn't happen if the packages were sealed though, whether in Java 8 or earlier or under the unnamed module in Java 9. Right? On 03/09/2016 03:17 PM, Paul Benedict wrote: But isn't what your proposing a security issue? Let's say my package A is in the unnamed module and your pa

Re: Automatic module names

2016-03-10 Thread Stephen Colebourne
On 10 March 2016 at 07:58, Alan Bateman wrote: > Keep in mind that a compiled module-info can be added to a JAR file where > the code is otherwise compiled for an older release. If you are willing to > tolerate a newer JDK in your build environment then you can compile that > code with `javac -rel