Re: RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

Looks good -Sundar On 6/9/2016 1:15 AM, Jim Laskey (Oracle) wrote: > Consistent use of PathPatterns for jlink, jimage and jmod options. > > —optionName=(regex:|glob:|) ?? where => > glob: > > http://cr.openjdk.java.net/~jlaskey/8158402/webrev/index.html >

Re: RFR 8158855: Fix remaining module dependences in java/lang

Hi Shura, test/java/lang/Class/GetModuleTest.java This can use java.base/jdk.internal.misc.Unsafe instead. Other @modules looks okay. Regarding the executeTestJava change, if you drop the VM options, this test will only exercise the default launcher setting. The hotspot nightlies depend

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

Adding jigsaw-dev where the code review is posted. See [1] for Coleen’s review comment. > On Jun 8, 2016, at 4:53 PM, David Holmes wrote: > > On 9/06/2016 8:37 AM, Coleen Phillimore wrote: >> >> >> I have to ask why Hotspot convention was violated with this new

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 8, 2016, at 3:37 PM, Coleen Phillimore > wrote: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.01/jdk/src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java.udiff.html > > + /** > + * Gets and remove the named system

RFR: JDK-8158402 - jlink: should use regex for all pattern operations (--order-resources or --exclude-resources)

Consistent use of PathPatterns for jlink, jimage and jmod options. —optionName=(regex:|glob:|) ?? where => glob: http://cr.openjdk.java.net/~jlaskey/8158402/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8158402

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 8, 2016, at 10:30 AM, Dmitry Dmitriev > wrote: > > Hello Mandy, > > As I understand all these options are tested by following tests: > jdk/test/tools/launcher/modules. I.e. no additional tests are required for > moving these options to the VM(except 2

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

Hi Mandy, Yes, I can make that change. Thanks for pointing it out. Harold On 6/8/2016 12:35 PM, Mandy Chung wrote: Updated webrev with Harold’s latest VM change incorporating the review comments: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.01/index.html Harold - the

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

Updated webrev with Harold’s latest VM change incorporating the review comments: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.01/index.html Harold - the revised VM change looks okay to me. Minor one: you define the following: 202 #define MODULE_PATH_PROPERTY

Re: Issue trying to use CORBA classes from javac

On 08/06/2016 10:16, Michael Musgrove wrote: I have followed your (and Andrew's) advice and patched the java.corba module and updated my maven poms to use the patch and made good progress as a result, so thanks for your help here. I do have another potential blocker: this time I (or rather

Re: RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

On 08/06/2016 08:43, Aleksey Shipilev wrote: : Where do you want this to go? jdk9/dev or somewhere in jake? This one is jdk9/dev. -Alan

Re: RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

On 06/08/2016 09:28 AM, Alan Bateman wrote: > On 07/06/2016 18:25, Aleksey Shipilev wrote: > >> All right, I will fix the issue that *actually* bites me in the bottom >> all the time: MH.publicLookup() init circularity. Here's a webrev >> without an inline blob: >>

Re: RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

On 07/06/2016 18:25, Aleksey Shipilev wrote: All right, I will fix the issue that *actually* bites me in the bottom all the time: MH.publicLookup() init circularity. Here's a webrev without an inline blob: http://cr.openjdk.java.net/~shade/8158851/webrev.03/ If you want to improve startup