Re: Module name check is too restrictive

Hi Remi, Thanks for pointing this out. We have entered bug https://bugs.openjdk.java.net/browse/JDK-8164969 for this issue. Harold On 8/28/2016 3:31 PM, Remi Forax wrote: While testing ASM, i've found that you can not currently load a module that has a '+' in its name. /usr/jdk/jdk-9-jigs

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

On 29/08/2016 14:28, Sundararajan Athijegannathan wrote: Updated: http://cr.openjdk.java.net/~sundar/8159004/webrev.02/ -Sundar This looks okay to me. -Alan

Re: Review Request: JDK-8160851: Remove old module-related options

After further discussion off line we are aiming to get the fix for JDK-8163316 into this week's build of jdk-9+134. -- Kevin Mandy Chung wrote: On Aug 26, 2016, at 4:17 PM, Kevin Rushforth wrote: Hi Mandy, How soon were you thinking to push this to 9-dev? Until we change JavaFX to use

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

Updated: http://cr.openjdk.java.net/~sundar/8159004/webrev.02/ -Sundar On 8/29/2016 5:52 PM, Alan Bateman wrote: > On 29/08/2016 13:00, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ >> for https://bugs.openjdk.java.net/browse/JDK-815

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

On 29/08/2016 13:00, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8159004 Piggybacking couple of cleanups suggested (but missed) in this thread -> http://mail.openjdk.java.net/pipermail/ji

Re: RFR: JDK-8161000 - GPL header incorrect - classfile/classpath

On 29/08/2016 13:16, Jim Laskey (Oracle) wrote: On behalf of Swamy http://cr.openjdk.java.net/~jlaskey/8161000/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8161000 +1

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

+1 > On Aug 29, 2016, at 9:00 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8159004 > > Piggybacking couple of cleanups suggested (but missed) in this thread -> > http://mail.op

Re: RFR 8164800: Cross targeting Windows

Fixing along with another fix -> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-August/009210.html Thanks -Sundar On 8/26/2016 9:56 PM, Remi Forax wrote: > Hi Sundararajan, > Also, in createArgs(), instead Collections.unmodifiableList(), you can use > List.of(). > > regards, > Rémi > >

RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8159004 Piggybacking couple of cleanups suggested (but missed) in this thread -> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-August/009186.html Thanks, -Sundar